All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Early printk support for virtio console devices.
Date: Fri, 26 Apr 2013 14:33:59 +0200	[thread overview]
Message-ID: <1577576.O1Cm2pf5KD@wuerfel> (raw)
In-Reply-To: <CALrVBkuOmu4u9egdzzfn1tU9B-CFe3w85HZQ9s2gpKvYnaSqvA@mail.gmail.com>

On Friday 26 April 2013 17:36:16 Anup Patel wrote:
> On 26 April 2013 17:03, Peter Maydell <peter.maydell@linaro.org> wrote:
> > On 26 April 2013 12:19, Alexander Graf <agraf@suse.de> wrote:
> >> MMIO registers are handled by a different layer than the virtio
> >> console itself. After the virtio refactoring in QEMU, they will
> >> be completely separate drivers.
> >
> > Good point -- we don't really want to be mixing up the
> > transport and the backend. You can see it in the kvmtool
> > patch, in fact -- it introduces an "if this is virtio-console"
> > special case into the mmio.c file which previously was
> > entirely backend agnostic.
> 
> Well, we can always have virtio device specific config registers
> handle by virtio device backends and generic virtio config register
> handled by transport.
> 
> kvmtool patch is hacky because it does not provide virtio device
> specific config read/write callbacks.

Couldn't kvmtool implement the interface used by smh_printch()
for early output instead?

Or if that's not a fitting inteface, maybe a psci call for writing
a character to the console?

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linaro-kernel@lists.linaro.org
Cc: Anup Patel <anup.patel@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	patches@linaro.org,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>, Alexander Graf <agraf@suse.de>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] Early printk support for virtio console devices.
Date: Fri, 26 Apr 2013 14:33:59 +0200	[thread overview]
Message-ID: <1577576.O1Cm2pf5KD@wuerfel> (raw)
In-Reply-To: <CALrVBkuOmu4u9egdzzfn1tU9B-CFe3w85HZQ9s2gpKvYnaSqvA@mail.gmail.com>

On Friday 26 April 2013 17:36:16 Anup Patel wrote:
> On 26 April 2013 17:03, Peter Maydell <peter.maydell@linaro.org> wrote:
> > On 26 April 2013 12:19, Alexander Graf <agraf@suse.de> wrote:
> >> MMIO registers are handled by a different layer than the virtio
> >> console itself. After the virtio refactoring in QEMU, they will
> >> be completely separate drivers.
> >
> > Good point -- we don't really want to be mixing up the
> > transport and the backend. You can see it in the kvmtool
> > patch, in fact -- it introduces an "if this is virtio-console"
> > special case into the mmio.c file which previously was
> > entirely backend agnostic.
> 
> Well, we can always have virtio device specific config registers
> handle by virtio device backends and generic virtio config register
> handled by transport.
> 
> kvmtool patch is hacky because it does not provide virtio device
> specific config read/write callbacks.

Couldn't kvmtool implement the interface used by smh_printch()
for early output instead?

Or if that's not a fitting inteface, maybe a psci call for writing
a character to the console?

	Arnd

  reply	other threads:[~2013-04-26 12:33 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 11:04 [PATCH 0/2] Early printk support for virtio console devices Pranavkumar Sawargaonkar
2013-04-26 11:04 ` Pranavkumar Sawargaonkar
2013-04-26 11:04 ` [PATCH 1/2] virtio: console: Add early writeonly register to config space Pranavkumar Sawargaonkar
2013-04-26 11:04   ` Pranavkumar Sawargaonkar
2013-04-29  3:10   ` Rusty Russell
2013-04-29  3:10     ` Rusty Russell
2013-04-26 11:04 ` [PATCH 2/2] arm64: earlyprintk support for virtio-mmio console Pranavkumar Sawargaonkar
2013-04-26 11:04   ` Pranavkumar Sawargaonkar
2013-04-26 11:19 ` [PATCH 0/2] Early printk support for virtio console devices Alexander Graf
2013-04-26 11:19   ` Alexander Graf
2013-04-26 11:33   ` Peter Maydell
2013-04-26 11:33     ` Peter Maydell
2013-04-26 12:06     ` Anup Patel
2013-04-26 12:06       ` Anup Patel
2013-04-26 12:33       ` Arnd Bergmann [this message]
2013-04-26 12:33         ` Arnd Bergmann
2013-04-26 12:59         ` Anup Patel
2013-04-26 12:59           ` Anup Patel
2013-04-26 15:03           ` Arnd Bergmann
2013-04-26 15:03             ` Arnd Bergmann
2013-04-26 15:54             ` Marc Zyngier
2013-04-26 15:54               ` Marc Zyngier
2013-04-26 15:19         ` Peter Maydell
2013-04-26 15:19           ` Peter Maydell
2013-04-29  3:09   ` Rusty Russell
2013-04-29  3:09     ` Rusty Russell
2013-04-29 12:22     ` Alexander Graf
2013-04-29 12:22       ` Alexander Graf
2013-04-29 12:48       ` Pranavkumar Sawargaonkar
2013-04-29 12:48         ` Pranavkumar Sawargaonkar
2013-04-29 12:53         ` Alexander Graf
2013-04-29 12:53           ` Alexander Graf
2013-05-01  2:07           ` Rusty Russell
2013-05-01  2:07             ` Rusty Russell
2013-05-01  6:53             ` Anup Patel
2013-05-01  6:53               ` Anup Patel
2013-05-01 14:46               ` Will Deacon
2013-05-01 14:46                 ` Will Deacon
2013-05-02 10:06             ` Peter Maydell
2013-05-02 10:06               ` Peter Maydell
2013-05-06  5:11               ` Rusty Russell
2013-05-06  5:11                 ` Rusty Russell
2013-05-06  9:14                 ` Peter Maydell
2013-05-06  9:14                   ` Peter Maydell
2013-05-07  4:46                   ` Rusty Russell
2013-05-07  4:46                     ` Rusty Russell
2013-05-07 12:19                     ` Peter Maydell
2013-05-07 12:19                       ` Peter Maydell
2013-05-07 15:52                       ` Christopher Covington
2013-05-07 15:52                         ` Christopher Covington
2013-05-07 15:58                         ` Peter Maydell
2013-05-07 15:58                           ` Peter Maydell
2013-05-08 14:17                           ` Catalin Marinas
2013-05-08 14:17                             ` Catalin Marinas
2013-05-09 10:39                             ` Grant Likely
2013-05-09 10:39                               ` Grant Likely
2013-05-06  9:40                 ` Pranavkumar Sawargaonkar
2013-05-06  9:40                   ` Pranavkumar Sawargaonkar
2013-04-29 12:50       ` Peter Maydell
2013-04-29 12:50         ` Peter Maydell
2013-04-29 12:53         ` Alexander Graf
2013-04-29 12:53           ` Alexander Graf
2013-04-30  0:32       ` Rusty Russell
2013-04-30  0:32         ` Rusty Russell
2013-05-01  0:26         ` Alexander Graf
2013-05-01  0:26           ` Alexander Graf
2013-05-01  5:01           ` Anup Patel
2013-05-01  5:01             ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1577576.O1Cm2pf5KD@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.