All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
	James.Bottomley@HansenPartnership.com,
	linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
	mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
	sashal@kernel.org, jamorris@linux.microsoft.com,
	linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v6 1/3] IMA: Define workqueue for early boot key measurements
Date: Fri, 03 Jan 2020 14:15:37 +0000	[thread overview]
Message-ID: <1578060937.5874.140.camel@linux.ibm.com> (raw)
In-Reply-To: <20200103055608.22491-2-nramas@linux.microsoft.com>

Hi Lakshmi,

On Thu, 2020-01-02 at 21:56 -0800, Lakshmi Ramasubramanian wrote:
> Measuring keys requires a custom IMA policy to be loaded.
> Keys created or updated before a custom IMA policy is loaded should
> be queued and the keys should be processed after a custom policy
> is loaded.
> 
> This patch defines workqueue for queuing keys when a custom IMA policy
> has not yet been loaded.
> 
> A flag namely ima_process_keys is used to check if the key should be
> queued or should be processed immediately.
> 
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Reported-by: kbuild test robot <lkp@intel.com>

The changes based on "kernel test robot" reports are properly folded
into this patch, but unless the tag - "Acked-by", "Reported-by" - is
qualified, it refers to the entire patch.  Let's limit it as:

Reported-by: kernel test robot <rong.a.chen@intel.com> # sleeping
function called from invalid context
Reported-by: kbuild test robot <lkp@intel.com> # sparse symbol
ima_queued_key() should be static

Mimi

WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
	James.Bottomley@HansenPartnership.com,
	linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
	mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
	sashal@kernel.org, jamorris@linux.microsoft.com,
	linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v6 1/3] IMA: Define workqueue for early boot key measurements
Date: Fri, 03 Jan 2020 09:15:37 -0500	[thread overview]
Message-ID: <1578060937.5874.140.camel@linux.ibm.com> (raw)
In-Reply-To: <20200103055608.22491-2-nramas@linux.microsoft.com>

Hi Lakshmi,

On Thu, 2020-01-02 at 21:56 -0800, Lakshmi Ramasubramanian wrote:
> Measuring keys requires a custom IMA policy to be loaded.
> Keys created or updated before a custom IMA policy is loaded should
> be queued and the keys should be processed after a custom policy
> is loaded.
> 
> This patch defines workqueue for queuing keys when a custom IMA policy
> has not yet been loaded.
> 
> A flag namely ima_process_keys is used to check if the key should be
> queued or should be processed immediately.
> 
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> Reported-by: kernel test robot <rong.a.chen@intel.com>
> Reported-by: kbuild test robot <lkp@intel.com>

The changes based on "kernel test robot" reports are properly folded
into this patch, but unless the tag - "Acked-by", "Reported-by" - is
qualified, it refers to the entire patch.  Let's limit it as:

Reported-by: kernel test robot <rong.a.chen@intel.com> # sleeping
function called from invalid context
Reported-by: kbuild test robot <lkp@intel.com> # sparse symbol
ima_queued_key() should be static

Mimi


  reply	other threads:[~2020-01-03 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  5:56 [PATCH v6 0/3] IMA: Deferred measurement of keys Lakshmi Ramasubramanian
2020-01-03  5:56 ` Lakshmi Ramasubramanian
2020-01-03  5:56 ` [PATCH v6 1/3] IMA: Define workqueue for early boot key measurements Lakshmi Ramasubramanian
2020-01-03  5:56   ` Lakshmi Ramasubramanian
2020-01-03 14:15   ` Mimi Zohar [this message]
2020-01-03 14:15     ` Mimi Zohar
2020-01-03  5:56 ` [PATCH v6 2/3] IMA: Call workqueue functions to measure queued keys Lakshmi Ramasubramanian
2020-01-03  5:56   ` Lakshmi Ramasubramanian
2020-01-03  5:56 ` [PATCH v6 3/3] IMA: Defined timer to free " Lakshmi Ramasubramanian
2020-01-03  5:56   ` Lakshmi Ramasubramanian
2020-01-03 15:08 ` [PATCH v6 0/3] IMA: Deferred measurement of keys Mimi Zohar
2020-01-03 15:08   ` Mimi Zohar
2020-01-03 15:47   ` Mimi Zohar
2020-01-03 15:47     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1578060937.5874.140.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dhowells@redhat.com \
    --cc=eric.snowberg@oracle.com \
    --cc=jamorris@linux.microsoft.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthewgarrett@google.com \
    --cc=nramas@linux.microsoft.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.