From: Vikas Gupta <vikas.gupta@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Sheetal Tigadoli" <sheetal.tigadoli@broadcom.com>,
netdev@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Sumit Garg" <sumit.garg@linaro.org>
Cc: vasundhara-v.volam@broadcom.com, vikram.prakash@broadcom.com,
Vikas Gupta <vikas.gupta@broadcom.com>
Subject: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context
Date: Fri, 3 Jan 2020 21:50:03 +0530 [thread overview]
Message-ID: <1578068404-26195-1-git-send-email-vikas.gupta@broadcom.com> (raw)
Fix calling multiple tee_client_close_context in case of shm allocation
fails.
Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”)
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89..ed10da5 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
if (IS_ERR(fw_shm_pool)) {
- tee_client_close_context(pvt_data.ctx);
dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
err = PTR_ERR(fw_shm_pool);
goto out_sess;
--
2.7.4
next reply other threads:[~2020-01-03 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 16:20 Vikas Gupta [this message]
2020-01-03 16:20 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Reduce shm mem size to 4K Vikas Gupta
2020-01-05 22:47 ` [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context David Miller
2020-01-06 6:25 ` Vikas Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578068404-26195-1-git-send-email-vikas.gupta@broadcom.com \
--to=vikas.gupta@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sheetal.tigadoli@broadcom.com \
--cc=sumit.garg@linaro.org \
--cc=vasundhara-v.volam@broadcom.com \
--cc=vikram.prakash@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.