From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
James.Bottomley@HansenPartnership.com,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH 2/4] KEYS: Call the IMA hook to measure keys
Date: Tue, 07 Jan 2020 22:51:52 +0000 [thread overview]
Message-ID: <1578437512.5222.110.camel@linux.ibm.com> (raw)
In-Reply-To: <20200107194350.3782-3-nramas@linux.microsoft.com>
On Tue, 2020-01-07 at 11:43 -0800, Lakshmi Ramasubramanian wrote:
> Call the IMA hook from key_create_or_update() function to measure
> the payload when a new key is created or an existing key is updated.
>
> This patch adds the call to the IMA hook from key_create_or_update()
> function to measure the key on key create or update.
>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Reported-by: kbuild test robot <lkp@intel.com> # ima_asymmetric_keys.c
> is built as a kernel module when it is actually not.
> Fixes: cb1aa3823c92 ("KEYS: Call the IMA hook to measure keys")
There are two ways of addressing a bug report. One is by fixing the
original patch, while the other addresses the bug as a separate patch.
If the fix is squashed into the original patch, the commit number
will change. Only if the fix is a separate patch, would you include
the "Fixes" tag.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
James.Bottomley@HansenPartnership.com,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH 2/4] KEYS: Call the IMA hook to measure keys
Date: Tue, 07 Jan 2020 17:51:52 -0500 [thread overview]
Message-ID: <1578437512.5222.110.camel@linux.ibm.com> (raw)
In-Reply-To: <20200107194350.3782-3-nramas@linux.microsoft.com>
On Tue, 2020-01-07 at 11:43 -0800, Lakshmi Ramasubramanian wrote:
> Call the IMA hook from key_create_or_update() function to measure
> the payload when a new key is created or an existing key is updated.
>
> This patch adds the call to the IMA hook from key_create_or_update()
> function to measure the key on key create or update.
>
> Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Reported-by: kbuild test robot <lkp@intel.com> # ima_asymmetric_keys.c
> is built as a kernel module when it is actually not.
> Fixes: cb1aa3823c92 ("KEYS: Call the IMA hook to measure keys")
There are two ways of addressing a bug report. One is by fixing the
original patch, while the other addresses the bug as a separate patch.
If the fix is squashed into the original patch, the commit number
will change. Only if the fix is a separate patch, would you include
the "Fixes" tag.
Mimi
next prev parent reply other threads:[~2020-01-07 22:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 19:43 [PATCH 0/4] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2020-01-07 19:43 ` Lakshmi Ramasubramanian
2020-01-07 19:43 ` [PATCH 1/4] IMA: Define an IMA hook to measure keys Lakshmi Ramasubramanian
2020-01-07 19:43 ` Lakshmi Ramasubramanian
2020-01-07 22:26 ` James Bottomley
2020-01-07 22:26 ` James Bottomley
2020-01-07 19:43 ` [PATCH 2/4] KEYS: Call the " Lakshmi Ramasubramanian
2020-01-07 19:43 ` Lakshmi Ramasubramanian
2020-01-07 22:51 ` Mimi Zohar [this message]
2020-01-07 22:51 ` Mimi Zohar
2020-01-07 19:43 ` [PATCH 3/4] IMA: Add support to limit measuring keys Lakshmi Ramasubramanian
2020-01-07 19:43 ` Lakshmi Ramasubramanian
2020-01-07 19:43 ` [PATCH 4/4] IMA: Read keyrings= option from the IMA policy Lakshmi Ramasubramanian
2020-01-07 19:43 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1578437512.5222.110.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthewgarrett@google.com \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.