From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Paul Boddie <paul@boddie.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Andi Kleen <ak@linux.intel.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Kees Cook <keescook@chromium.org>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC
Date: Fri, 14 Feb 2020 16:13:53 -0300 [thread overview]
Message-ID: <1581707633.3.8@crapouillou.net> (raw)
In-Reply-To: <42aed0c7c063fa6c289fcbf361645056e15f513c.1581696624.git.hns@goldelico.com>
Hi Nikolaus,
Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> Interrupts should not be specified by interrupt line but by
> gpio parent and reference.
>
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
If you add a Fixes tag, you should also add:
Cc: stable@vger.kernel.org
if you're fixing something older than -rc1, which is the case here
(alternatively Cc them manually, but just for these patches).
Same remark for your patch 05/12.
Cheers,
-Paul
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 8f9d182566db..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -298,7 +298,9 @@ Optional input supply properties:
> rtc@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> - interrupts = <110>;
> +
> + interrupt-parent = <&gpf>;
> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> --
> 2.23.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Paul Boddie <paul@boddie.org.uk>,
Kees Cook <keescook@chromium.org>,
Paul Burton <paulburton@kernel.org>,
David Airlie <airlied@linux.ie>,
kernel@pyra-handheld.com, linux-mips@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC
Date: Fri, 14 Feb 2020 16:13:53 -0300 [thread overview]
Message-ID: <1581707633.3.8@crapouillou.net> (raw)
In-Reply-To: <42aed0c7c063fa6c289fcbf361645056e15f513c.1581696624.git.hns@goldelico.com>
Hi Nikolaus,
Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller
<hns@goldelico.com> a écrit :
> Interrupts should not be specified by interrupt line but by
> gpio parent and reference.
>
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
If you add a Fixes tag, you should also add:
Cc: stable@vger.kernel.org
if you're fixing something older than -rc1, which is the case here
(alternatively Cc them manually, but just for these patches).
Same remark for your patch 05/12.
Cheers,
-Paul
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 8f9d182566db..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -298,7 +298,9 @@ Optional input supply properties:
> rtc@51 {
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> - interrupts = <110>;
> +
> + interrupt-parent = <&gpf>;
> + interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> };
> };
>
> --
> 2.23.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-14 19:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 16:10 [PATCH v2 00/12] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 19:06 ` Paul Cercueil
2020-02-14 19:06 ` Paul Cercueil
2020-02-14 19:24 ` H. Nikolaus Schaller
2020-02-14 19:24 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 02/12] MIPS: DTS: jz4780: add #includes for irq.h and gpio.h H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 03/12] MIPS: CI20: defconfig: configure for supporting modules H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 19:10 ` Paul Cercueil
2020-02-14 19:10 ` Paul Cercueil
2020-02-14 19:30 ` H. Nikolaus Schaller
2020-02-14 19:30 ` H. Nikolaus Schaller
2020-02-14 19:42 ` Paul Cercueil
2020-02-14 19:42 ` Paul Cercueil
2020-02-14 16:10 ` [PATCH v2 04/12] MIPS: CI20: defconfig: compile leds-gpio driver into the kernel and configure for LED triggers H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 05/12] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 06/12] MIPS: CI20: defconfig: configure CONFIG_REGULATOR_ACT8865 for PMU H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 07/12] MIPS: DTS: CI20: give eth0_power a defined voltage H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 08/12] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 09/12] MIPS: CI20: defconfig: compile gpio-ir driver H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 10/12] MIPS: DTS: CI20: add DT node for SW1 as Enter button H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 11/12] MIPS: CI20: defconfig: configure for CONFIG_KEYBOARD_GPIO=m H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 16:10 ` [PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
2020-02-14 16:10 ` H. Nikolaus Schaller
2020-02-14 19:13 ` Paul Cercueil [this message]
2020-02-14 19:13 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581707633.3.8@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=ak@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@boddie.org.uk \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.