From: James Bottomley <jejb@linux.ibm.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Sumit Garg <sumit.garg@linaro.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
Sebastian Duda <sebastian.duda@fau.de>,
Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
Date: Wed, 04 Mar 2020 16:12:58 +0000 [thread overview]
Message-ID: <1583338378.3284.7.camel@linux.ibm.com> (raw)
In-Reply-To: <20200304160359.16809-1-lukas.bulwahn@gmail.com>
On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
> warning: no file matches F: security/keys/trusted.c
> warning: no file matches F: include/keys/trusted.h
>
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Sumit, please ack.
> Jarkko, please pick this patch.
>
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c755e03ddee..cf389058ca76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9276,8 +9276,8 @@ L: keyrings@vger.kernel.org
> S: Supported
> F: Documentation/security/keys/trusted-encrypted.rst
> F: include/keys/trusted-type.h
> -F: security/keys/trusted.c
> -F: include/keys/trusted.h
> +F: include/keys/trusted_tpm.h
> +F: security/keys/trusted-keys/trusted_tpm1.c
Everything under trusted-keys is part of the subsystem, so this should
be a glob not a single file.
James
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <jejb@linux.ibm.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Sumit Garg <sumit.garg@linaro.org>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
Sebastian Duda <sebastian.duda@fau.de>,
Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
Date: Wed, 04 Mar 2020 08:12:58 -0800 [thread overview]
Message-ID: <1583338378.3284.7.camel@linux.ibm.com> (raw)
In-Reply-To: <20200304160359.16809-1-lukas.bulwahn@gmail.com>
On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
>
> Since then, ./scripts/get_maintainer.pl --self-test complains:
>
> warning: no file matches F: security/keys/trusted.c
> warning: no file matches F: include/keys/trusted.h
>
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
>
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Sumit, please ack.
> Jarkko, please pick this patch.
>
> MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c755e03ddee..cf389058ca76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9276,8 +9276,8 @@ L: keyrings@vger.kernel.org
> S: Supported
> F: Documentation/security/keys/trusted-encrypted.rst
> F: include/keys/trusted-type.h
> -F: security/keys/trusted.c
> -F: include/keys/trusted.h
> +F: include/keys/trusted_tpm.h
> +F: security/keys/trusted-keys/trusted_tpm1.c
Everything under trusted-keys is part of the subsystem, so this should
be a glob not a single file.
James
next prev parent reply other threads:[~2020-03-04 16:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 16:03 [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
2020-03-04 16:03 ` Lukas Bulwahn
2020-03-04 16:12 ` James Bottomley [this message]
2020-03-04 16:12 ` James Bottomley
2020-03-04 21:15 ` Lukas Bulwahn
2020-03-04 21:15 ` Lukas Bulwahn
2020-03-05 11:25 ` Jarkko Sakkinen
2020-03-05 11:25 ` Jarkko Sakkinen
2020-03-05 20:34 ` Lukas Bulwahn
2020-03-05 20:34 ` Lukas Bulwahn
2020-03-05 20:46 ` James Bottomley
2020-03-05 20:46 ` James Bottomley
2020-03-05 21:10 ` Lukas Bulwahn
2020-03-05 21:10 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583338378.3284.7.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=sebastian.duda@fau.de \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.