From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings
Date: Thu, 17 Mar 2016 09:00:14 +0200 [thread overview]
Message-ID: <1583818.aXla9CoXzO@avalon> (raw)
In-Reply-To: <1458062592-27981-2-git-send-email-appanad@xilinx.com>
Hello,
On Tuesday 15 March 2016 22:53:06 Kedareswara rao Appana wrote:
> This patch fixes the below checkpatch.pl warnings.
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: Missing a blank line after declarations
> + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
>
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/dma/xilinx/xilinx_vdma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_vdma.c
> b/drivers/dma/xilinx/xilinx_vdma.c index 0ee0321..7ab6793 100644
> --- a/drivers/dma/xilinx/xilinx_vdma.c
> +++ b/drivers/dma/xilinx/xilinx_vdma.c
> @@ -569,8 +569,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan
> *chan) chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR));
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -595,8 +593,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan
> *chan)
>
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -829,6 +825,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void
> *data) * make sure not to write to other error bits to 1.
> */
> u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> +
> vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
> errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK);
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
Cc: dan.j.williams@intel.com, vinod.koul@intel.com,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
appanad@xilinx.com, moritz.fischer@ettus.com,
luis@debethencourt.com, anirudh@xilinx.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings
Date: Thu, 17 Mar 2016 09:00:14 +0200 [thread overview]
Message-ID: <1583818.aXla9CoXzO@avalon> (raw)
In-Reply-To: <1458062592-27981-2-git-send-email-appanad@xilinx.com>
Hello,
On Tuesday 15 March 2016 22:53:06 Kedareswara rao Appana wrote:
> This patch fixes the below checkpatch.pl warnings.
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: void function return statements are not generally useful
> + return;
> +}
>
> WARNING: Missing a blank line after declarations
> + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
>
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/dma/xilinx/xilinx_vdma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_vdma.c
> b/drivers/dma/xilinx/xilinx_vdma.c index 0ee0321..7ab6793 100644
> --- a/drivers/dma/xilinx/xilinx_vdma.c
> +++ b/drivers/dma/xilinx/xilinx_vdma.c
> @@ -569,8 +569,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan
> *chan) chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR));
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -595,8 +593,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan
> *chan)
>
> chan->err = true;
> }
> -
> - return;
> }
>
> /**
> @@ -829,6 +825,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void
> *data) * make sure not to write to other error bits to 1.
> */
> u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK;
> +
> vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR,
> errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-03-17 7:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 17:23 [PATCH 0/7] dmaengine: xilinx_vdma: AXI DMA's enhancments Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-15 17:23 ` [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-15 17:50 ` Moritz Fischer
2016-03-15 17:50 ` Moritz Fischer
2016-03-17 7:00 ` Laurent Pinchart [this message]
2016-03-17 7:00 ` Laurent Pinchart
2016-03-15 17:23 ` [PATCH 2/7] dmaengine: xilinx_vdma: Add quirks support to differentiate differnet IP cores Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-16 3:13 ` Vinod Koul
2016-03-16 3:13 ` Vinod Koul
2016-03-16 6:12 ` Appana Durga Kedareswara Rao
2016-03-16 6:12 ` Appana Durga Kedareswara Rao
2016-03-17 7:19 ` Laurent Pinchart
2016-03-17 7:19 ` Laurent Pinchart
2016-03-18 12:43 ` Appana Durga Kedareswara Rao
2016-03-18 12:43 ` Appana Durga Kedareswara Rao
2016-03-15 17:23 ` [PATCH 3/7] dmaengine: xilinx_vdma: Add Support for Xilinx AXI Direct Memory Access Engine Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-17 8:05 ` Laurent Pinchart
2016-03-17 8:05 ` Laurent Pinchart
2016-03-18 12:43 ` Appana Durga Kedareswara Rao
2016-03-18 12:43 ` Appana Durga Kedareswara Rao
2016-03-15 17:23 ` [PATCH 4/7] " Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-16 3:17 ` Vinod Koul
2016-03-16 3:17 ` Vinod Koul
2016-03-16 6:19 ` Appana Durga Kedareswara Rao
2016-03-16 6:19 ` Appana Durga Kedareswara Rao
2016-03-15 17:23 ` [PATCH 5/7] dmaengine: xilinx_vdma: Remove unnecessary axi dma device-tree binding doc Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-16 1:34 ` Moritz Fischer
2016-03-16 1:34 ` Moritz Fischer
2016-03-16 6:08 ` Appana Durga Kedareswara Rao
2016-03-16 6:08 ` Appana Durga Kedareswara Rao
2016-03-15 17:23 ` [PATCH 6/7] dmaengine: xilinx_vdma: Add Support for Xilinx AXI Central Direct Memory Access Engine Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-15 17:23 ` [PATCH 7/7] " Kedareswara rao Appana
2016-03-15 17:23 ` Kedareswara rao Appana
2016-03-16 1:29 ` [PATCH 0/7] dmaengine: xilinx_vdma: AXI DMA's enhancments Moritz Fischer
2016-03-16 1:29 ` Moritz Fischer
2016-03-16 3:11 ` Vinod Koul
2016-03-16 3:11 ` Vinod Koul
2016-03-16 6:13 ` Appana Durga Kedareswara Rao
2016-03-16 6:13 ` Appana Durga Kedareswara Rao
2016-03-16 6:06 ` Appana Durga Kedareswara Rao
2016-03-16 6:06 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1583818.aXla9CoXzO@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.