From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
PDL-MPT-FUSIONLINUX <MPT-FusionLinux.pdl@broadcom.com>,
manvanth <manvanth@linux.vnet.ibm.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
jcmvbkbc@gmail.com, iommu@lists.linux-foundation.org,
linux-next <linux-next@vger.kernel.org>,
Oliver <oohall@gmail.com>,
"aneesh.kumar" <aneesh.kumar@linux.vnet.ibm.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [linux-next/mainline][bisected 3acac06][ppc] Oops when unloading mpt3sas driver
Date: Fri, 20 Mar 2020 15:29:42 +0530 [thread overview]
Message-ID: <1584698382.4128.2.camel@abdul> (raw)
In-Reply-To: <CAK=zhgpWCz0+xpSGymbQEAbysH_rQf=s8iQ1gn4KwysP3c1Gcw@mail.gmail.com>
On Tue, 2020-02-25 at 12:23 +0530, Sreekanth Reddy wrote:
> On Tue, Feb 25, 2020 at 11:51 AM Abdul Haleem
> <abdhalee@linux.vnet.ibm.com> wrote:
> >
> > On Fri, 2020-01-17 at 18:21 +0530, Abdul Haleem wrote:
> > > On Thu, 2020-01-16 at 09:44 -0800, Christoph Hellwig wrote:
> > > > Hi Abdul,
> > > >
> > > > I think the problem is that mpt3sas has some convoluted logic to do
> > > > some DMA allocations with a 32-bit coherent mask, and then switches
> > > > to a 63 or 64 bit mask, which is not supported by the DMA API.
> > > >
> > > > Can you try the patch below?
> > >
> > > Thank you Christoph, with the given patch applied the bug is not seen.
> > >
> > > rmmod of mpt3sas driver is successful, no kernel Oops
> > >
> > > Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> >
> > Hi Christoph,
> >
> > I see the patch is under discussion, will this be merged upstream any
> > time soon ? as boot is broken on our machines with out your patch.
> >
>
> Hi Abdul,
>
> We have posted a new set of patches to fix this issue. This patch set
> won't change the DMA Mask on the fly and also won't hardcode the DMA
> mask to 32 bit.
>
> [PATCH 0/5] mpt3sas: Fix changing coherent mask after allocation.
>
> This patchset will have below patches, Please review and try with this
> patch set.
>
> Suganath Prabu S (5):
> mpt3sas: Don't change the dma coherent mask after allocations
> mpt3sas: Rename function name is_MSB_are_same
> mpt3sas: Code Refactoring.
> mpt3sas: Handle RDPQ DMA allocation in same 4g region
> mpt3sas: Update version to 33.101.00.00
Hi Suganath,
The above patch fixes the issue, driver is loading and unloading with no
kernel oops.
Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
sachinp <sachinp@linux.vnet.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
jcmvbkbc@gmail.com, linux-next <linux-next@vger.kernel.org>,
Oliver <oohall@gmail.com>,
"aneesh.kumar" <aneesh.kumar@linux.vnet.ibm.com>,
Brian King <brking@linux.vnet.ibm.com>,
manvanth <manvanth@linux.vnet.ibm.com>,
iommu@lists.linux-foundation.org,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
PDL-MPT-FUSIONLINUX <MPT-FusionLinux.pdl@broadcom.com>
Subject: Re: [linux-next/mainline][bisected 3acac06][ppc] Oops when unloading mpt3sas driver
Date: Fri, 20 Mar 2020 15:29:42 +0530 [thread overview]
Message-ID: <1584698382.4128.2.camel@abdul> (raw)
In-Reply-To: <CAK=zhgpWCz0+xpSGymbQEAbysH_rQf=s8iQ1gn4KwysP3c1Gcw@mail.gmail.com>
On Tue, 2020-02-25 at 12:23 +0530, Sreekanth Reddy wrote:
> On Tue, Feb 25, 2020 at 11:51 AM Abdul Haleem
> <abdhalee@linux.vnet.ibm.com> wrote:
> >
> > On Fri, 2020-01-17 at 18:21 +0530, Abdul Haleem wrote:
> > > On Thu, 2020-01-16 at 09:44 -0800, Christoph Hellwig wrote:
> > > > Hi Abdul,
> > > >
> > > > I think the problem is that mpt3sas has some convoluted logic to do
> > > > some DMA allocations with a 32-bit coherent mask, and then switches
> > > > to a 63 or 64 bit mask, which is not supported by the DMA API.
> > > >
> > > > Can you try the patch below?
> > >
> > > Thank you Christoph, with the given patch applied the bug is not seen.
> > >
> > > rmmod of mpt3sas driver is successful, no kernel Oops
> > >
> > > Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> >
> > Hi Christoph,
> >
> > I see the patch is under discussion, will this be merged upstream any
> > time soon ? as boot is broken on our machines with out your patch.
> >
>
> Hi Abdul,
>
> We have posted a new set of patches to fix this issue. This patch set
> won't change the DMA Mask on the fly and also won't hardcode the DMA
> mask to 32 bit.
>
> [PATCH 0/5] mpt3sas: Fix changing coherent mask after allocation.
>
> This patchset will have below patches, Please review and try with this
> patch set.
>
> Suganath Prabu S (5):
> mpt3sas: Don't change the dma coherent mask after allocations
> mpt3sas: Rename function name is_MSB_are_same
> mpt3sas: Code Refactoring.
> mpt3sas: Handle RDPQ DMA allocation in same 4g region
> mpt3sas: Update version to 33.101.00.00
Hi Suganath,
The above patch fixes the issue, driver is loading and unloading with no
kernel oops.
Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
WARNING: multiple messages have this Message-ID (diff)
From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
PDL-MPT-FUSIONLINUX <MPT-FusionLinux.pdl@broadcom.com>,
manvanth <manvanth@linux.vnet.ibm.com>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Christoph Hellwig <hch@infradead.org>,
jcmvbkbc@gmail.com, iommu@lists.linux-foundation.org,
linux-next <linux-next@vger.kernel.org>,
Oliver <oohall@gmail.com>,
"aneesh.kumar" <aneesh.kumar@linux.vnet.ibm.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [linux-next/mainline][bisected 3acac06][ppc] Oops when unloading mpt3sas driver
Date: Fri, 20 Mar 2020 15:29:42 +0530 [thread overview]
Message-ID: <1584698382.4128.2.camel@abdul> (raw)
In-Reply-To: <CAK=zhgpWCz0+xpSGymbQEAbysH_rQf=s8iQ1gn4KwysP3c1Gcw@mail.gmail.com>
On Tue, 2020-02-25 at 12:23 +0530, Sreekanth Reddy wrote:
> On Tue, Feb 25, 2020 at 11:51 AM Abdul Haleem
> <abdhalee@linux.vnet.ibm.com> wrote:
> >
> > On Fri, 2020-01-17 at 18:21 +0530, Abdul Haleem wrote:
> > > On Thu, 2020-01-16 at 09:44 -0800, Christoph Hellwig wrote:
> > > > Hi Abdul,
> > > >
> > > > I think the problem is that mpt3sas has some convoluted logic to do
> > > > some DMA allocations with a 32-bit coherent mask, and then switches
> > > > to a 63 or 64 bit mask, which is not supported by the DMA API.
> > > >
> > > > Can you try the patch below?
> > >
> > > Thank you Christoph, with the given patch applied the bug is not seen.
> > >
> > > rmmod of mpt3sas driver is successful, no kernel Oops
> > >
> > > Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
> >
> > Hi Christoph,
> >
> > I see the patch is under discussion, will this be merged upstream any
> > time soon ? as boot is broken on our machines with out your patch.
> >
>
> Hi Abdul,
>
> We have posted a new set of patches to fix this issue. This patch set
> won't change the DMA Mask on the fly and also won't hardcode the DMA
> mask to 32 bit.
>
> [PATCH 0/5] mpt3sas: Fix changing coherent mask after allocation.
>
> This patchset will have below patches, Please review and try with this
> patch set.
>
> Suganath Prabu S (5):
> mpt3sas: Don't change the dma coherent mask after allocations
> mpt3sas: Rename function name is_MSB_are_same
> mpt3sas: Code Refactoring.
> mpt3sas: Handle RDPQ DMA allocation in same 4g region
> mpt3sas: Update version to 33.101.00.00
Hi Suganath,
The above patch fixes the issue, driver is loading and unloading with no
kernel oops.
Reported-and-tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
next prev parent reply other threads:[~2020-03-20 10:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 13:18 [linux-next/mainline][bisected 3acac06][ppc] Oops when unloading mpt3sas driver Abdul Haleem
2020-01-08 13:18 ` Abdul Haleem
2020-01-09 8:57 ` Abdul Haleem
2020-01-09 8:57 ` Abdul Haleem
2020-01-09 14:22 ` Christoph Hellwig
2020-01-09 14:22 ` Christoph Hellwig
2020-01-14 5:47 ` Abdul Haleem
2020-01-14 5:47 ` Abdul Haleem
2020-01-16 6:42 ` Michael Ellerman
2020-01-16 6:42 ` Michael Ellerman
2020-01-16 17:44 ` Christoph Hellwig
2020-01-16 17:44 ` Christoph Hellwig
2020-01-16 17:44 ` Christoph Hellwig
2020-01-17 12:51 ` Abdul Haleem
2020-01-17 12:51 ` Abdul Haleem
2020-01-17 12:51 ` Abdul Haleem
2020-02-25 6:20 ` Abdul Haleem
2020-02-25 6:20 ` Abdul Haleem
2020-02-25 6:20 ` Abdul Haleem
2020-02-25 6:53 ` Sreekanth Reddy via iommu
2020-02-25 6:53 ` Sreekanth Reddy
2020-02-25 6:53 ` Sreekanth Reddy
2020-03-20 9:59 ` Abdul Haleem [this message]
2020-03-20 9:59 ` Abdul Haleem
2020-03-20 9:59 ` Abdul Haleem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584698382.4128.2.camel@abdul \
--to=abdhalee@linux.vnet.ibm.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=chaitra.basappa@broadcom.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manvanth@linux.vnet.ibm.com \
--cc=oohall@gmail.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.