From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: renesas: Move CPG_AUDIO_CLK_I from board to soc files
Date: Fri, 30 Jun 2017 12:10:52 +0300 [thread overview]
Message-ID: <1587046.f3YfXb5MdT@avalon> (raw)
In-Reply-To: <1498810948-17910-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Friday 30 Jun 2017 10:22:28 Geert Uytterhoeven wrote:
> The definition of CPG_AUDIO_CLK_I is SoC-specific, not board-specific.
> Hence move it from the board-specific .dts files to the SoC-specific
> .dtsi files.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> I don't think it's worth adding Fixes tags.
>
> If you disagree, feel free to add:
>
> Fixes: 79e3b5cf035e4734 ("arm64: dts: renesas: Add support for Salvator-XS
> with R-Car H3 ES2.0") Fixes: fb5202dbebfd8fbf ("arm64: dts: r8a7795:
> h3ulcb: Add support for R-Car H3 ES2.0") Fixes: 0b03c32db03d63de ("arm64:
> dts: r8a7795: salvator-x: Add support for R-Car H3 ES2.0") Fixes:
> 253ed045a34d16d9 ("arm64: dts: renesas: Extract common ULCB board support")
> Fixes: d25e8ff0d5aaf8b1 ("arm64: dts: renesas: Extract common Salvator-X
> board support") ---
> arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 ++
> arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 ++
> 9 files changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts index
> 95fe207cb6a3fd2f..dd4f9b6a42546def 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795-es1.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts index
> b84c156ed6969947..3f7d5f51e42878cb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795-es1.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index
> 0426f41765f0bc68..27d4b1a4c4754732 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index
> 684fb3b9d154559e..17953070f38dff8d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts index
> de354957144b4822..6a7d1b22d0fecc9c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "salvator-xs.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> 5ec03641d9873f22..6b75d4b9ce7efa49 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -12,6 +12,8 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7795-sysc.h>
>
> +#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> +
> / {
> compatible = "renesas,r8a7795";
> #address-cells = <2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts index
> 38b58b7fca4bf0e9..1ff9dffae4618a5a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7796.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index
> db4f162d6bdd2c42..b35b15914771af86 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7796.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> cfb37d4bd65914b4..49b9f2c05f71cd05 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -12,6 +12,8 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7796-sysc.h>
>
> +#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> +
> / {
> compatible = "renesas,r8a7796";
> #address-cells = <2>;
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: renesas: Move CPG_AUDIO_CLK_I from board to soc files
Date: Fri, 30 Jun 2017 12:10:52 +0300 [thread overview]
Message-ID: <1587046.f3YfXb5MdT@avalon> (raw)
In-Reply-To: <1498810948-17910-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Friday 30 Jun 2017 10:22:28 Geert Uytterhoeven wrote:
> The definition of CPG_AUDIO_CLK_I is SoC-specific, not board-specific.
> Hence move it from the board-specific .dts files to the SoC-specific
> .dtsi files.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> I don't think it's worth adding Fixes tags.
>
> If you disagree, feel free to add:
>
> Fixes: 79e3b5cf035e4734 ("arm64: dts: renesas: Add support for Salvator-XS
> with R-Car H3 ES2.0") Fixes: fb5202dbebfd8fbf ("arm64: dts: r8a7795:
> h3ulcb: Add support for R-Car H3 ES2.0") Fixes: 0b03c32db03d63de ("arm64:
> dts: r8a7795: salvator-x: Add support for R-Car H3 ES2.0") Fixes:
> 253ed045a34d16d9 ("arm64: dts: renesas: Extract common ULCB board support")
> Fixes: d25e8ff0d5aaf8b1 ("arm64: dts: renesas: Extract common Salvator-X
> board support") ---
> arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 ++
> arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 2 --
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 ++
> 9 files changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts index
> 95fe207cb6a3fd2f..dd4f9b6a42546def 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795-es1.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts index
> b84c156ed6969947..3f7d5f51e42878cb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795-es1.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index
> 0426f41765f0bc68..27d4b1a4c4754732 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index
> 684fb3b9d154559e..17953070f38dff8d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts index
> de354957144b4822..6a7d1b22d0fecc9c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7795.dtsi"
> #include "salvator-xs.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> 5ec03641d9873f22..6b75d4b9ce7efa49 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -12,6 +12,8 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7795-sysc.h>
>
> +#define CPG_AUDIO_CLK_I R8A7795_CLK_S0D4
> +
> / {
> compatible = "renesas,r8a7795";
> #address-cells = <2>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts index
> 38b58b7fca4bf0e9..1ff9dffae4618a5a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts
> @@ -9,8 +9,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7796.dtsi"
> #include "ulcb.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index
> db4f162d6bdd2c42..b35b15914771af86 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -8,8 +8,6 @@
> * kind, whether express or implied.
> */
>
> -#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> -
> /dts-v1/;
> #include "r8a7796.dtsi"
> #include "salvator-x.dtsi"
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index
> cfb37d4bd65914b4..49b9f2c05f71cd05 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -12,6 +12,8 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a7796-sysc.h>
>
> +#define CPG_AUDIO_CLK_I R8A7796_CLK_S0D4
> +
> / {
> compatible = "renesas,r8a7796";
> #address-cells = <2>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-06-30 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 8:22 [PATCH] arm64: dts: renesas: Move CPG_AUDIO_CLK_I from board to soc files Geert Uytterhoeven
2017-06-30 8:22 ` Geert Uytterhoeven
2017-06-30 9:10 ` Laurent Pinchart [this message]
2017-06-30 9:10 ` Laurent Pinchart
2017-06-30 11:51 ` Simon Horman
2017-06-30 11:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587046.f3YfXb5MdT@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.