From: Tomasz Figa <tomasz.figa@gmail.com>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Chris Ball <cjb@laptop.org>,
Michal Simek <michal.simek@xilinx.com>,
Grant Likely <grant.likely@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI
Date: Mon, 28 Oct 2013 22:16:49 +0100 [thread overview]
Message-ID: <1587218.cW45zK0ty2@flatron> (raw)
In-Reply-To: <1381864085-8806-1-git-send-email-soren.brinkmann@xilinx.com>
Hi Soren,
On Tuesday 15 of October 2013 12:08:04 Soren Brinkmann wrote:
> Add a driver for Arasan's SDHCI controller core.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++
> MAINTAINERS | 1 +
> drivers/mmc/host/Kconfig | 12 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-of-arasan.c | 224
> +++++++++++++++++++++ 5 files changed, 261 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt create mode
> 100644 drivers/mmc/host/sdhci-of-arasan.c
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt new file mode
> 100644
> index 000000000000..20f0fc25e270
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -0,0 +1,23 @@
> +Device Tree Bindings for the Arasan SDCHI Controller
> +
> + The bindings follow the mmc[1] and the clock bindings[2]. Only
> deviations are + documented here.
> +
> + [1] Documentation/devicetree/bindings/mmc/mmc.txt
> + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
> +
> +Required Properties:
According to the example below, the list of required properties lacks
interrupt-related properties.
Except this minor issue, the binding is trivial and looks fine to me.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI
Date: Mon, 28 Oct 2013 22:16:49 +0100 [thread overview]
Message-ID: <1587218.cW45zK0ty2@flatron> (raw)
In-Reply-To: <1381864085-8806-1-git-send-email-soren.brinkmann@xilinx.com>
Hi Soren,
On Tuesday 15 of October 2013 12:08:04 Soren Brinkmann wrote:
> Add a driver for Arasan's SDHCI controller core.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> .../devicetree/bindings/mmc/arasan,sdhci.txt | 23 +++
> MAINTAINERS | 1 +
> drivers/mmc/host/Kconfig | 12 ++
> drivers/mmc/host/Makefile | 1 +
> drivers/mmc/host/sdhci-of-arasan.c | 224
> +++++++++++++++++++++ 5 files changed, 261 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt create mode
> 100644 drivers/mmc/host/sdhci-of-arasan.c
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt new file mode
> 100644
> index 000000000000..20f0fc25e270
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -0,0 +1,23 @@
> +Device Tree Bindings for the Arasan SDCHI Controller
> +
> + The bindings follow the mmc[1] and the clock bindings[2]. Only
> deviations are + documented here.
> +
> + [1] Documentation/devicetree/bindings/mmc/mmc.txt
> + [2] Documentation/devicetree/bindings/clock/clock-bindings.txt
> +
> +Required Properties:
According to the example below, the list of required properties lacks
interrupt-related properties.
Except this minor issue, the binding is trivial and looks fine to me.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-28 21:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 19:08 [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI Soren Brinkmann
2013-10-15 19:08 ` Soren Brinkmann
2013-10-15 19:08 ` [PATCH 2/2] arm: dt: zynq: Add SDHCI nodes Soren Brinkmann
2013-10-15 19:08 ` Soren Brinkmann
2013-10-28 20:58 ` [PATCH 1/2] mmc: arasan: Add driver for Arasan SDHCI Sören Brinkmann
2013-10-28 20:58 ` Sören Brinkmann
2013-10-28 20:58 ` Sören Brinkmann
2013-10-28 21:16 ` Tomasz Figa [this message]
2013-10-28 21:16 ` Tomasz Figa
2013-10-28 21:47 ` Sören Brinkmann
2013-10-28 21:47 ` Sören Brinkmann
2013-10-28 21:47 ` Sören Brinkmann
2013-10-28 22:19 ` Tomasz Figa
2013-10-28 22:19 ` Tomasz Figa
2013-10-28 22:50 ` Sören Brinkmann
2013-10-28 22:50 ` Sören Brinkmann
2013-10-28 22:50 ` Sören Brinkmann
2013-10-28 23:20 ` Rob Herring
2013-10-28 23:20 ` Rob Herring
2013-10-29 0:15 ` Sören Brinkmann
2013-10-29 0:15 ` Sören Brinkmann
2013-10-29 0:15 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587218.cW45zK0ty2@flatron \
--to=tomasz.figa@gmail.com \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=soren.brinkmann@xilinx.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.