Re: [PATCH 4/5] dt-bindings: power: supply: rk817-charger: Add rockchip,gate-function-disable

From: "Heiko Stübner" <heiko@sntech.de>
To: linux-pm@vger.kernel.org, Chris Morgan <macroalpha82@gmail.com>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	maccraft123mc@gmail.com, zhangqing@rock-chips.com,
	zyw@rock-chips.com, sre@kernel.org, conor+dt@kernel.org,
	krzk+dt@kernel.org, robh@kernel.org, lee@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>,
	Zetarancio <zetarancio@users.noreply.github.com>
Subject: Re: [PATCH 4/5] dt-bindings: power: supply: rk817-charger: Add rockchip,gate-function-disable
Date: Mon, 26 Oct 2026 20:23:40 +0100	[thread overview]
Message-ID: <15875856.JCcGWNJJiE@diego> (raw)
In-Reply-To: <20261026174834.1652309-5-macroalpha82@gmail.com>

Hi Chris,

Am Montag, 26. Oktober 2026, 18:48:33 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add a boolean attribute for the rk817-charger to control whether or not
> the system power is shutdown in battery off mode. The BSP kernel sets
> this value unless a device-tree attribute is present, and this attribute
> is to replicate that behavior.

Devicetree is supposed to describe the hardware, so your description needs
to describe the per-board property this represents.

Just because it's in a vendor-BSP is generally not enough justification :-) .

This is especially true as you wrote in the cover-letter that no known
board actually needs this right now.

Heiko

> Fixes: a592aa3a2a8c ("dt-bindings: mfd: Add Rockchip rk817 battery charger support")
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Suggested-by: Zetarancio <zetarancio@users.noreply.github.com>
> ---
>  Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> index 2cb6d176a84c..4cf987fe763b 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
> @@ -148,6 +148,12 @@ properties:
>            Value in microamps of the sleep filter current for the charger.
>            Value is used by the driver to derive the sleep sample current.
>  
> +      rockchip,gate-function-disable:
> +        type: boolean
> +        description:
> +          Boolean value to prevent PMIC from turning off system voltage when
> +          battery voltage is shut down.
> +
>      required:
>        - monitored-battery
>        - rockchip,resistor-sense-micro-ohms
> @@ -381,6 +387,7 @@ examples:
>  
>              rk817_charger: charger {
>                  monitored-battery = <&battery>;
> +                rockchip,gate-function-disable;
>                  rockchip,resistor-sense-micro-ohms = <10000>;
>                  rockchip,sleep-enter-current-microamp = <300000>;
>                  rockchip,sleep-filter-current-microamp = <100000>;
> 