All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reuben Dowle <reuben.dowle@4rf.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"
Date: Mon, 19 Oct 2020 23:13:51 +0000	[thread overview]
Message-ID: <15879d1e49eb40de8859944e7ab7b7f4@4rf.com> (raw)
In-Reply-To: <3c989798-84a0-256b-e455-6ff2b5a9390f@gmail.com>


> The reverted change linked to some kernel documentation that requires 64-
> bit alignment. I agree with the alignment requirement.
> 
> Im my opinion, there are two things that need to be done:
> 
> First is to look at an ALIGNED address for the fdt. A summary inspection of
> board_fdt_blob_setup() tells us this is done via the "_end" linker symbol.

The linker script can only control padding of the executable, but won't affect the alignment of the fdt that can be appended to this later by mkimage.

> Second is to put things in the right place. For FIT, the code, as is, is correct,
> but this alignment is not guaranteed for legacy images. I think somebody
> mentioned changing the arguments to mkimage to achieve this.
> 
> I've tried to fix the first point by aligning the _end symbol (appendix A).
> Unfortunately, this is causing other build issues that I don't know how to deal
> with.
> 
> Alex
> 
> 
> APPENDIX A:
> 
> 
> -- a/arch/arm/cpu/u-boot.lds
> +++ b/arch/arm/cpu/u-boot.lds
> @@ -196,7 +196,6 @@ SECTIONS
>           * for FIT images.
>           * See common/spl/spl_fit.c: spl_fit_append_fdt
>           */
> +       . = ALIGN(8);
>          .end :
>          {
>                  *(.__end)

  reply	other threads:[~2020-10-19 23:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 21:40 [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" Marek Vasut
2020-10-19 21:50 ` Reuben Dowle
2020-10-19 21:59   ` Marek Vasut
2020-10-19 22:17     ` Reuben Dowle
2020-10-19 22:46       ` Marek Vasut
2020-10-19 22:45     ` Tom Rini
2020-10-19 22:54       ` Marek Vasut
2020-10-19 22:58         ` Tom Rini
2020-10-19 23:02           ` Marek Vasut
2020-10-19 23:09             ` Alex G.
2020-10-19 23:13               ` Reuben Dowle [this message]
2020-10-20  0:31                 ` Alex G.
2020-10-19 23:02         ` Reuben Dowle
2020-10-19 23:11           ` Marek Vasut
2020-10-20  0:27             ` Reuben Dowle
2020-10-20  9:05               ` Marek Vasut
2020-10-20 14:07                 ` Tom Rini
2020-10-20 14:29                   ` Marek Vasut
2020-10-20 14:32                     ` Tom Rini
2020-10-20 14:38                       ` Alex G.
2020-10-20 15:54                         ` Tom Rini
2020-10-20 17:01                           ` Alex G.
2020-10-20 18:10                             ` Tom Rini
2020-10-21 17:11                               ` Alex G.
2020-10-20 14:42                       ` Marek Vasut
2020-10-21 23:12 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15879d1e49eb40de8859944e7ab7b7f4@4rf.com \
    --to=reuben.dowle@4rf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.