From: Reuben Dowle <reuben.dowle@4rf.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data"
Date: Mon, 19 Oct 2020 23:02:54 +0000 [thread overview]
Message-ID: <68533372f458433ab51ffd76fb0d1176@4rf.com> (raw)
In-Reply-To: <4f9c0170-1c52-0f2d-c6f8-972ed082cd36@denx.de>
> The problem is that the previous alignment was 4 byte, now it is 8 byte and
> that breaks all the other assumptions. So, this patch should be reverted to fix
> the platforms which used to work (or use ALIGN(...4), which is the same as
> reverting it really).
What assumptions? Any code that assumes 4 byte alignment will also work on 8 byte alignment.
Reverting is not the same as assuming ALIGN(...4) if incoming data is not already aligned to 4 bytes (as was the case when I saw crashes).
>
> And likely the signed image which caused the breakage should be generated
> with mkimage -E / -B 8, which would insure the alignment, so then there is no
> need to change anything in the code itself.
Interesting. I had not noticed the -B parameter previously. I had originally fixed this issue on an older version of uboot that did not have that option, and later rebased the fix to newer uboot. I would need to do some testing to see if this would fix it as well.
next prev parent reply other threads:[~2020-10-19 23:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 21:40 [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" Marek Vasut
2020-10-19 21:50 ` Reuben Dowle
2020-10-19 21:59 ` Marek Vasut
2020-10-19 22:17 ` Reuben Dowle
2020-10-19 22:46 ` Marek Vasut
2020-10-19 22:45 ` Tom Rini
2020-10-19 22:54 ` Marek Vasut
2020-10-19 22:58 ` Tom Rini
2020-10-19 23:02 ` Marek Vasut
2020-10-19 23:09 ` Alex G.
2020-10-19 23:13 ` Reuben Dowle
2020-10-20 0:31 ` Alex G.
2020-10-19 23:02 ` Reuben Dowle [this message]
2020-10-19 23:11 ` Marek Vasut
2020-10-20 0:27 ` Reuben Dowle
2020-10-20 9:05 ` Marek Vasut
2020-10-20 14:07 ` Tom Rini
2020-10-20 14:29 ` Marek Vasut
2020-10-20 14:32 ` Tom Rini
2020-10-20 14:38 ` Alex G.
2020-10-20 15:54 ` Tom Rini
2020-10-20 17:01 ` Alex G.
2020-10-20 18:10 ` Tom Rini
2020-10-21 17:11 ` Alex G.
2020-10-20 14:42 ` Marek Vasut
2020-10-21 23:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68533372f458433ab51ffd76fb0d1176@4rf.com \
--to=reuben.dowle@4rf.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.