Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver - Mark-MC.Lee

From: Mark-MC.Lee <Mark-MC.Lee@mediatek.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: devicetree@vger.kernel.org, Felix Fietkau <nbd@openwrt.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	netdev@vger.kernel.org, Sean Wang <sean.wang@mediatek.com>,
	linux-kernel@vger.kernel.org,
	Fabien Parent <fparent@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	John Crispin <john@phrozen.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver
Date: Thu, 7 May 2020 17:46:11 +0800	[thread overview]
Message-ID: <1588844771.5921.27.camel@mtksdccf07> (raw)
In-Reply-To: <20200505140231.16600-7-brgl@bgdev.pl>

Hi Bartosz:
 I think the naming of this driver and its Kconfig option is too generic
that will confuse with current mediatek SoCs eth driver architecture(for
all mt7xxx SoCs). 
  Since mtk_eth_mac.c is not a common MAC part for all mediatek SoC but
only a specific eth driver for mt85xx, it will be more reasonable to
name it as mt85xx_eth.c and change NET_MEDIATEK_MAC to
NET_MEDIATEK_MT85XX. How do you think?

On Tue, 2020-05-05 at 16:02 +0200, Bartosz Golaszewski wrote:
> 
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> This adds the driver for the MediaTek Ethernet MAC used on the MT8*
> SoC
> family. For now we only support full-duplex.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  drivers/net/ethernet/mediatek/Kconfig       |    6 +
>  drivers/net/ethernet/mediatek/Makefile      |    1 +
>  drivers/net/ethernet/mediatek/mtk_eth_mac.c | 1476
> +++++++++++++++++++
>  3 files changed, 1483 insertions(+)
>  create mode 100644 drivers/net/ethernet/mediatek/mtk_eth_mac.c
> 
> diff --git a/drivers/net/ethernet/mediatek/Kconfig
> b/drivers/net/ethernet/mediatek/Kconfig
> index 5079b8090f16..5c3793076765 100644
> --- a/drivers/net/ethernet/mediatek/Kconfig
> +++ b/drivers/net/ethernet/mediatek/Kconfig
> @@ -14,4 +14,10 @@ config NET_MEDIATEK_SOC
>           This driver supports the gigabit ethernet MACs in the
>           MediaTek SoC family.
>  
> +config NET_MEDIATEK_MAC
How about rename to NET_MEDIATEK_MT85XX ?

> +       tristate "MediaTek Ethernet MAC support"
> +       select PHYLIB
> +       help
> +         This driver supports the ethernet IP on MediaTek MT85**
> SoCs.
> +
>  endif #NET_VENDOR_MEDIATEK
> diff --git a/drivers/net/ethernet/mediatek/Makefile
> b/drivers/net/ethernet/mediatek/Makefile
> index 3362fb7ef859..f7f5638943a0 100644
> --- a/drivers/net/ethernet/mediatek/Makefile
> +++ b/drivers/net/ethernet/mediatek/Makefile
> @@ -5,3 +5,4 @@
>  
>  obj-$(CONFIG_NET_MEDIATEK_SOC) += mtk_eth.o
>  mtk_eth-y := mtk_eth_soc.o mtk_sgmii.o mtk_eth_path.o
> +obj-$(CONFIG_NET_MEDIATEK_MAC) += mtk_eth_mac.o 
How about rename to mt85xx_eth.c?

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek