Fwd: Error in fs/reiser4/page_cache.c : PG_active not declared

Fwd: Error in fs/reiser4/page_cache.c : PG_active not declared

[Ashay Humane]

Hi,
I got the vanilla 2.6.7 kernel .. patched it to 2.6.8-rc2 then patched
it to 2.6.8-rc2-love2.

After the love patch, I get an error when compiling the kernel:

Undeclared variable PG_active in fs/reiser4/page_cache.c  Line 891

There are variables named PG_active_mapped and PG_active_unmapped in other .c
and .h files. But no PG_active .

Dosent look too bad .. but what should be done ?

Thanks
Ashay

--
<HAND>



-- 
<HAND>

Re: Fwd: Error in fs/reiser4/page_cache.c : PG_active not declared

[Maciejewski, Jake]

This sounds more like a love-sources problem than a reiser4 problem.
Post something at http://forums.gentoo.org/viewtopic.php?t=201053 or if
you still want help here, try to reproduce the problem with the latest
auto-snapshot patched on the -mm version it was diffed against, ideally
with no other patches.

I looked at fs/reiser4/page_cache.c and you should be able to avoid the
problematic code by disabling resier4 debug output, although I'm not
sure how or why it would be enabled.

On Sat, 2004-07-24 at 22:16, Ashay Humane wrote:
> Hi,
> I got the vanilla 2.6.7 kernel .. patched it to 2.6.8-rc2 then patched
> it to 2.6.8-rc2-love2.
> 
> After the love patch, I get an error when compiling the kernel:
> 
> Undeclared variable PG_active in fs/reiser4/page_cache.c  Line 891
> 
> There are variables named PG_active_mapped and PG_active_unmapped in other .c
> and .h files. But no PG_active .
> 
> Dosent look too bad .. but what should be done ?
> 
> Thanks
> Ashay
> 
> --
> <HAND>
-- 
Jake Maciejewski <maciejej@msoe.edu>

Re: Fwd: Error in fs/reiser4/page_cache.c : PG_active not declared

[Vladimir V. Saveliev]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

Hello

Ashay Humane wrote:
> Hi,
> I got the vanilla 2.6.7 kernel .. patched it to 2.6.8-rc2 then patched
> it to 2.6.8-rc2-love2.
> 
> After the love patch, I get an error when compiling the kernel:
> 
> Undeclared variable PG_active in fs/reiser4/page_cache.c  Line 891
> 
> There are variables named PG_active_mapped and PG_active_unmapped in other .c
> and .h files. But no PG_active .
> 
> Dosent look too bad .. but what should be done ?
> 

Please try attached patch

> Thanks
> Ashay
> 
> --
> <HAND>
> 
> 
> 


[-- Attachment #2: no-PG_active-bit.diff --]
[-- Type: text/plain, Size: 849 bytes --]

===== page_cache.c 1.304 vs edited =====
--- 1.304/page_cache.c	2004-06-25 12:36:13 +04:00
+++ edited/page_cache.c	2004-07-26 15:53:57 +04:00
@@ -881,14 +881,13 @@
 	}
 	printk("%s: page index: %lu mapping: %p count: %i private: %lx\n",
 	       prefix, page->index, page->mapping, page_count(page), page->private);
-	printk("\tflags: %s%s%s%s %s%s%s%s %s%s%s%s %s%s%s\n",
+	printk("\tflags: %s%s%s%s %s%s%s %s%s%s%s %s%s%s\n",
 	       page_flag_name(page, PG_locked),
 	       page_flag_name(page, PG_error),
 	       page_flag_name(page, PG_referenced),
 	       page_flag_name(page, PG_uptodate),
 	       page_flag_name(page, PG_dirty),
 	       page_flag_name(page, PG_lru),
-	       page_flag_name(page, PG_active),
 	       page_flag_name(page, PG_slab),
 	       page_flag_name(page, PG_highmem),
 	       page_flag_name(page, PG_checked),