From: Masami Hiramatsu <mhiramat@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: [PATCH 0/4] selftests, sysctl, lib: Fix prime_numbers and sysctl test to run
Date: Thu, 28 May 2020 23:51:54 +0900 [thread overview]
Message-ID: <159067751438.229397.6746886115540895104.stgit@devnote2> (raw)
Hi,
Recently, I found some tests were always skipped.
Here is a series of patches to fix those issues.
The prime_numbers test is skipped in some cases because
prime_numbers.ko is not always compiled.
Since the CONFIG_PRIME_NUMBERS is not independently
configurable item (it has no title and help), it is enabled
only if other configs (DRM_DEBUG_SELFTEST etc.) select it.
To fix this issue, I added a title and help for
CONFIG_PRIME_NUMBERS.
The sysctl test is skipped because
- selftests/sysctl/config requires CONFIG_TEST_SYSCTL=y. But
since lib/test_sysctl.c doesn't use module_init(), the
test_syscall is not listed under /sys/module/ and the
test script gives up.
- Even if we make CONFIG_TEST_SYSCTL=m, the test script checks
/sys/modules/test_sysctl before loading module and gives up.
- Ayway, since the test module introduces useless sysctl
interface to the kernel, it would better be a module.
This series includes fixes for above 3 points.
- Fix lib/test_sysctl.c to use module_init()
- Fix tools/testing/selftests/sysctl/sysctl.sh to try to load
test module if it is not loaded (nor embedded).
- Fix tools/testing/selftests/sysctl/config to require
CONFIG_TEST_SYSCTL=m, not y.
Thank you,
---
Masami Hiramatsu (4):
lib: Make prime number generator independently selectable
lib: Make test_sysctl initialized as module
selftests/sysctl: Fix to load test_sysctl module
selftests/sysctl: Make sysctl test driver as a module
lib/math/Kconfig | 7 ++++++-
lib/test_sysctl.c | 2 +-
tools/testing/selftests/sysctl/config | 2 +-
tools/testing/selftests/sysctl/sysctl.sh | 13 ++-----------
4 files changed, 10 insertions(+), 14 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2020-05-28 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:51 Masami Hiramatsu [this message]
2020-05-28 14:52 ` [PATCH 1/4] lib: Make prime number generator independently selectable Masami Hiramatsu
2020-05-29 5:56 ` Kees Cook
2020-05-29 13:55 ` Masami Hiramatsu
2020-06-01 13:15 ` Luis Chamberlain
2020-05-28 14:52 ` [PATCH 2/4] lib: Make test_sysctl initialized as module Masami Hiramatsu
2020-05-29 5:52 ` Kees Cook
2020-06-01 13:14 ` Luis Chamberlain
2020-05-28 14:52 ` [PATCH 3/4] selftests/sysctl: Fix to load test_sysctl module Masami Hiramatsu
2020-05-29 5:57 ` Kees Cook
2020-06-01 13:15 ` Luis Chamberlain
2020-05-28 14:52 ` [PATCH 4/4] selftests/sysctl: Make sysctl test driver as a module Masami Hiramatsu
2020-05-29 5:57 ` Kees Cook
2020-06-01 13:15 ` Luis Chamberlain
2020-05-29 14:14 ` [PATCH 0/4] selftests, sysctl, lib: Fix prime_numbers and sysctl test to run Shuah Khan
2020-05-29 14:39 ` Masami Hiramatsu
2020-06-02 16:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159067751438.229397.6746886115540895104.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mcgrof@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.