From: Luis Chamberlain <mcgrof@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH 3/4] selftests/sysctl: Fix to load test_sysctl module
Date: Mon, 1 Jun 2020 13:15:33 +0000 [thread overview]
Message-ID: <20200601131533.GI11244@42.do-not-panic.com> (raw)
In-Reply-To: <159067754657.229397.15961438722058766667.stgit@devnote2>
On Thu, May 28, 2020 at 11:52:26PM +0900, Masami Hiramatsu wrote:
> Fix to load test_sysctl.ko module correctly.
>
> sysctl.sh checks whether the test module is embedded (or loaded
> already) or not at first, and if not, it returns skip error
> instead of trying modprobe. Thus, there is no chance to load the
> test_sysctl test module.
>
> Instead, this removes that module embedded check and returns
> skip error only if it ensures that there is no embedded test
> module *and* no loadable test module.
>
> This also avoid referring config file since that is not
> installed.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
next prev parent reply other threads:[~2020-06-01 13:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:51 [PATCH 0/4] selftests, sysctl, lib: Fix prime_numbers and sysctl test to run Masami Hiramatsu
2020-05-28 14:52 ` [PATCH 1/4] lib: Make prime number generator independently selectable Masami Hiramatsu
2020-05-29 5:56 ` Kees Cook
2020-05-29 13:55 ` Masami Hiramatsu
2020-06-01 13:15 ` Luis Chamberlain
2020-05-28 14:52 ` [PATCH 2/4] lib: Make test_sysctl initialized as module Masami Hiramatsu
2020-05-29 5:52 ` Kees Cook
2020-06-01 13:14 ` Luis Chamberlain
2020-05-28 14:52 ` [PATCH 3/4] selftests/sysctl: Fix to load test_sysctl module Masami Hiramatsu
2020-05-29 5:57 ` Kees Cook
2020-06-01 13:15 ` Luis Chamberlain [this message]
2020-05-28 14:52 ` [PATCH 4/4] selftests/sysctl: Make sysctl test driver as a module Masami Hiramatsu
2020-05-29 5:57 ` Kees Cook
2020-06-01 13:15 ` Luis Chamberlain
2020-05-29 14:14 ` [PATCH 0/4] selftests, sysctl, lib: Fix prime_numbers and sysctl test to run Shuah Khan
2020-05-29 14:39 ` Masami Hiramatsu
2020-06-02 16:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601131533.GI11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=joonas.lahtinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.