From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: sh-pfc: rename confusing pinmux ops variable
Date: Wed, 03 Sep 2014 21:14:49 +0000 [thread overview]
Message-ID: <1591463.JEteqGINz8@avalon> (raw)
In-Reply-To: <1409745112-13652-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Wednesday 03 September 2014 13:51:52 Linus Walleij wrote:
> The vtable named *pinmux_ops in the affected files are not really
> about pin multiplexing, but a struct related to some PFC-specific
> operations, inclusing pin config (bias setting). Rename the variable
> so as to avoid confusions.
>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh7372.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c index ce9fb7aa8ba3..280a56f97786
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> @@ -2717,14 +2717,14 @@ static void r8a73a4_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a73a4_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a73a4_pfc_ops = {
> .get_bias = r8a73a4_pinmux_get_bias,
> .set_bias = r8a73a4_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a73a4_pinmux_info = {
> .name = "r8a73a4_pfc",
> - .ops = &r8a73a4_pinmux_ops,
> + .ops = &r8a73a4_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c index e4c1ef477053..b486e9d20cc2
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -3752,14 +3752,14 @@ static void r8a7740_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a7740_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a7740_pfc_ops = {
> .get_bias = r8a7740_pinmux_get_bias,
> .set_bias = r8a7740_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a7740_pinmux_info = {
> .name = "r8a7740_pfc",
> - .ops = &r8a7740_pinmux_ops,
> + .ops = &r8a7740_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN,
> PINMUX_INPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7372.c index d9158b3b2919..8211f66a2f68
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> @@ -2614,14 +2614,14 @@ static void sh7372_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations sh7372_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh7372_pfc_ops = {
> .get_bias = sh7372_pinmux_get_bias,
> .set_bias = sh7372_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info sh7372_pinmux_info = {
> .name = "sh7372_pfc",
> - .ops = &sh7372_pinmux_ops,
> + .ops = &sh7372_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c index 0bd8f4401b42..2dd8fd524a80
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> @@ -3856,7 +3856,7 @@ static int sh73a0_pinmux_soc_init(struct sh_pfc *pfc)
> return 0;
> }
>
> -static const struct sh_pfc_soc_operations sh73a0_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh73a0_pfc_ops = {
> .init = sh73a0_pinmux_soc_init,
> .get_bias = sh73a0_pinmux_get_bias,
> .set_bias = sh73a0_pinmux_set_bias,
> @@ -3864,7 +3864,7 @@ static const struct sh_pfc_soc_operations
> sh73a0_pinmux_ops = {
>
> const struct sh_pfc_soc_info sh73a0_pinmux_info = {
> .name = "sh73a0_pfc",
> - .ops = &sh73a0_pinmux_ops,
> + .ops = &sh73a0_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: sh-pfc: rename confusing pinmux ops variable
Date: Thu, 04 Sep 2014 00:14:49 +0300 [thread overview]
Message-ID: <1591463.JEteqGINz8@avalon> (raw)
In-Reply-To: <1409745112-13652-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Wednesday 03 September 2014 13:51:52 Linus Walleij wrote:
> The vtable named *pinmux_ops in the affected files are not really
> about pin multiplexing, but a struct related to some PFC-specific
> operations, inclusing pin config (bias setting). Rename the variable
> so as to avoid confusions.
>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh7372.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c index ce9fb7aa8ba3..280a56f97786
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> @@ -2717,14 +2717,14 @@ static void r8a73a4_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a73a4_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a73a4_pfc_ops = {
> .get_bias = r8a73a4_pinmux_get_bias,
> .set_bias = r8a73a4_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a73a4_pinmux_info = {
> .name = "r8a73a4_pfc",
> - .ops = &r8a73a4_pinmux_ops,
> + .ops = &r8a73a4_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c index e4c1ef477053..b486e9d20cc2
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -3752,14 +3752,14 @@ static void r8a7740_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a7740_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a7740_pfc_ops = {
> .get_bias = r8a7740_pinmux_get_bias,
> .set_bias = r8a7740_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a7740_pinmux_info = {
> .name = "r8a7740_pfc",
> - .ops = &r8a7740_pinmux_ops,
> + .ops = &r8a7740_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN,
> PINMUX_INPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7372.c index d9158b3b2919..8211f66a2f68
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> @@ -2614,14 +2614,14 @@ static void sh7372_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations sh7372_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh7372_pfc_ops = {
> .get_bias = sh7372_pinmux_get_bias,
> .set_bias = sh7372_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info sh7372_pinmux_info = {
> .name = "sh7372_pfc",
> - .ops = &sh7372_pinmux_ops,
> + .ops = &sh7372_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c index 0bd8f4401b42..2dd8fd524a80
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> @@ -3856,7 +3856,7 @@ static int sh73a0_pinmux_soc_init(struct sh_pfc *pfc)
> return 0;
> }
>
> -static const struct sh_pfc_soc_operations sh73a0_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh73a0_pfc_ops = {
> .init = sh73a0_pinmux_soc_init,
> .get_bias = sh73a0_pinmux_get_bias,
> .set_bias = sh73a0_pinmux_set_bias,
> @@ -3864,7 +3864,7 @@ static const struct sh_pfc_soc_operations
> sh73a0_pinmux_ops = {
>
> const struct sh_pfc_soc_info sh73a0_pinmux_info = {
> .name = "sh73a0_pfc",
> - .ops = &sh73a0_pinmux_ops,
> + .ops = &sh73a0_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: sh-pfc: rename confusing pinmux ops variable
Date: Thu, 04 Sep 2014 00:14:49 +0300 [thread overview]
Message-ID: <1591463.JEteqGINz8@avalon> (raw)
In-Reply-To: <1409745112-13652-1-git-send-email-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Wednesday 03 September 2014 13:51:52 Linus Walleij wrote:
> The vtable named *pinmux_ops in the affected files are not really
> about pin multiplexing, but a struct related to some PFC-specific
> operations, inclusing pin config (bias setting). Rename the variable
> so as to avoid confusions.
>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> ---
> drivers/pinctrl/sh-pfc/pfc-r8a73a4.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-r8a7740.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh7372.c | 4 ++--
> drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c index ce9fb7aa8ba3..280a56f97786
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a73a4.c
> @@ -2717,14 +2717,14 @@ static void r8a73a4_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a73a4_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a73a4_pfc_ops = {
> .get_bias = r8a73a4_pinmux_get_bias,
> .set_bias = r8a73a4_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a73a4_pinmux_info = {
> .name = "r8a73a4_pfc",
> - .ops = &r8a73a4_pinmux_ops,
> + .ops = &r8a73a4_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c index e4c1ef477053..b486e9d20cc2
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -3752,14 +3752,14 @@ static void r8a7740_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations r8a7740_pinmux_ops = {
> +static const struct sh_pfc_soc_operations r8a7740_pfc_ops = {
> .get_bias = r8a7740_pinmux_get_bias,
> .set_bias = r8a7740_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info r8a7740_pinmux_info = {
> .name = "r8a7740_pfc",
> - .ops = &r8a7740_pinmux_ops,
> + .ops = &r8a7740_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN,
> PINMUX_INPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> b/drivers/pinctrl/sh-pfc/pfc-sh7372.c index d9158b3b2919..8211f66a2f68
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh7372.c
> @@ -2614,14 +2614,14 @@ static void sh7372_pinmux_set_bias(struct sh_pfc
> *pfc, unsigned int pin, iowrite8(value, addr);
> }
>
> -static const struct sh_pfc_soc_operations sh7372_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh7372_pfc_ops = {
> .get_bias = sh7372_pinmux_get_bias,
> .set_bias = sh7372_pinmux_set_bias,
> };
>
> const struct sh_pfc_soc_info sh7372_pinmux_info = {
> .name = "sh7372_pfc",
> - .ops = &sh7372_pinmux_ops,
> + .ops = &sh7372_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c index 0bd8f4401b42..2dd8fd524a80
> 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c
> @@ -3856,7 +3856,7 @@ static int sh73a0_pinmux_soc_init(struct sh_pfc *pfc)
> return 0;
> }
>
> -static const struct sh_pfc_soc_operations sh73a0_pinmux_ops = {
> +static const struct sh_pfc_soc_operations sh73a0_pfc_ops = {
> .init = sh73a0_pinmux_soc_init,
> .get_bias = sh73a0_pinmux_get_bias,
> .set_bias = sh73a0_pinmux_set_bias,
> @@ -3864,7 +3864,7 @@ static const struct sh_pfc_soc_operations
> sh73a0_pinmux_ops = {
>
> const struct sh_pfc_soc_info sh73a0_pinmux_info = {
> .name = "sh73a0_pfc",
> - .ops = &sh73a0_pinmux_ops,
> + .ops = &sh73a0_pfc_ops,
>
> .input = { PINMUX_INPUT_BEGIN, PINMUX_INPUT_END },
> .output = { PINMUX_OUTPUT_BEGIN, PINMUX_OUTPUT_END },
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-09-03 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 11:51 [PATCH] pinctrl: sh-pfc: rename confusing pinmux ops variable Linus Walleij
2014-09-03 11:51 ` Linus Walleij
2014-09-03 11:51 ` Linus Walleij
2014-09-03 21:14 ` Laurent Pinchart [this message]
2014-09-03 21:14 ` Laurent Pinchart
2014-09-03 21:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591463.JEteqGINz8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.