From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Christoph Hellwig <hch@lst.de>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Clark <robdclark@gmail.com>, Heiko Stuebner <heiko@sntech.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Daniel Drake <drake@endlessm.com>,
jonathan.derrick@intel.com, linux-samsung-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Joerg Roedel <jroedel@suse.de>
Subject: AMD IOMMU + SME + amdgpu regression
Date: Thu, 11 Jun 2020 19:05:21 -0400 [thread overview]
Message-ID: <1591915710.rakbpzst8h.none@localhost> (raw)
In-Reply-To: 1591915710.rakbpzst8h.none.ref@localhost
Hi,
amdgpu + IOMMU + SME is now working for me on 5.7, yay! But, it is
broken on torvalds master, boo. On boot, depending on which exact commit
I test, it either hangs immediately (with built-in driver, before
starting initramfs), displays some errors then hangs, or spams the
screen with many amdgpu errors.
I bisected the black screen hang to:
commit dce8d6964ebdb333383bacf5e7ab8c27df151218
Author: Joerg Roedel <jroedel@suse.de>
Date: Wed Apr 29 15:36:53 2020 +0200
iommu/amd: Convert to probe/release_device() call-backs
Convert the AMD IOMMU Driver to use the probe_device() and
release_device() call-backs of iommu_ops, so that the iommu core code
does the group and sysfs setup.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20200429133712.31431-16-joro@8bytes.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Testing torvalds master (623f6dc593) with the containing merge
(98bdc74b36) plus the DMA mapping merge (4e94d08734) reverted allows
amdgpu + IOMMU + SME to once again work.
I think that nobody is really working on amdgpu + SME, but it would be a
shame if it was supported and then incidentally broken by a small
change.
I am using an ASRock B450 Pro4 with Ryzen 1600 and ASUS RX 480. I don't
understand this code at all, but let me know what I can do to
troubleshoot.
Thanks,
Alex.
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Christoph Hellwig <hch@lst.de>
Cc: Heiko Stuebner <heiko@sntech.de>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Drake <drake@endlessm.com>, Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Joerg Roedel <jroedel@suse.de>,
linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
virtualization@lists.linux-foundation.org,
jonathan.derrick@intel.com, David Woodhouse <dwmw2@infradead.org>,
Rob Clark <robdclark@gmail.com>, Kukjin Kim <kgene@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: AMD IOMMU + SME + amdgpu regression
Date: Thu, 11 Jun 2020 19:05:21 -0400 [thread overview]
Message-ID: <1591915710.rakbpzst8h.none@localhost> (raw)
In-Reply-To: 1591915710.rakbpzst8h.none.ref@localhost
Hi,
amdgpu + IOMMU + SME is now working for me on 5.7, yay! But, it is
broken on torvalds master, boo. On boot, depending on which exact commit
I test, it either hangs immediately (with built-in driver, before
starting initramfs), displays some errors then hangs, or spams the
screen with many amdgpu errors.
I bisected the black screen hang to:
commit dce8d6964ebdb333383bacf5e7ab8c27df151218
Author: Joerg Roedel <jroedel@suse.de>
Date: Wed Apr 29 15:36:53 2020 +0200
iommu/amd: Convert to probe/release_device() call-backs
Convert the AMD IOMMU Driver to use the probe_device() and
release_device() call-backs of iommu_ops, so that the iommu core code
does the group and sysfs setup.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20200429133712.31431-16-joro@8bytes.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Testing torvalds master (623f6dc593) with the containing merge
(98bdc74b36) plus the DMA mapping merge (4e94d08734) reverted allows
amdgpu + IOMMU + SME to once again work.
I think that nobody is really working on amdgpu + SME, but it would be a
shame if it was supported and then incidentally broken by a small
change.
I am using an ASRock B450 Pro4 with Ryzen 1600 and ASUS RX 480. I don't
understand this code at all, but let me know what I can do to
troubleshoot.
Thanks,
Alex.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Christoph Hellwig <hch@lst.de>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Clark <robdclark@gmail.com>, Heiko Stuebner <heiko@sntech.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Daniel Drake <drake@endlessm.com>,
jonathan.derrick@intel.com, linux-samsung-soc@vger.kernel.org,
linux-arm-msm@vger.kernel.orglinux
Subject: AMD IOMMU + SME + amdgpu regression
Date: Thu, 11 Jun 2020 19:05:21 -0400 [thread overview]
Message-ID: <1591915710.rakbpzst8h.none@localhost> (raw)
In-Reply-To: 1591915710.rakbpzst8h.none.ref@localhost
Hi,
amdgpu + IOMMU + SME is now working for me on 5.7, yay! But, it is
broken on torvalds master, boo. On boot, depending on which exact commit
I test, it either hangs immediately (with built-in driver, before
starting initramfs), displays some errors then hangs, or spams the
screen with many amdgpu errors.
I bisected the black screen hang to:
commit dce8d6964ebdb333383bacf5e7ab8c27df151218
Author: Joerg Roedel <jroedel@suse.de>
Date: Wed Apr 29 15:36:53 2020 +0200
iommu/amd: Convert to probe/release_device() call-backs
Convert the AMD IOMMU Driver to use the probe_device() and
release_device() call-backs of iommu_ops, so that the iommu core code
does the group and sysfs setup.
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Link: https://lore.kernel.org/r/20200429133712.31431-16-joro@8bytes.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Testing torvalds master (623f6dc593) with the containing merge
(98bdc74b36) plus the DMA mapping merge (4e94d08734) reverted allows
amdgpu + IOMMU + SME to once again work.
I think that nobody is really working on amdgpu + SME, but it would be a
shame if it was supported and then incidentally broken by a small
change.
I am using an ASRock B450 Pro4 with Ryzen 1600 and ASUS RX 480. I don't
understand this code at all, but let me know what I can do to
troubleshoot.
Thanks,
Alex.
next parent reply other threads:[~2020-06-11 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1591915710.rakbpzst8h.none.ref@localhost>
2020-06-11 23:05 ` Alex Xu (Hello71) [this message]
2020-06-11 23:05 ` AMD IOMMU + SME + amdgpu regression Alex Xu (Hello71)
2020-06-11 23:05 ` Alex Xu (Hello71)
2020-06-22 10:02 ` Joerg Roedel
2020-06-22 10:02 ` Joerg Roedel
2020-06-22 15:30 ` Alex Xu (Hello71)
2020-06-22 15:30 ` Alex Xu (Hello71)
2020-07-15 9:17 ` Joerg Roedel
2020-07-15 9:17 ` Joerg Roedel
2020-07-15 9:17 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591915710.rakbpzst8h.none@localhost \
--to=alex_y_xu@yahoo.ca \
--cc=agross@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=drake@endlessm.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=hch@lst.de \
--cc=heiko@sntech.de \
--cc=jean-philippe@linaro.org \
--cc=jonathan.derrick@intel.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=rientjes@google.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.