Missing linker flags when statically linking

Missing linker flags when statically linking

[Laurent Bigonville]

Hello,

Apparently the audit.pc file is missing flags to allow libaudit to be 
statically linked (see [0]).

Adding something like "Requires.private: libcap-ng" should fix the problem.

Regards,

Laurent Bigonville

[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829500

Re: Missing linker flags when statically linking

[Steve Grubb]

Hello,

On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
> Apparently the audit.pc file is missing flags to allow libaudit to be
> statically linked (see [0]).
> 
> Adding something like "Requires.private: libcap-ng" should fix the problem.

OK. Fixed. There will be a new audit package release in a little while that 
has this fixed.

-Steve

Re: Missing linker flags when statically linking

[Laurent Bigonville]

Le 05/07/16 à 14:15, Steve Grubb a écrit :
> Hello,
>
> On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
>> Apparently the audit.pc file is missing flags to allow libaudit to be
>> statically linked (see [0]).
>>
>> Adding something like "Requires.private: libcap-ng" should fix the problem.
> OK. Fixed. There will be a new audit package release in a little while that
> has this fixed.
Apparently the fix is not 100% correct:

The "Libs.private" field should be _after_ the Libs one in the .pc file, 
otherwise the ordering of the libraries is not OK during liking:

-lcap-ng -laudit

it should be: -laudit -lcap-ng instead.


Also any reasons you are using Libs.private instead of Package.private?

Re: Missing linker flags when statically linking

[Steve Grubb]

On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
> Le 05/07/16 à 14:15, Steve Grubb a écrit :
> > Hello,
> > 
> > On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
> >> Apparently the audit.pc file is missing flags to allow libaudit to be
> >> statically linked (see [0]).
> >> 
> >> Adding something like "Requires.private: libcap-ng" should fix the
> >> problem.
> > 
> > OK. Fixed. There will be a new audit package release in a little while
> > that
> > has this fixed.
> 
> Apparently the fix is not 100% correct:
> 
> The "Libs.private" field should be _after_ the Libs one in the .pc file,
> otherwise the ordering of the libraries is not OK during liking:
> 
> -lcap-ng -laudit
> 
> it should be: -laudit -lcap-ng instead.

OK, I switched the order.


> Also any reasons you are using Libs.private instead of Package.private?

Libs.private is used to add flags for static linking. The dynamic linker 
shouldn't need a hint since libaudit its already linked to libcap-ng.

Also, anyone packaging up audit 2.6.4 will want to include this patch:
https://fedorahosted.org/audit/changeset/1340

-Steve

Re: Missing linker flags when statically linking

[Laurent Bigonville]

Le 09/07/16 à 23:41, Steve Grubb a écrit :
> On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
>> Le 05/07/16 à 14:15, Steve Grubb a écrit :
>>> Hello,
>>>
>>> On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
>>>> Apparently the audit.pc file is missing flags to allow libaudit to be
>>>> statically linked (see [0]).
>>>>
>>>> Adding something like "Requires.private: libcap-ng" should fix the
>>>> problem.
>>> OK. Fixed. There will be a new audit package release in a little while
>>> that
>>> has this fixed.
>> Apparently the fix is not 100% correct:
>>
>> The "Libs.private" field should be _after_ the Libs one in the .pc file,
>> otherwise the ordering of the libraries is not OK during liking:
>>
>> -lcap-ng -laudit
>>
>> it should be: -laudit -lcap-ng instead.
> OK, I switched the order.

Thanks

>> Also any reasons you are using Libs.private instead of Package.private?
> Libs.private is used to add flags for static linking. The dynamic linker
> shouldn't need a hint since libaudit its already linked to libcap-ng.

I was talking about Package*.private* not package itself. 
Package.private is the equivalent to Libs.private but for libs that also 
have a .pc file

> Also, anyone packaging up audit 2.6.4 will want to include this patch:
> https://fedorahosted.org/audit/changeset/1340

Thanks, I'll update the pkg in debian soon

Re: Missing linker flags when statically linking

[Thomas Petazzoni]

Hello,

On Sun, 10 Jul 2016 10:45:13 +0200, Laurent Bigonville wrote:

> >> Also any reasons you are using Libs.private instead of Package.private?  
> > Libs.private is used to add flags for static linking. The dynamic linker
> > shouldn't need a hint since libaudit its already linked to libcap-ng.  
> 
> I was talking about Package*.private* not package itself. 
> Package.private is the equivalent to Libs.private but for libs that also 
> have a .pc file

Agreed. When possible, Package.private should be preferred over
Libs.private.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: Missing linker flags when statically linking

[Steve Grubb]

On Sunday, July 10, 2016 10:45:13 AM EDT Laurent Bigonville wrote:
> Le 09/07/16 à 23:41, Steve Grubb a écrit :
> > On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
> >> Apparently the fix is not 100% correct:
> >> 
> >> The "Libs.private" field should be _after_ the Libs one in the .pc file,
> >> otherwise the ordering of the libraries is not OK during liking:
> >> 
> >> -lcap-ng -laudit
> >> 
> >> it should be: -laudit -lcap-ng instead.
> > 
> > OK, I switched the order.
> 
> Thanks
> 
> >> Also any reasons you are using Libs.private instead of Package.private?
> > 
> > Libs.private is used to add flags for static linking. The dynamic linker
> > shouldn't need a hint since libaudit its already linked to libcap-ng.
> 
> I was talking about Package*.private* not package itself.
> Package.private is the equivalent to Libs.private but for libs that also
> have a .pc file

Do you mean Requires.private? (I don't see Package.private documented in the 
man page.) That takes a package name which is not available from the m4 macro 
that libcap-ng provides. I think what this means is that I should switch from 
using m4 to pkg-config which means reworking configure.ac and the Makefiles.am 
wherever libcap-ng is used. I'll look into this, but I think in the meantime 
what's in svn generally works. libcap-ng is most likley built with the same 
flags that audit is.

-Steve

Re: Missing linker flags when statically linking

[Laurent Bigonville]

Le 10/07/16 à 19:18, Steve Grubb a écrit :
> On Sunday, July 10, 2016 10:45:13 AM EDT Laurent Bigonville wrote:
>> Le 09/07/16 à 23:41, Steve Grubb a écrit :
>>> On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
>>>> Apparently the fix is not 100% correct:
>>>>
>>>> The "Libs.private" field should be _after_ the Libs one in the .pc file,
>>>> otherwise the ordering of the libraries is not OK during liking:
>>>>
>>>> -lcap-ng -laudit
>>>>
>>>> it should be: -laudit -lcap-ng instead.
>>> OK, I switched the order.
>> Thanks
>>
>>>> Also any reasons you are using Libs.private instead of Package.private?
>>> Libs.private is used to add flags for static linking. The dynamic linker
>>> shouldn't need a hint since libaudit its already linked to libcap-ng.
>> I was talking about Package*.private* not package itself.
>> Package.private is the equivalent to Libs.private but for libs that also
>> have a .pc file
> Do you mean Requires.private? (I don't see Package.private documented in the
> man page.) That takes a package name which is not available from the m4 macro
> that libcap-ng provides. I think what this means is that I should switch from
> using m4 to pkg-config which means reworking configure.ac and the Makefiles.am
> wherever libcap-ng is used. I'll look into this, but I think in the meantime
> what's in svn generally works. libcap-ng is most likley built with the same
> flags that audit is.

Yes I meant Requires.private.

The audit.pc file is used by 3rd party, so using Requires.private has no 
impact over audit buildsystem I think. I would say that the 2 can be 
changed independently.