From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Qii Wang <qii.wang@mediatek.com>
Cc: <wsa@the-dreams.de>, <qiangming.xia@mediatek.com>,
<devicetree@vger.kernel.org>, <srv_heupstream@mediatek.com>,
<leilk.liu@mediatek.com>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <linux-mediatek@lists.infradead.org>,
<linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits
Date: Thu, 23 Jul 2020 09:24:21 +0800 [thread overview]
Message-ID: <1595467461.7332.3.camel@mtksdaap41> (raw)
In-Reply-To: <1595421106-10017-3-git-send-email-qii.wang@mediatek.com>
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
> Replace 'support_33bits with 'dma_max_support' for DMA mask
> operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'.
This doesn't explain why we need this patch. How about:
Newer MTK chip support more than 8GB of dram. Replace support_33bits
with more general dma_max_support.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 37 +++++++++++++++++--------------------
> 1 file changed, 17 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index e6b984a..e475877 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -209,6 +209,7 @@ struct mtk_i2c_compatible {
> unsigned char dma_sync: 1;
> unsigned char ltiming_adjust: 1;
> unsigned char apdma_sync: 1;
> + unsigned char max_dma_support;
support_33bits is no longer used. Please remove it.
Joe.C
WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Qii Wang <qii.wang@mediatek.com>
Cc: qiangming.xia@mediatek.com, devicetree@vger.kernel.org,
srv_heupstream@mediatek.com, wsa@the-dreams.de,
leilk.liu@mediatek.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits
Date: Thu, 23 Jul 2020 09:24:21 +0800 [thread overview]
Message-ID: <1595467461.7332.3.camel@mtksdaap41> (raw)
In-Reply-To: <1595421106-10017-3-git-send-email-qii.wang@mediatek.com>
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
> Replace 'support_33bits with 'dma_max_support' for DMA mask
> operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'.
This doesn't explain why we need this patch. How about:
Newer MTK chip support more than 8GB of dram. Replace support_33bits
with more general dma_max_support.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 37 +++++++++++++++++--------------------
> 1 file changed, 17 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index e6b984a..e475877 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -209,6 +209,7 @@ struct mtk_i2c_compatible {
> unsigned char dma_sync: 1;
> unsigned char ltiming_adjust: 1;
> unsigned char apdma_sync: 1;
> + unsigned char max_dma_support;
support_33bits is no longer used. Please remove it.
Joe.C
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Qii Wang <qii.wang@mediatek.com>
Cc: qiangming.xia@mediatek.com, devicetree@vger.kernel.org,
srv_heupstream@mediatek.com, wsa@the-dreams.de,
leilk.liu@mediatek.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits
Date: Thu, 23 Jul 2020 09:24:21 +0800 [thread overview]
Message-ID: <1595467461.7332.3.camel@mtksdaap41> (raw)
In-Reply-To: <1595421106-10017-3-git-send-email-qii.wang@mediatek.com>
On Wed, 2020-07-22 at 20:31 +0800, Qii Wang wrote:
> Replace 'support_33bits with 'dma_max_support' for DMA mask
> operation, and replace 'mtk_i2c_set_4g_mode' with 'upper_32_bits'.
This doesn't explain why we need this patch. How about:
Newer MTK chip support more than 8GB of dram. Replace support_33bits
with more general dma_max_support.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 37 +++++++++++++++++--------------------
> 1 file changed, 17 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index e6b984a..e475877 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -209,6 +209,7 @@ struct mtk_i2c_compatible {
> unsigned char dma_sync: 1;
> unsigned char ltiming_adjust: 1;
> unsigned char apdma_sync: 1;
> + unsigned char max_dma_support;
support_33bits is no longer used. Please remove it.
Joe.C
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 1:24 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 12:31 [PATCH 0/4] add i2c support for mt8192 Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` [PATCH 1/4] i2c: mediatek: Add apdma sync in i2c driver Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 15:26 ` Matthias Brugger
2020-07-22 15:26 ` Matthias Brugger
2020-07-22 15:26 ` Matthias Brugger
2020-07-23 1:29 ` Yingjoe Chen
2020-07-23 1:29 ` Yingjoe Chen
2020-07-23 1:29 ` Yingjoe Chen
2020-07-23 6:01 ` Qii Wang
2020-07-23 6:01 ` Qii Wang
2020-07-23 6:01 ` Qii Wang
2020-07-22 12:31 ` [PATCH 2/4] i2c: mediatek: Support DMA mask range over 33-bits Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 15:38 ` Matthias Brugger
2020-07-22 15:38 ` Matthias Brugger
2020-07-22 15:38 ` Matthias Brugger
2020-07-23 5:47 ` Qii Wang
2020-07-23 5:47 ` Qii Wang
2020-07-23 5:47 ` Qii Wang
2020-07-23 1:24 ` Yingjoe Chen [this message]
2020-07-23 1:24 ` Yingjoe Chen
2020-07-23 1:24 ` Yingjoe Chen
2020-07-23 6:03 ` Qii Wang
2020-07-23 6:03 ` Qii Wang
2020-07-23 6:03 ` Qii Wang
2020-07-22 12:31 ` [PATCH 3/4] dt-bindings: i2c: update bindings for MT8192 SoC Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-23 21:18 ` Rob Herring
2020-07-23 21:18 ` Rob Herring
2020-07-23 21:18 ` Rob Herring
2020-07-22 12:31 ` [PATCH 4/4] i2c: mediatek: Add i2c compatible for MediaTek MT8192 Qii Wang
2020-07-22 12:31 ` Qii Wang
2020-07-22 12:31 ` Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595467461.7332.3.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=qiangming.xia@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.