From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it, Lachlan Sneff <t-josne@linux.microsoft.com>,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
balajib@linux.microsoft.com, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v4 2/2] IMA: Add test for kexec cmdline measurement
Date: Fri, 24 Jul 2020 12:06:54 -0400 [thread overview]
Message-ID: <1595606814.5211.251.camel@linux.ibm.com> (raw)
In-Reply-To: <20200724131845.GB24626@dell5510>
On Fri, 2020-07-24 at 15:18 +0200, Petr Vorel wrote:
>
> > Other than the policy "action" - measure/dont_measure,
> > audit/dont_audit, appraise/dont_appraise - being the first keyword,
> > the ordering of the policy options and flags is flexible. Most
> > policies do provide the "func" option immediately following the
> > "action". This would normally work.
> OK, is this correct?
> if ! grep '^measure.*func=KEXEC_CMDLINE' $IMA_POLICY >/dev/null; then
Yes, that works.
>
> @Mimi, @Lachlan: if you both ack my changes, I can fix the code before merging.
That's fine. Feel free to add my Reviewed-by.
Mimi
> If there are more changes needed and thus Lachlan plan new version, please use
> my patches from https://patchwork.ozlabs.org/project/ltp/list/?series=191990&state=*
> (download https://patchwork.ozlabs.org/series/191990/mbox/ and import it with "git am")
> or clone my github fork and use kexec.v3.fixes branch:
> https://github.com/pevik/ltp/tree/ima/kexec.v3.fixes).
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/2] IMA: Add test for kexec cmdline measurement
Date: Fri, 24 Jul 2020 12:06:54 -0400 [thread overview]
Message-ID: <1595606814.5211.251.camel@linux.ibm.com> (raw)
In-Reply-To: <20200724131845.GB24626@dell5510>
On Fri, 2020-07-24 at 15:18 +0200, Petr Vorel wrote:
>
> > Other than the policy "action" - measure/dont_measure,
> > audit/dont_audit, appraise/dont_appraise - being the first keyword,
> > the ordering of the policy options and flags is flexible. ?Most
> > policies do provide the "func" option immediately following the
> > "action". ?This would normally work.
> OK, is this correct?
> if ! grep '^measure.*func=KEXEC_CMDLINE' $IMA_POLICY >/dev/null; then
Yes, that works.
>
> @Mimi, @Lachlan: if you both ack my changes, I can fix the code before merging.
That's fine. Feel free to add my Reviewed-by.
Mimi
> If there are more changes needed and thus Lachlan plan new version, please use
> my patches from https://patchwork.ozlabs.org/project/ltp/list/?series=191990&state=*
> (download https://patchwork.ozlabs.org/series/191990/mbox/ and import it with "git am")
> or clone my github fork and use kexec.v3.fixes branch:
> https://github.com/pevik/ltp/tree/ima/kexec.v3.fixes).
next prev parent reply other threads:[~2020-07-24 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:00 [PATCH v4 1/2] IMA: Fix policy readability check Petr Vorel
2020-07-24 7:00 ` [LTP] " Petr Vorel
2020-07-24 7:00 ` [PATCH v4 2/2] IMA: Add test for kexec cmdline measurement Petr Vorel
2020-07-24 7:00 ` [LTP] " Petr Vorel
2020-07-24 12:01 ` Mimi Zohar
2020-07-24 12:01 ` [LTP] " Mimi Zohar
2020-07-24 13:18 ` Petr Vorel
2020-07-24 13:18 ` [LTP] " Petr Vorel
2020-07-24 16:06 ` Mimi Zohar [this message]
2020-07-24 16:06 ` Mimi Zohar
2020-07-24 16:19 ` Lachlan Sneff
2020-07-24 16:19 ` [LTP] " Lachlan Sneff
2020-07-24 20:15 ` Petr Vorel
2020-07-24 20:15 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595606814.5211.251.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=balajib@linux.microsoft.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=nramas@linux.microsoft.com \
--cc=pvorel@suse.cz \
--cc=t-josne@linux.microsoft.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.