From: Mimi Zohar <zohar@kernel.org>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Cc: Lachlan Sneff <t-josne@linux.microsoft.com>,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
balajib@linux.microsoft.com, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v6 4/4] IMA: Add test for kexec cmdline measurement
Date: Thu, 30 Jul 2020 15:58:51 -0400 [thread overview]
Message-ID: <1596139131.25003.14.camel@kernel.org> (raw)
In-Reply-To: <20200728001301.31121-1-pvorel@suse.cz>
On Tue, 2020-07-28 at 02:13 +0200, Petr Vorel wrote:
> From: Lachlan Sneff <t-josne@linux.microsoft.com>
>
> IMA policy can be set to measure the command line passed in the kexec
> system call. Add a testcase that verifies that the IMA subsystem
> correctly measure the cmdline specified during a kexec.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> Signed-off-by: Lachlan Sneff <t-josne@linux.microsoft.com>
> [ pvorel: improved setup, various LTP API cleanup ]
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Thanks, really nice.
Missing is a short comment explaining the reason for the multiple
tests.
> +test()
> +{
> + case $1 in
> + 1) kexec_test '--reuse-cmdline';;
> + 2) kexec_test '--append' 'foo';;
> + 3) kexec_test '--command-line' 'bar';;
> + esac
> +}
> +
> +tst_run
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@kernel.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v6 4/4] IMA: Add test for kexec cmdline measurement
Date: Thu, 30 Jul 2020 15:58:51 -0400 [thread overview]
Message-ID: <1596139131.25003.14.camel@kernel.org> (raw)
In-Reply-To: <20200728001301.31121-1-pvorel@suse.cz>
On Tue, 2020-07-28 at 02:13 +0200, Petr Vorel wrote:
> From: Lachlan Sneff <t-josne@linux.microsoft.com>
>
> IMA policy can be set to measure the command line passed in the kexec
> system call. Add a testcase that verifies that the IMA subsystem
> correctly measure the cmdline specified during a kexec.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> Signed-off-by: Lachlan Sneff <t-josne@linux.microsoft.com>
> [ pvorel: improved setup, various LTP API cleanup ]
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Thanks, really nice.
Missing is a short comment explaining the reason for the multiple
tests.
> +test()
> +{
> + case $1 in
> + 1) kexec_test '--reuse-cmdline';;
> + 2) kexec_test '--append' 'foo';;
> + 3) kexec_test '--command-line' 'bar';;
> + esac
> +}
> +
> +tst_run
next prev parent reply other threads:[~2020-07-30 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 0:13 [PATCH v6 4/4] IMA: Add test for kexec cmdline measurement Petr Vorel
2020-07-28 0:13 ` [LTP] " Petr Vorel
2020-07-28 1:06 ` Lachlan Sneff
2020-07-28 1:06 ` [LTP] " Lachlan Sneff
2020-07-30 19:58 ` Mimi Zohar [this message]
2020-07-30 19:58 ` Mimi Zohar
2020-07-31 5:34 ` Petr Vorel
2020-07-31 5:34 ` [LTP] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596139131.25003.14.camel@kernel.org \
--to=zohar@kernel.org \
--cc=balajib@linux.microsoft.com \
--cc=linux-integrity@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=nramas@linux.microsoft.com \
--cc=pvorel@suse.cz \
--cc=t-josne@linux.microsoft.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.