From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, yong.liang@mediatek.com,
srv_heupstream@mediatek.com, seiya.wang@mediatek.com,
linux-kernel@vger.kernel.org, fan.chen@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, Crystal Guo <crystal.guo@mediatek.com>,
stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [v2,3/6] dt-binding: reset-controller: ti: add generic-reset to compatible
Date: Wed, 5 Aug 2020 11:08:33 +0800 [thread overview]
Message-ID: <1596596913.31794.5.camel@mtksdaap41> (raw)
In-Reply-To: <053da16ed682cc016b0a66a834fb58d4d9410dc2.camel@pengutronix.de>
On Tue, 2020-08-04 at 10:15 +0200, Philipp Zabel wrote:
> On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> > The TI syscon reset controller provides a common reset management,
> > and should be suitable for other SOCs. Add compatible "generic-reset",
> > which denotes to use a common reset-controller driver.
> >
> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > index d551161ae785..e36d3631eab2 100644
> > --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > @@ -25,6 +25,7 @@ Required properties:
> > "ti,k2l-pscrst"
> > "ti,k2hk-pscrst"
> > "ti,syscon-reset"
> > + "generic-reset", "ti,syscon-reset"
> > - #reset-cells : Should be 1. Please see the reset consumer node below
> > for usage details
> > - ti,reset-bits : Contains the reset control register information
> > --
> > 2.18.0
>
> My understanding is that it would be better to add a mtk specific
> compatible instead of adding this "generic-reset", especially since we
> can't guarantee this binding will be considered generic in the future.
> I think there is nothing wrong with specifying
> compatible = "mtk,your-compatible", "ti,syscon-reset";
> in your device tree if your hardware is indeed compatible with the
> specified "ti,syscon-reset" binding, but I may be wrong: Therefore,
> please add devicetree@vger.kernel.org to Cc: for binding changes.
>
Hi Philipp,
This would work.
But having "ti" in mtk dts raise alarm for some people inside and
outside of MTK. It would save us some explanation if we could use a more
generic name.
Joe.C
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: devicetree@vger.kernel.org, yong.liang@mediatek.com,
srv_heupstream@mediatek.com, seiya.wang@mediatek.com,
linux-kernel@vger.kernel.org, fan.chen@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, Crystal Guo <crystal.guo@mediatek.com>,
stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [v2,3/6] dt-binding: reset-controller: ti: add generic-reset to compatible
Date: Wed, 5 Aug 2020 11:08:33 +0800 [thread overview]
Message-ID: <1596596913.31794.5.camel@mtksdaap41> (raw)
In-Reply-To: <053da16ed682cc016b0a66a834fb58d4d9410dc2.camel@pengutronix.de>
On Tue, 2020-08-04 at 10:15 +0200, Philipp Zabel wrote:
> On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> > The TI syscon reset controller provides a common reset management,
> > and should be suitable for other SOCs. Add compatible "generic-reset",
> > which denotes to use a common reset-controller driver.
> >
> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > index d551161ae785..e36d3631eab2 100644
> > --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > @@ -25,6 +25,7 @@ Required properties:
> > "ti,k2l-pscrst"
> > "ti,k2hk-pscrst"
> > "ti,syscon-reset"
> > + "generic-reset", "ti,syscon-reset"
> > - #reset-cells : Should be 1. Please see the reset consumer node below
> > for usage details
> > - ti,reset-bits : Contains the reset control register information
> > --
> > 2.18.0
>
> My understanding is that it would be better to add a mtk specific
> compatible instead of adding this "generic-reset", especially since we
> can't guarantee this binding will be considered generic in the future.
> I think there is nothing wrong with specifying
> compatible = "mtk,your-compatible", "ti,syscon-reset";
> in your device tree if your hardware is indeed compatible with the
> specified "ti,syscon-reset" binding, but I may be wrong: Therefore,
> please add devicetree@vger.kernel.org to Cc: for binding changes.
>
Hi Philipp,
This would work.
But having "ti" in mtk dts raise alarm for some people inside and
outside of MTK. It would save us some explanation if we could use a more
generic name.
Joe.C
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Crystal Guo <crystal.guo@mediatek.com>, <robh+dt@kernel.org>,
<matthias.bgg@gmail.com>, <srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <seiya.wang@mediatek.com>,
<stanley.chu@mediatek.com>, <fan.chen@mediatek.com>,
<yong.liang@mediatek.com>, <devicetree@vger.kernel.org>
Subject: Re: [v2,3/6] dt-binding: reset-controller: ti: add generic-reset to compatible
Date: Wed, 5 Aug 2020 11:08:33 +0800 [thread overview]
Message-ID: <1596596913.31794.5.camel@mtksdaap41> (raw)
In-Reply-To: <053da16ed682cc016b0a66a834fb58d4d9410dc2.camel@pengutronix.de>
On Tue, 2020-08-04 at 10:15 +0200, Philipp Zabel wrote:
> On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> > The TI syscon reset controller provides a common reset management,
> > and should be suitable for other SOCs. Add compatible "generic-reset",
> > which denotes to use a common reset-controller driver.
> >
> > Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > index d551161ae785..e36d3631eab2 100644
> > --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> > @@ -25,6 +25,7 @@ Required properties:
> > "ti,k2l-pscrst"
> > "ti,k2hk-pscrst"
> > "ti,syscon-reset"
> > + "generic-reset", "ti,syscon-reset"
> > - #reset-cells : Should be 1. Please see the reset consumer node below
> > for usage details
> > - ti,reset-bits : Contains the reset control register information
> > --
> > 2.18.0
>
> My understanding is that it would be better to add a mtk specific
> compatible instead of adding this "generic-reset", especially since we
> can't guarantee this binding will be considered generic in the future.
> I think there is nothing wrong with specifying
> compatible = "mtk,your-compatible", "ti,syscon-reset";
> in your device tree if your hardware is indeed compatible with the
> specified "ti,syscon-reset" binding, but I may be wrong: Therefore,
> please add devicetree@vger.kernel.org to Cc: for binding changes.
>
Hi Philipp,
This would work.
But having "ti" in mtk dts raise alarm for some people inside and
outside of MTK. It would save us some explanation if we could use a more
generic name.
Joe.C
next prev parent reply other threads:[~2020-08-05 3:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:15 [v2,0/6] introduce TI reset controller for MT8192 SoC Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` [v2, 1/6] dt-binding: reset-controller: ti: add assert-deassert-together property Crystal Guo
2020-08-03 6:15 ` [v2,1/6] " Crystal Guo
2020-08-03 6:15 ` [v2, 1/6] " Crystal Guo
2020-08-03 6:15 ` [v2,2/6] dt-binding: reset-controller: ti: add update-force property Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` [v2, 3/6] dt-binding: reset-controller: ti: add generic-reset to compatible Crystal Guo
2020-08-03 6:15 ` [v2,3/6] " Crystal Guo
2020-08-03 6:15 ` [v2, 3/6] " Crystal Guo
2020-08-04 8:15 ` [v2,3/6] " Philipp Zabel
2020-08-04 8:15 ` Philipp Zabel
2020-08-04 8:15 ` Philipp Zabel
2020-08-05 3:08 ` Yingjoe Chen [this message]
2020-08-05 3:08 ` Yingjoe Chen
2020-08-05 3:08 ` Yingjoe Chen
2020-08-03 6:15 ` [v2,4/6] reset-controller: ti: introduce a new reset handler Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-04 5:10 ` Stanley Chu
2020-08-04 5:10 ` Stanley Chu
2020-08-04 5:10 ` Stanley Chu
2020-08-04 7:16 ` Philipp Zabel
2020-08-04 7:16 ` Philipp Zabel
2020-08-04 7:16 ` Philipp Zabel
2020-08-03 6:15 ` [v2,5/6] reset-controller: ti: Introduce force-update method Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-04 4:15 ` Stanley Chu
2020-08-04 4:15 ` Stanley Chu
2020-08-04 4:15 ` Stanley Chu
2020-08-04 7:03 ` Philipp Zabel
2020-08-04 7:03 ` Philipp Zabel
2020-08-04 7:03 ` Philipp Zabel
2020-08-10 6:57 ` Crystal Guo
2020-08-10 6:57 ` Crystal Guo
2020-08-10 6:57 ` Crystal Guo
2020-09-02 23:05 ` Suman Anna
2020-09-02 23:05 ` Suman Anna
2020-09-02 23:05 ` Suman Anna
2020-08-05 3:14 ` Yingjoe Chen
2020-08-05 3:14 ` Yingjoe Chen
2020-08-05 3:14 ` Yingjoe Chen
2020-08-03 6:15 ` [v2,6/6] arm64: dts: mt8192: add infracfg_rst node Crystal Guo
2020-08-03 6:15 ` Crystal Guo
2020-08-03 6:15 ` Crystal Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596596913.31794.5.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=crystal.guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.