All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: Allen Pais <allen.cryptic@gmail.com>,
	martin.petersen@oracle.com, kashyap.desai@broadcom.com,
	sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com
Cc: keescook@chromium.org, linux-scsi@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	target-devel@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
	Allen Pais <allen.lkml@gmail.com>
Subject: Re: [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup()
Date: Mon, 17 Aug 2020 07:41:58 -0700	[thread overview]
Message-ID: <1597675318.4475.11.camel@linux.ibm.com> (raw)
In-Reply-To: <20200817085409.25268-1-allen.cryptic@gmail.com>

On Mon, 2020-08-17 at 14:24 +0530, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
> 
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts 
> all the scsi drivers to use the new tasklet_setup() API

I've got to say I agree with Jens, this was a silly obfuscation:

+#define from_tasklet(var, callback_tasklet, tasklet_fieldname) \
+       container_of(callback_tasklet, typeof(*var), tasklet_fieldname)

Just use container_of directly since we all understand what it does.

James


WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <jejb@linux.ibm.com>
To: Allen Pais <allen.cryptic@gmail.com>,
	martin.petersen@oracle.com, kashyap.desai@broadcom.com,
	sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com
Cc: keescook@chromium.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
	target-devel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	megaraidlinux.pdl@broadcom.com
Subject: Re: [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup()
Date: Mon, 17 Aug 2020 07:41:58 -0700	[thread overview]
Message-ID: <1597675318.4475.11.camel@linux.ibm.com> (raw)
In-Reply-To: <20200817085409.25268-1-allen.cryptic@gmail.com>

On Mon, 2020-08-17 at 14:24 +0530, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
> 
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts 
> all the scsi drivers to use the new tasklet_setup() API

I've got to say I agree with Jens, this was a silly obfuscation:

+#define from_tasklet(var, callback_tasklet, tasklet_fieldname) \
+       container_of(callback_tasklet, typeof(*var), tasklet_fieldname)

Just use container_of directly since we all understand what it does.

James


WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <jejb@linux.ibm.com>
To: Allen Pais <allen.cryptic@gmail.com>,
	martin.petersen@oracle.com, kashyap.desai@broadcom.com,
	sumit.saxena@broadcom.com,
	shivasharan.srikanteshwara@broadcom.com
Cc: keescook@chromium.org, linux-scsi@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	target-devel@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
	Allen Pais <allen.lkml@gmail.com>
Subject: Re: [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup()
Date: Mon, 17 Aug 2020 14:41:58 +0000	[thread overview]
Message-ID: <1597675318.4475.11.camel@linux.ibm.com> (raw)
In-Reply-To: <20200817085409.25268-1-allen.cryptic@gmail.com>

On Mon, 2020-08-17 at 14:24 +0530, Allen Pais wrote:
> From: Allen Pais <allen.lkml@gmail.com>
> 
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts 
> all the scsi drivers to use the new tasklet_setup() API

I've got to say I agree with Jens, this was a silly obfuscation:

+#define from_tasklet(var, callback_tasklet, tasklet_fieldname) \
+       container_of(callback_tasklet, typeof(*var), tasklet_fieldname)

Just use container_of directly since we all understand what it does.

James

  parent reply	other threads:[~2020-08-17 14:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  8:54 [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17  8:54 ` Allen Pais
2020-08-17  8:54 ` Allen Pais
2020-08-17  8:54 ` [PATCH 1/8] scsi: aic94xx: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 2/8] scsi: esas2r: " Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 3/8] scsi: ibmvscsi: " Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 4/8] scsi: isci: " Allen Pais
2020-08-17  8:55   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 5/8] scsi: megaraid: " Allen Pais
2020-08-17  8:55   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 6/8] scsi: mvsas: " Allen Pais
2020-08-17  8:55   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 7/8] scsi: pm8001: " Allen Pais
2020-08-17  8:55   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17  8:54 ` [PATCH 8/8] scsi: pmcraid: " Allen Pais
2020-08-17  8:55   ` Allen Pais
2020-08-17  8:54   ` Allen Pais
2020-08-17 14:41 ` James Bottomley [this message]
2020-08-17 14:41   ` [PATCH 0/8] scsi: convert tasklets to use new tasklet_setup() James Bottomley
2020-08-17 14:41   ` James Bottomley
2020-08-17 19:28   ` Kees Cook
2020-08-17 19:28     ` Kees Cook
2020-08-17 19:28     ` Kees Cook
2020-08-17 19:57     ` James Bottomley
2020-08-17 19:57       ` James Bottomley
2020-08-17 19:57       ` James Bottomley
2020-09-01 10:06       ` Allen
2020-09-01 10:18         ` Allen
2020-09-01 10:06         ` Allen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597675318.4475.11.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=allen.cryptic@gmail.com \
    --cc=allen.lkml@gmail.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.