From: CK Hu <ck.hu@mediatek.com>
To: Chih-En Hsu <chih-en.hsu@mediatek.com>
Cc: Andrew-CT.Chen@mediatek.com, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-kernel@lists.infradead.org, Michael.Mei@mediatek.com
Subject: Re: [PATCH] nvmem: mtk-efuse: Remove EFUSE register write support
Date: Wed, 26 Aug 2020 13:16:03 +0800 [thread overview]
Message-ID: <1598418963.20150.2.camel@mtksdaap41> (raw)
In-Reply-To: <20200826050145.24655-1-chih-en.hsu@mediatek.com>
Hi, Chih-En:
On Wed, 2020-08-26 at 13:01 +0800, Chih-En Hsu wrote:
> This patch is to remove function "mtk_reg_write" since
> Mediatek EFUSE hardware only supports read functionality
> for NVMEM consumers.
>
This is a bug-fix patch, so need a 'Fixes' tag. You could refer to [1].
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes
Regards,
CK.
> Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> ---
> drivers/nvmem/mtk-efuse.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> index 856d9c3fc38e..6a537d959f14 100644
> --- a/drivers/nvmem/mtk-efuse.c
> +++ b/drivers/nvmem/mtk-efuse.c
> @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> return 0;
> }
>
> -static int mtk_reg_write(void *context,
> - unsigned int reg, void *_val, size_t bytes)
> -{
> - struct mtk_efuse_priv *priv = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> -
> - while (words--)
> - writel(*val++, priv->base + reg + (i++ * 4));
> -
> - return 0;
> -}
> -
> static int mtk_efuse_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> econfig.stride = 4;
> econfig.word_size = 4;
> econfig.reg_read = mtk_reg_read;
> - econfig.reg_write = mtk_reg_write;
> econfig.size = resource_size(res);
> econfig.priv = priv;
> econfig.dev = dev;
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Chih-En Hsu <chih-en.hsu@mediatek.com>
Cc: Andrew-CT.Chen@mediatek.com, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-kernel@lists.infradead.org, Michael.Mei@mediatek.com
Subject: Re: [PATCH] nvmem: mtk-efuse: Remove EFUSE register write support
Date: Wed, 26 Aug 2020 13:16:03 +0800 [thread overview]
Message-ID: <1598418963.20150.2.camel@mtksdaap41> (raw)
In-Reply-To: <20200826050145.24655-1-chih-en.hsu@mediatek.com>
Hi, Chih-En:
On Wed, 2020-08-26 at 13:01 +0800, Chih-En Hsu wrote:
> This patch is to remove function "mtk_reg_write" since
> Mediatek EFUSE hardware only supports read functionality
> for NVMEM consumers.
>
This is a bug-fix patch, so need a 'Fixes' tag. You could refer to [1].
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes
Regards,
CK.
> Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> ---
> drivers/nvmem/mtk-efuse.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> index 856d9c3fc38e..6a537d959f14 100644
> --- a/drivers/nvmem/mtk-efuse.c
> +++ b/drivers/nvmem/mtk-efuse.c
> @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> return 0;
> }
>
> -static int mtk_reg_write(void *context,
> - unsigned int reg, void *_val, size_t bytes)
> -{
> - struct mtk_efuse_priv *priv = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> -
> - while (words--)
> - writel(*val++, priv->base + reg + (i++ * 4));
> -
> - return 0;
> -}
> -
> static int mtk_efuse_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> econfig.stride = 4;
> econfig.word_size = 4;
> econfig.reg_read = mtk_reg_read;
> - econfig.reg_write = mtk_reg_write;
> econfig.size = resource_size(res);
> econfig.priv = priv;
> econfig.dev = dev;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Chih-En Hsu <chih-en.hsu@mediatek.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<Andrew-CT.Chen@mediatek.com>, <srv_heupstream@mediatek.com>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<Michael.Mei@mediatek.com>
Subject: Re: [PATCH] nvmem: mtk-efuse: Remove EFUSE register write support
Date: Wed, 26 Aug 2020 13:16:03 +0800 [thread overview]
Message-ID: <1598418963.20150.2.camel@mtksdaap41> (raw)
In-Reply-To: <20200826050145.24655-1-chih-en.hsu@mediatek.com>
Hi, Chih-En:
On Wed, 2020-08-26 at 13:01 +0800, Chih-En Hsu wrote:
> This patch is to remove function "mtk_reg_write" since
> Mediatek EFUSE hardware only supports read functionality
> for NVMEM consumers.
>
This is a bug-fix patch, so need a 'Fixes' tag. You could refer to [1].
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes
Regards,
CK.
> Signed-off-by: Chih-En Hsu <chih-en.hsu@mediatek.com>
> ---
> drivers/nvmem/mtk-efuse.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
> index 856d9c3fc38e..6a537d959f14 100644
> --- a/drivers/nvmem/mtk-efuse.c
> +++ b/drivers/nvmem/mtk-efuse.c
> @@ -28,19 +28,6 @@ static int mtk_reg_read(void *context,
> return 0;
> }
>
> -static int mtk_reg_write(void *context,
> - unsigned int reg, void *_val, size_t bytes)
> -{
> - struct mtk_efuse_priv *priv = context;
> - u32 *val = _val;
> - int i = 0, words = bytes / 4;
> -
> - while (words--)
> - writel(*val++, priv->base + reg + (i++ * 4));
> -
> - return 0;
> -}
> -
> static int mtk_efuse_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -61,7 +48,6 @@ static int mtk_efuse_probe(struct platform_device *pdev)
> econfig.stride = 4;
> econfig.word_size = 4;
> econfig.reg_read = mtk_reg_read;
> - econfig.reg_write = mtk_reg_write;
> econfig.size = resource_size(res);
> econfig.priv = priv;
> econfig.dev = dev;
next prev parent reply other threads:[~2020-08-26 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 5:01 [PATCH] nvmem: mtk-efuse: Remove EFUSE register write support Chih-En Hsu
2020-08-26 5:01 ` Chih-En Hsu
2020-08-26 5:01 ` Chih-En Hsu
2020-08-26 5:16 ` CK Hu [this message]
2020-08-26 5:16 ` CK Hu
2020-08-26 5:16 ` CK Hu
2020-08-26 6:12 ` Chih-En Hsu
2020-08-26 6:12 ` Chih-En Hsu
2020-08-26 6:12 ` Chih-En Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598418963.20150.2.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=Andrew-CT.Chen@mediatek.com \
--cc=Michael.Mei@mediatek.com \
--cc=chih-en.hsu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.