From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hillf Danton <hdanton@sina.com>, Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] dma-direct: zero out DMA_ATTR_NO_KERNEL_MAPPING buf
Date: Fri, 04 Sep 2020 08:34:39 -0700 [thread overview]
Message-ID: <1599233679.5231.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200904152550.17964-1-hdanton@sina.com>
On Fri, 2020-09-04 at 23:25 +0800, Hillf Danton wrote:
> The DMA buffer allocated is always cleared in DMA core and this is
> making DMA_ATTR_NO_KERNEL_MAPPING non-special.
>
> Fixes: d98849aff879 ("dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING
> in common code")
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> ---
>
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -178,9 +178,17 @@ void *dma_direct_alloc_pages(struct devi
>
> if ((attrs & DMA_ATTR_NO_KERNEL_MAPPING) &&
> !force_dma_unencrypted(dev)) {
> + int i;
> +
> /* remove any dirty cache lines on the kernel alias
> */
> if (!PageHighMem(page))
> arch_dma_prep_coherent(page, size);
> +
> + for (i = 0; i < size/PAGE_SIZE; i++) {
> + ret = kmap_atomic(page + i);
> + memset(ret, 0, PAGE_SIZE);
> + kunmap_atomic(ret);
This is massively expensive on PARISC and likely other VIPT/VIVT
architectures. What's the reason for clearing it? This could also be
really inefficient even on PIPT architectures if the memory is device
remote.
If we really have to do this, it should likely be done in the arch or
driver hooks because there are potentially more efficient ways we can
do this knowing how the architecture behaves.
James
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hillf Danton <hdanton@sina.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] dma-direct: zero out DMA_ATTR_NO_KERNEL_MAPPING buf
Date: Fri, 04 Sep 2020 08:34:39 -0700 [thread overview]
Message-ID: <1599233679.5231.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200904152550.17964-1-hdanton@sina.com>
On Fri, 2020-09-04 at 23:25 +0800, Hillf Danton wrote:
> The DMA buffer allocated is always cleared in DMA core and this is
> making DMA_ATTR_NO_KERNEL_MAPPING non-special.
>
> Fixes: d98849aff879 ("dma-direct: handle DMA_ATTR_NO_KERNEL_MAPPING
> in common code")
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> ---
>
> --- a/kernel/dma/direct.c
> +++ b/kernel/dma/direct.c
> @@ -178,9 +178,17 @@ void *dma_direct_alloc_pages(struct devi
>
> if ((attrs & DMA_ATTR_NO_KERNEL_MAPPING) &&
> !force_dma_unencrypted(dev)) {
> + int i;
> +
> /* remove any dirty cache lines on the kernel alias
> */
> if (!PageHighMem(page))
> arch_dma_prep_coherent(page, size);
> +
> + for (i = 0; i < size/PAGE_SIZE; i++) {
> + ret = kmap_atomic(page + i);
> + memset(ret, 0, PAGE_SIZE);
> + kunmap_atomic(ret);
This is massively expensive on PARISC and likely other VIPT/VIVT
architectures. What's the reason for clearing it? This could also be
really inefficient even on PIPT architectures if the memory is device
remote.
If we really have to do this, it should likely be done in the arch or
driver hooks because there are potentially more efficient ways we can
do this knowing how the architecture behaves.
James
next prev parent reply other threads:[~2020-09-04 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:25 [PATCH] dma-direct: zero out DMA_ATTR_NO_KERNEL_MAPPING buf Hillf Danton
2020-09-04 15:34 ` James Bottomley [this message]
2020-09-04 15:34 ` James Bottomley
2020-09-05 7:35 ` Hillf Danton
2020-09-05 15:46 ` James Bottomley
2020-09-05 15:46 ` James Bottomley
2020-09-05 15:50 ` James Bottomley
2020-09-05 15:50 ` James Bottomley
2020-09-06 1:09 ` Hillf Danton
2020-09-07 7:02 ` Marek Szyprowski
2020-09-07 7:02 ` Marek Szyprowski
2020-09-07 7:49 ` Christoph Hellwig
2020-09-07 7:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599233679.5231.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.