All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Taylor Blau <me@ttaylorr.com>, Ronan Pigott <ronan@rjp.ie>
Cc: git@vger.kernel.org, Andrzej Hunt <ajrhunt@google.com>,
	Junio C Hamano <gitster@pobox.com>,
	Andrzej Hunt <andrzej@ahunt.org>
Subject: Re: [PATCH 1/2] for-each-repo: interpolate repo path arguments
Date: Mon, 7 Nov 2022 15:46:36 -0500	[thread overview]
Message-ID: <15d9326c-8a32-c11c-53b0-cf399e541a48@github.com> (raw)
In-Reply-To: <Y2cAFSR83bjFFcq/@nand.local>

On 11/5/22 8:30 PM, Taylor Blau wrote:
> On Sat, Nov 05, 2022 at 11:45:31AM -0700, Ronan Pigott wrote:
>> This is a quality of life change for git-maintenance, so repos can be
>> recorded with the tilde syntax. The register subcommand will not record
>> repos in this format by default.
>>
>> Signed-off-by: Ronan Pigott <ronan@rjp.ie>
>> ---
>>  builtin/for-each-repo.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Seems reasonable. So the 'register' subcommand will never write a record
> that isn't an absolute path, but a user may manually munge the
> maintenance configuration and we want to err on the side of flexibility.
> 
> OK, sounds good. Missing test, though?

I agree that this implementation looks good, but a test
would be helpful to be sure.

Thanks,
-Stolee

  reply	other threads:[~2022-11-07 20:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 18:45 [PATCH 0/2] git-maintenance quality-of-life improvements Ronan Pigott
2022-11-05 18:45 ` [PATCH 1/2] for-each-repo: interpolate repo path arguments Ronan Pigott
2022-11-06  0:30   ` Taylor Blau
2022-11-07 20:46     ` Derrick Stolee [this message]
2022-11-05 18:45 ` [PATCH 2/2] maintenance: add option to register in a specific config Ronan Pigott
2022-11-06  0:28   ` Taylor Blau
2022-11-06  0:42   ` Taylor Blau
2022-11-07 20:49   ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15d9326c-8a32-c11c-53b0-cf399e541a48@github.com \
    --to=derrickstolee@github.com \
    --cc=ajrhunt@google.com \
    --cc=andrzej@ahunt.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=ronan@rjp.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.