From: Taylor Blau <me@ttaylorr.com>
To: Ronan Pigott <ronan@rjp.ie>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Clement Moyroud" <clement.moyroud@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Alex Henrie" <alexhenrie24@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Thomas Ackermann" <th.acker@arcor.de>
Subject: Re: [PATCH 2/2] maintenance: add option to register in a specific config
Date: Sat, 5 Nov 2022 20:28:36 -0400 [thread overview]
Message-ID: <Y2b/tCUc3nGI+8M7@nand.local> (raw)
In-Reply-To: <20221105184532.457043-3-ronan@rjp.ie>
On Sat, Nov 05, 2022 at 11:45:32AM -0700, Ronan Pigott wrote:
> @@ -1502,7 +1504,7 @@ static int maintenance_register(int argc, const char **argv, const char *prefix)
> if (!user_config)
> die(_("$HOME not set"));
> rc = git_config_set_multivar_in_file_gently(
> - user_config, "maintenance.repo", maintpath,
> + config_file ?: user_config, "maintenance.repo", maintpath,
> CONFIG_REGEX_NONE, 0);
> free(user_config);
> free(xdg_config);
The "?:" construct is a GNU extension which we do not use.
Thanks,
Taylor
next prev parent reply other threads:[~2022-11-06 0:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 18:45 [PATCH 0/2] git-maintenance quality-of-life improvements Ronan Pigott
2022-11-05 18:45 ` [PATCH 1/2] for-each-repo: interpolate repo path arguments Ronan Pigott
2022-11-06 0:30 ` Taylor Blau
2022-11-07 20:46 ` Derrick Stolee
2022-11-05 18:45 ` [PATCH 2/2] maintenance: add option to register in a specific config Ronan Pigott
2022-11-06 0:28 ` Taylor Blau [this message]
2022-11-06 0:42 ` Taylor Blau
2022-11-07 20:49 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2b/tCUc3nGI+8M7@nand.local \
--to=me@ttaylorr.com \
--cc=alexhenrie24@gmail.com \
--cc=clement.moyroud@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=ronan@rjp.ie \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
--cc=th.acker@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.