From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: clarify IS_GEN vs IS_<product> usage
Date: Mon, 09 May 2011 20:09:22 +0100 [thread overview]
Message-ID: <15db10$kia2f3@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20110509114213.34816211@jbarnes-desktop>
On Mon, 9 May 2011 11:42:13 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 05 May 2011 23:57:56 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Whilst you are in the vicinity, does it make sense to rename info->gen to
> > info->render (or info->render_gen)?
>
> Sure.
Ok, that really does reveal in how many locations we have conflated the
display generation and the render generation. I think the next step would
be a display generation enum. The third generation counter would be the
BIOS/chipset series. And then we have those promiscuous registers used
everywhere!
Reading through it, I think the render_gen patch just highlights the
obvious confusion and so we shouldn't apply it until we have some remedial
patches.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-05-09 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 22:16 [PATCH] drm/i915: clarify IS_GEN vs IS_<product> usage Jesse Barnes
2011-05-05 22:57 ` Chris Wilson
2011-05-09 18:42 ` Jesse Barnes
2011-05-09 19:09 ` Chris Wilson [this message]
2011-05-10 18:45 ` Eric Anholt
2011-05-10 21:24 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='15db10$kia2f3@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.