All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christopher Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"sre@kernel.org" <sre@kernel.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>
Subject: Re: [PATCH V4 1/5] dt-bindings: mfd: ti,bq25703a: Add TI BQ25703A Charger
Date: Wed, 2 Jul 2025 22:40:51 +0200	[thread overview]
Message-ID: <15fb5256-b0ab-49f9-9ec0-e681a9412fde@kernel.org> (raw)
In-Reply-To: <SN6PR1901MB4654D8420C9F65C8BE2D10ECA546A@SN6PR1901MB4654.namprd19.prod.outlook.com>

On 30/06/2025 16:33, Christopher Morgan wrote:
> 
> 
>> On Jun 27, 2025, at 1:58 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Jun 26, 2025 at 02:53:39PM -0500, Chris Morgan wrote:
>>> From: Chris Morgan <macromorgan@hotmail.com>
>>>
>>> Document the Texas instruments BQ25703A series of charger managers/
>>> buck/boost regulators.
>>>
>>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>>
>> Didn't you receive tag?
> 
> I did, I’m sorry but I thought the changes suggested were substantive enough to warrant another review so I dropped it. I did leave it on the other patches though. If I should have kept the tag I’ll try to remember next time.

Which changes? Cover letter is vague - only some sort of cleanup - and
anyway dropping tag needs to be explicit with a reason.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christopher Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"sre@kernel.org" <sre@kernel.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>
Subject: Re: [PATCH V4 1/5] dt-bindings: mfd: ti,bq25703a: Add TI BQ25703A Charger
Date: Wed, 2 Jul 2025 22:40:51 +0200	[thread overview]
Message-ID: <15fb5256-b0ab-49f9-9ec0-e681a9412fde@kernel.org> (raw)
In-Reply-To: <SN6PR1901MB4654D8420C9F65C8BE2D10ECA546A@SN6PR1901MB4654.namprd19.prod.outlook.com>

On 30/06/2025 16:33, Christopher Morgan wrote:
> 
> 
>> On Jun 27, 2025, at 1:58 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Jun 26, 2025 at 02:53:39PM -0500, Chris Morgan wrote:
>>> From: Chris Morgan <macromorgan@hotmail.com>
>>>
>>> Document the Texas instruments BQ25703A series of charger managers/
>>> buck/boost regulators.
>>>
>>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>>
>> Didn't you receive tag?
> 
> I did, I’m sorry but I thought the changes suggested were substantive enough to warrant another review so I dropped it. I did leave it on the other patches though. If I should have kept the tag I’ll try to remember next time.

Which changes? Cover letter is vague - only some sort of cleanup - and
anyway dropping tag needs to be explicit with a reason.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2025-07-02 20:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 19:53 [PATCH V4 0/5] Add Texas Instruments BQ25703A Charger Chris Morgan
2025-06-26 19:53 ` Chris Morgan
2025-06-26 19:53 ` [PATCH V4 1/5] dt-bindings: mfd: ti,bq25703a: Add TI " Chris Morgan
2025-06-26 19:53   ` Chris Morgan
2025-06-27  6:58   ` Krzysztof Kozlowski
2025-06-27  6:58     ` Krzysztof Kozlowski
2025-06-30 14:33     ` Christopher Morgan
2025-06-30 14:33       ` Christopher Morgan
2025-06-30 15:15       ` Diederik de Haas
2025-06-30 15:15         ` Diederik de Haas
2025-07-02 20:40       ` Krzysztof Kozlowski [this message]
2025-07-02 20:40         ` Krzysztof Kozlowski
2025-06-26 19:53 ` [PATCH V4 2/5] mfd: bq257xx: Add support for BQ25703A core driver Chris Morgan
2025-06-26 19:53   ` Chris Morgan
2025-06-26 19:53 ` [PATCH V4 3/5] power: supply: bq257xx: Add support for BQ257XX charger Chris Morgan
2025-06-26 19:53   ` Chris Morgan
2025-06-26 19:53 ` [PATCH V4 4/5] regulator: bq257xx: Add bq257xx boost regulator driver Chris Morgan
2025-06-26 19:53   ` Chris Morgan
2025-06-26 19:53 ` [PATCH V4 5/5] arm64: dts: rockchip: Add USB and charger to Gameforce Ace Chris Morgan
2025-06-26 19:53   ` Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15fb5256-b0ab-49f9-9ec0-e681a9412fde@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.