From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kernel test robot <lkp@intel.com>, linux-integrity@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Mimi Zohar <zohar@linux.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v11 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs
Date: Sun, 13 Sep 2020 17:02:51 +0000 [thread overview]
Message-ID: <1600016571.7833.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <202009131413.8dt8QEc8%lkp@intel.com>
On Sun, 2020-09-13 at 14:26 +0800, kernel test robot wrote:
> Hi James,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on integrity/next-integrity]
> [also build test ERROR on linus/master v5.9-rc4 next-20200911]
> [cannot apply to security/next-testing dhowells-fs/fscache-next]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/James-Bottomley/TPM-
> 2-0-trusted-key-rework/20200913-013201
> base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-i
> ntegrity.git next-integrity
> config: arm-randconfig-r013-20200913 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
> 3170d54842655d6d936aae32b7d0bc92fce7f22e)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master
> /sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
> ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> > > security/keys/trusted-keys/trusted_tpm2.c:19:10: fatal error:
> > > 'tpm2key.asn1.h' file not found
>
> #include "tpm2key.asn1.h"
> ^~~~~~~~~~~~~~~~
> 1 error generated.
Do you have the actual build log for this? On x86 the build process
builds any precursors first, which is the tpm2key.asn1.o, which
generates that header file, so we see:
ASN.1 security/keys/trusted-keys/tpm2key.asn1.[ch]
CC [M] security/keys/trusted-keys/trusted_tpm2.o
CC [M] security/keys/trusted-keys/tpm2-policy.o
CC [M] security/keys/trusted-keys/tpm2key.asn1.o
LD [M] security/keys/trusted-keys/trusted.o
Is ARM doing a lazier version of that? In which case the fix might be
to move trusted_tpm2.o to after tpm2key.asn1.o in the Makefile, this
line:
trusted-y += trusted_tpm2.o tpm2key.asn1.o
James
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kernel test robot <lkp@intel.com>, linux-integrity@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Mimi Zohar <zohar@linux.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
David Woodhouse <dwmw2@infradead.org>,
keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v11 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs
Date: Sun, 13 Sep 2020 10:02:51 -0700 [thread overview]
Message-ID: <1600016571.7833.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <202009131413.8dt8QEc8%lkp@intel.com>
On Sun, 2020-09-13 at 14:26 +0800, kernel test robot wrote:
> Hi James,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on integrity/next-integrity]
> [also build test ERROR on linus/master v5.9-rc4 next-20200911]
> [cannot apply to security/next-testing dhowells-fs/fscache-next]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/James-Bottomley/TPM-
> 2-0-trusted-key-rework/20200913-013201
> base: https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-i
> ntegrity.git next-integrity
> config: arm-randconfig-r013-20200913 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
> 3170d54842655d6d936aae32b7d0bc92fce7f22e)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master
> /sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross
> ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> > > security/keys/trusted-keys/trusted_tpm2.c:19:10: fatal error:
> > > 'tpm2key.asn1.h' file not found
>
> #include "tpm2key.asn1.h"
> ^~~~~~~~~~~~~~~~
> 1 error generated.
Do you have the actual build log for this? On x86 the build process
builds any precursors first, which is the tpm2key.asn1.o, which
generates that header file, so we see:
ASN.1 security/keys/trusted-keys/tpm2key.asn1.[ch]
CC [M] security/keys/trusted-keys/trusted_tpm2.o
CC [M] security/keys/trusted-keys/tpm2-policy.o
CC [M] security/keys/trusted-keys/tpm2key.asn1.o
LD [M] security/keys/trusted-keys/trusted.o
Is ARM doing a lazier version of that? In which case the fix might be
to move trusted_tpm2.o to after tpm2key.asn1.o in the Makefile, this
line:
trusted-y += trusted_tpm2.o tpm2key.asn1.o
James
next prev parent reply other threads:[~2020-09-13 17:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 17:26 [PATCH v11 0/5] TPM 2.0 trusted key rework James Bottomley
2020-09-12 17:26 ` James Bottomley
2020-09-12 17:26 ` [PATCH v11 1/5] lib: add ASN.1 encoder James Bottomley
2020-09-12 17:26 ` James Bottomley
2020-09-12 17:26 ` [PATCH v11 2/5] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-09-12 17:26 ` James Bottomley
2020-09-12 17:26 ` [PATCH v11 3/5] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-09-12 17:26 ` James Bottomley
2020-09-15 9:09 ` Jarkko Sakkinen
2020-09-15 9:09 ` Jarkko Sakkinen
2020-09-16 19:52 ` James Bottomley
2020-09-16 19:52 ` James Bottomley
2020-09-17 15:21 ` Jarkko Sakkinen
2020-09-17 15:21 ` Jarkko Sakkinen
2020-09-12 17:26 ` [PATCH v11 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-09-12 17:26 ` James Bottomley
2020-09-13 6:26 ` kernel test robot
2020-09-13 6:26 ` kernel test robot
2020-09-13 6:26 ` kernel test robot
2020-09-13 17:02 ` James Bottomley [this message]
2020-09-13 17:02 ` James Bottomley
2020-09-15 9:11 ` Jarkko Sakkinen
2020-09-15 20:20 ` Nick Desaulniers
2020-09-15 20:20 ` Nick Desaulniers
2020-09-15 20:20 ` Nick Desaulniers
2020-09-16 16:27 ` Jarkko Sakkinen
2020-09-16 16:27 ` Jarkko Sakkinen
2020-09-16 16:27 ` Jarkko Sakkinen
2020-09-16 18:04 ` Nick Desaulniers
2020-09-16 18:04 ` Nick Desaulniers
2020-09-16 18:04 ` Nick Desaulniers
2020-09-17 15:17 ` Jarkko Sakkinen
2020-09-17 15:17 ` Jarkko Sakkinen
2020-09-17 15:17 ` Jarkko Sakkinen
2020-09-13 7:07 ` kernel test robot
2020-09-13 7:29 ` kernel test robot
2020-09-12 17:26 ` [PATCH v11 5/5] security: keys: trusted: Make sealed key properly interoperable James Bottomley
2020-09-12 17:26 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2020-09-13 9:35 [PATCH v11 4/5] security: keys: trusted: use ASN.1 TPM2 key format for the blobs kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600016571.7833.9.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=lkp@intel.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.