* [PATCH 0/1] Use memset_io to access I/O memory
@ 2020-09-18 10:00 ` Shane Chien
0 siblings, 0 replies; 8+ messages in thread
From: Shane Chien @ 2020-09-18 10:00 UTC (permalink / raw)
To: Matthias Brugger, Mark Brown
Cc: devicetree, wsd_upstream, linux-kernel, jiaxin.yu, shane.chien,
linux-mediatek, eason.yen
From: "Shane.Chien" <shane.chien@mediatek.com>
Use memset_io to access I/O memory, instead of
memset.
Shane.Chien (1):
ASoC: Use memset_io to access I/O memory
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] Use memset_io to access I/O memory
@ 2020-09-18 10:00 ` Shane Chien
0 siblings, 0 replies; 8+ messages in thread
From: Shane Chien @ 2020-09-18 10:00 UTC (permalink / raw)
To: Matthias Brugger, Mark Brown
Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream, jiaxin.yu,
eason.yen, shane.chien
From: "Shane.Chien" <shane.chien@mediatek.com>
Use memset_io to access I/O memory, instead of
memset.
Shane.Chien (1):
ASoC: Use memset_io to access I/O memory
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: Use memset_io to access I/O memory
2020-09-18 10:00 ` Shane Chien
@ 2020-09-18 10:00 ` Shane Chien
-1 siblings, 0 replies; 8+ messages in thread
From: Shane Chien @ 2020-09-18 10:00 UTC (permalink / raw)
To: Matthias Brugger, Mark Brown
Cc: devicetree, wsd_upstream, linux-kernel, jiaxin.yu, shane.chien,
linux-mediatek, eason.yen
From: "Shane.Chien" <shane.chien@mediatek.com>
Use memset_io to access I/O memory, instead of
memset.
Signed-off-by: Shane.Chien <shane.chien@mediatek.com>
---
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 9e0b2d7..a4efa84 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -756,7 +756,7 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream,
/* clear the buffer for avoiding possible kernel info leaks */
if (runtime->dma_area && !substream->ops->copy_user)
- memset(runtime->dma_area, 0, runtime->dma_bytes);
+ memset_io(runtime->dma_area, 0, runtime->dma_bytes);
snd_pcm_timer_resolution_change(substream);
snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP);
--
1.7.9.5
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ASoC: Use memset_io to access I/O memory
@ 2020-09-18 10:00 ` Shane Chien
0 siblings, 0 replies; 8+ messages in thread
From: Shane Chien @ 2020-09-18 10:00 UTC (permalink / raw)
To: Matthias Brugger, Mark Brown
Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream, jiaxin.yu,
eason.yen, shane.chien
From: "Shane.Chien" <shane.chien@mediatek.com>
Use memset_io to access I/O memory, instead of
memset.
Signed-off-by: Shane.Chien <shane.chien@mediatek.com>
---
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 9e0b2d7..a4efa84 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -756,7 +756,7 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream,
/* clear the buffer for avoiding possible kernel info leaks */
if (runtime->dma_area && !substream->ops->copy_user)
- memset(runtime->dma_area, 0, runtime->dma_bytes);
+ memset_io(runtime->dma_area, 0, runtime->dma_bytes);
snd_pcm_timer_resolution_change(substream);
snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Use memset_io to access I/O memory
2020-09-18 10:00 ` Shane Chien
@ 2020-09-18 11:01 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-18 11:01 UTC (permalink / raw)
To: Shane Chien
Cc: devicetree, wsd_upstream, linux-kernel, jiaxin.yu, linux-mediatek,
eason.yen, Matthias Brugger
[-- Attachment #1.1: Type: text/plain, Size: 480 bytes --]
On Fri, Sep 18, 2020 at 06:00:19PM +0800, Shane Chien wrote:
> /* clear the buffer for avoiding possible kernel info leaks */
> if (runtime->dma_area && !substream->ops->copy_user)
> - memset(runtime->dma_area, 0, runtime->dma_bytes);
> + memset_io(runtime->dma_area, 0, runtime->dma_bytes);
This is regular RAM that will be accessed by the devices rather than
memory mapped regions provided by devices, the _io variants are normally
for memory mapped regions on devices.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Use memset_io to access I/O memory
@ 2020-09-18 11:01 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-18 11:01 UTC (permalink / raw)
To: Shane Chien
Cc: Matthias Brugger, linux-kernel, linux-mediatek, devicetree,
wsd_upstream, jiaxin.yu, eason.yen
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Fri, Sep 18, 2020 at 06:00:19PM +0800, Shane Chien wrote:
> /* clear the buffer for avoiding possible kernel info leaks */
> if (runtime->dma_area && !substream->ops->copy_user)
> - memset(runtime->dma_area, 0, runtime->dma_bytes);
> + memset_io(runtime->dma_area, 0, runtime->dma_bytes);
This is regular RAM that will be accessed by the devices rather than
memory mapped regions provided by devices, the _io variants are normally
for memory mapped regions on devices.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] Use memset_io to access I/O memory
2020-09-18 10:00 ` Shane Chien
@ 2020-09-18 10:05 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-18 10:05 UTC (permalink / raw)
To: Shane Chien
Cc: devicetree, wsd_upstream, linux-kernel, jiaxin.yu, linux-mediatek,
eason.yen, Matthias Brugger
[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]
On Fri, Sep 18, 2020 at 06:00:18PM +0800, Shane Chien wrote:
> From: "Shane.Chien" <shane.chien@mediatek.com>
>
> Use memset_io to access I/O memory, instead of
> memset.
Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/1] Use memset_io to access I/O memory
@ 2020-09-18 10:05 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2020-09-18 10:05 UTC (permalink / raw)
To: Shane Chien
Cc: Matthias Brugger, linux-kernel, linux-mediatek, devicetree,
wsd_upstream, jiaxin.yu, eason.yen
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Fri, Sep 18, 2020 at 06:00:18PM +0800, Shane Chien wrote:
> From: "Shane.Chien" <shane.chien@mediatek.com>
>
> Use memset_io to access I/O memory, instead of
> memset.
Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-18 11:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 10:00 [PATCH 0/1] Use memset_io to access I/O memory Shane Chien
2020-09-18 10:00 ` Shane Chien
2020-09-18 10:00 ` [PATCH] ASoC: " Shane Chien
2020-09-18 10:00 ` Shane Chien
2020-09-18 11:01 ` Mark Brown
2020-09-18 11:01 ` Mark Brown
2020-09-18 10:05 ` [PATCH 0/1] " Mark Brown
2020-09-18 10:05 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.