All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jose Abreu <jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	"Leonidas P . Papadakos"
	<papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance.
Date: Thu, 27 Jun 2019 00:22:36 +0200	[thread overview]
Message-ID: <1609807.FCSDk0ZevM@phil> (raw)
In-Reply-To: <20190626130443.22025-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Am Mittwoch, 26. Juni 2019, 15:04:43 CEST schrieb Peter Geis:
> Currently the rk3328-roc-cc ethernet is enabled using "snps,force_thresh_dma_mode".
> While this works, the performance leaves a lot to be desired.
> A previous attempt to improve performance used "snps,txpbl = <0x4>".
> This also allowed networking to function, but performance varied between boards.
> 
> This patch takes that one step further.
> Set txpbl and rxpbl to 0x4.
> This can also be accomplished with "snps,pbl =<0x4>" which affects both.
> Also set "snps,aal" which forces address aligned DMA mode.
> 
> Fixes: 4bc4d6013b7f (arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues)
> 
> Signed-off-by: Peter Geis <pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> Tested-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

applied for 5.3 after sorting the new properties alphabetically.

Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Jose Abreu <jose.abreu@synopsys.com>,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Robin Murphy <robin.murphy@arm.com>,
	"Leonidas P . Papadakos" <papadakospan@gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance.
Date: Thu, 27 Jun 2019 00:22:36 +0200	[thread overview]
Message-ID: <1609807.FCSDk0ZevM@phil> (raw)
In-Reply-To: <20190626130443.22025-1-pgwipeout@gmail.com>

Am Mittwoch, 26. Juni 2019, 15:04:43 CEST schrieb Peter Geis:
> Currently the rk3328-roc-cc ethernet is enabled using "snps,force_thresh_dma_mode".
> While this works, the performance leaves a lot to be desired.
> A previous attempt to improve performance used "snps,txpbl = <0x4>".
> This also allowed networking to function, but performance varied between boards.
> 
> This patch takes that one step further.
> Set txpbl and rxpbl to 0x4.
> This can also be accomplished with "snps,pbl =<0x4>" which affects both.
> Also set "snps,aal" which forces address aligned DMA mode.
> 
> Fixes: 4bc4d6013b7f (arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues)
> 
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> 
> Tested-by: Leonidas P. Papadakos <papadakospan@gmail.com>

applied for 5.3 after sorting the new properties alphabetically.

Thanks
Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-26 22:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 13:04 [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance Peter Geis
2019-06-26 13:04 ` Peter Geis
     [not found] ` <20190626130443.22025-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-26 22:22   ` Heiko Stuebner [this message]
2019-06-26 22:22     ` Heiko Stuebner
  -- strict thread matches above, loose matches on Subject: below --
2019-06-07 12:37 Peter Geis
2019-06-07 12:37 ` Peter Geis
2019-06-07 12:58 ` Leonidas P. Papadakos
2019-06-07 12:58   ` Leonidas P. Papadakos
     [not found]   ` <1559912295.22520.0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-07 23:07     ` Peter Geis
2019-06-07 23:07       ` Peter Geis
     [not found]       ` <CAMdYzYorvWr1YhmFKaMQUCditjop5AZp4d1tO79XsVr7m7HrMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-14  9:39         ` Heiko Stuebner
2019-06-14  9:39           ` Heiko Stuebner
2019-06-14 19:49           ` Leonidas P. Papadakos
2019-06-14 19:49             ` Leonidas P. Papadakos
2019-06-14 21:27       ` Leonidas P. Papadakos
2019-06-14 21:27         ` Leonidas P. Papadakos
2019-06-15 12:12         ` Peter Geis
2019-06-15 12:12           ` Peter Geis
2019-06-15 13:32           ` Jonas Karlman
2019-06-15 13:32             ` Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1609807.FCSDk0ZevM@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jose.abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.