[PATCH] mmc: sdhci: skip cache invalidation if DMA is not used

[PATCH] mmc: sdhci: skip cache invalidation if DMA is not used

[Yuezhang.Mo at sony.com]

If DMA(SDMA or ADMA) is not used, the cache invalidation
after reading is no need, should be skipped. Otherwise
U-Boot may hang at the cache invalidation.

Found this issue and tested this fix on DragonBoard 410c.

Fixes: commit 4155ad9aac94 ("mmc: sdhci: fix missing cache invalidation after reading by DMA")

Signed-off-by: Yuezhang.Mo <Yuezhang.Mo@sony.com>
---
 drivers/mmc/sdhci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index 0628934312..29099199a7 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -174,8 +174,10 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data)
 		}
 	} while (!(stat & SDHCI_INT_DATA_END));
 
+#if (defined(CONFIG_MMC_SDHCI_SDMA) || CONFIG_IS_ENABLED(MMC_SDHCI_ADMA))
 	dma_unmap_single(host->start_addr, data->blocks * data->blocksize,
 			 mmc_get_dma_dir(data));
+#endif
 
 	return 0;
 }
-- 
2.25.1

[PATCH] mmc: sdhci: skip cache invalidation if DMA is not used

[Andy.Wu]

The config usage keep the same style as function sdhci_prepare_dma().

Reviewed-by: Andy Wu <Andy.Wu@sony.com> 

> +#if (defined(CONFIG_MMC_SDHCI_SDMA) || CONFIG_IS_ENABLED(MMC_SDHCI_ADMA))
>   dma_unmap_single(host->start_addr, data->blocks * data->blocksize,
>   mmc_get_dma_dir(data));
> +#endif 



--
Sent from: http://u-boot.10912.n7.nabble.com/