From: patchwork-bot+netdevbpf@kernel.org
To: Xie He <xie.he.0141@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux-x25@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ms@dev.tdt.de, khc@pm.waw.pl
Subject: Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open
Date: Fri, 05 Feb 2021 02:20:06 +0000 [thread overview]
Message-ID: <161249160674.1910.18013606879384884718.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210203071541.86138-1-xie.he.0141@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 2 Feb 2021 23:15:41 -0800 you wrote:
> It's not meaningful to pass on LAPB error codes to HDLC code or other
> parts of the system, because they will not understand the error codes.
>
> Instead, use system-wide recognizable error codes.
>
> Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: hdlc_x25: Return meaningful error code in x25_open
https://git.kernel.org/netdev/net/c/81b8be68ef8e
You are awesome, thank you!
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Xie He <xie.he.0141@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux-x25@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ms@dev.tdt.de, khc@pm.waw.pl
Subject: Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open
Date: Fri, 05 Feb 2021 02:20:06 +0000 [thread overview]
Message-ID: <161249160674.1910.18013606879384884718.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210203071541.86138-1-xie.he.0141@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 2 Feb 2021 23:15:41 -0800 you wrote:
> It's not meaningful to pass on LAPB error codes to HDLC code or other
> parts of the system, because they will not understand the error codes.
>
> Instead, use system-wide recognizable error codes.
>
> Fixes: f362e5fe0f1f ("wan/hdlc_x25: make lapb params configurable")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: hdlc_x25: Return meaningful error code in x25_open
https://git.kernel.org/netdev/net/c/81b8be68ef8e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-02-05 2:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 7:15 [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open Xie He
2021-02-04 6:20 ` Martin Schiller
2021-02-05 2:20 ` patchwork-bot+netdevbpf [this message]
2021-02-05 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161249160674.1910.18013606879384884718.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.