All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qii Wang <qii.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <matthias.bgg@gmail.com>, <wsa@the-dreams.de>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>
Subject: Re: [PATCH] dt-bindings: i2c: Add device clock-stretch time via dts
Date: Fri, 26 Mar 2021 09:30:52 +0800	[thread overview]
Message-ID: <1616722252.22957.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20210324171217.GA3262580@robh.at.kernel.org>

On Wed, 2021-03-24 at 11:12 -0600, Rob Herring wrote:
> On Sat, Mar 13, 2021 at 04:07:09PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> > 
> > tSU,STA/tHD,STA/tSU,STOP maybe out of spec due to device
> > clock-stretching or circuit loss, we could get device
> > clock-stretch time from dts to adjust these parameters
> > to meet the spec via EXT_CONF register.
> > 
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > index 7f0194f..97f66f0 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > @@ -32,6 +32,7 @@ Optional properties:
> >    - mediatek,have-pmic: platform can control i2c form special pmic side.
> >      Only mt6589 and mt8135 support this feature.
> >    - mediatek,use-push-pull: IO config use push-pull mode.
> > +  - clock-stretch-ns: Slave device clock-stretch time.
> 
> Should be a common I2C property?
> 

Wolfram Sang will look at this next and think about it. I hope it would
be a common I2C property.

> >  
> >  Example:
> >  
> > -- 
> > 1.9.1
> > 

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Qii Wang <qii.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <matthias.bgg@gmail.com>, <wsa@the-dreams.de>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>
Subject: Re: [PATCH] dt-bindings: i2c: Add device clock-stretch time via dts
Date: Fri, 26 Mar 2021 09:30:52 +0800	[thread overview]
Message-ID: <1616722252.22957.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20210324171217.GA3262580@robh.at.kernel.org>

On Wed, 2021-03-24 at 11:12 -0600, Rob Herring wrote:
> On Sat, Mar 13, 2021 at 04:07:09PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> > 
> > tSU,STA/tHD,STA/tSU,STOP maybe out of spec due to device
> > clock-stretching or circuit loss, we could get device
> > clock-stretch time from dts to adjust these parameters
> > to meet the spec via EXT_CONF register.
> > 
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > index 7f0194f..97f66f0 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > @@ -32,6 +32,7 @@ Optional properties:
> >    - mediatek,have-pmic: platform can control i2c form special pmic side.
> >      Only mt6589 and mt8135 support this feature.
> >    - mediatek,use-push-pull: IO config use push-pull mode.
> > +  - clock-stretch-ns: Slave device clock-stretch time.
> 
> Should be a common I2C property?
> 

Wolfram Sang will look at this next and think about it. I hope it would
be a common I2C property.

> >  
> >  Example:
> >  
> > -- 
> > 1.9.1
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Qii Wang <qii.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: <matthias.bgg@gmail.com>, <wsa@the-dreams.de>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>
Subject: Re: [PATCH] dt-bindings: i2c: Add device clock-stretch time via dts
Date: Fri, 26 Mar 2021 09:30:52 +0800	[thread overview]
Message-ID: <1616722252.22957.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20210324171217.GA3262580@robh.at.kernel.org>

On Wed, 2021-03-24 at 11:12 -0600, Rob Herring wrote:
> On Sat, Mar 13, 2021 at 04:07:09PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> > 
> > tSU,STA/tHD,STA/tSU,STOP maybe out of spec due to device
> > clock-stretching or circuit loss, we could get device
> > clock-stretch time from dts to adjust these parameters
> > to meet the spec via EXT_CONF register.
> > 
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > index 7f0194f..97f66f0 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> > @@ -32,6 +32,7 @@ Optional properties:
> >    - mediatek,have-pmic: platform can control i2c form special pmic side.
> >      Only mt6589 and mt8135 support this feature.
> >    - mediatek,use-push-pull: IO config use push-pull mode.
> > +  - clock-stretch-ns: Slave device clock-stretch time.
> 
> Should be a common I2C property?
> 

Wolfram Sang will look at this next and think about it. I hope it would
be a common I2C property.

> >  
> >  Example:
> >  
> > -- 
> > 1.9.1
> > 


  reply	other threads:[~2021-03-26  1:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13  8:07 [PATCH] dt-bindings: i2c: Add device clock-stretch time via dts qii.wang
2021-03-13  8:07 ` qii.wang
2021-03-13  8:07 ` qii.wang
2021-03-24 17:12 ` Rob Herring
2021-03-24 17:12   ` Rob Herring
2021-03-24 17:12   ` Rob Herring
2021-03-26  1:30   ` Qii Wang [this message]
2021-03-26  1:30     ` Qii Wang
2021-03-26  1:30     ` Qii Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1616722252.22957.3.camel@mhfsdcap03 \
    --to=qii.wang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.