[PATCH 0/2] Exynos5 device tree fixes

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/2] Exynos5 device tree fixes
@ 2013-08-28 12:42 ` Chander Kashyap
  0 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel
  Cc: kgene.kim, thomas.ab, t.figa, Chander Kashyap

This patch series fixes two problem with MCT node in Exynos5 platforms.
1. In Exynos5250 it fixes the number of interrupt-cells.
2. Removes invalid properties in MCT node for Exynos5420 and Exynos5250.

Chander Kashyap (2):
  ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
  DTS: Exynos5: Remove invalid MCT properties

 arch/arm/boot/dts/exynos5250.dtsi |   19 ++++++++-----------
 arch/arm/boot/dts/exynos5420.dtsi |    2 --
 2 files changed, 8 insertions(+), 13 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 0/2] Exynos5 device tree fixes
@ 2013-08-28 12:42 ` Chander Kashyap
  0 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-arm-kernel

This patch series fixes two problem with MCT node in Exynos5 platforms.
1. In Exynos5250 it fixes the number of interrupt-cells.
2. Removes invalid properties in MCT node for Exynos5420 and Exynos5250.

Chander Kashyap (2):
  ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
  DTS: Exynos5: Remove invalid MCT properties

 arch/arm/boot/dts/exynos5250.dtsi |   19 ++++++++-----------
 arch/arm/boot/dts/exynos5420.dtsi |    2 --
 2 files changed, 8 insertions(+), 13 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
  2013-08-28 12:42 ` Chander Kashyap
@ 2013-08-28 12:42   ` Chander Kashyap
  -1 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel
  Cc: kgene.kim, thomas.ab, t.figa, Chander Kashyap

Two cells were used to specify interrupts in mct node, while second cell
always remains unused. Hence use only one cell.
Suggested by Tomasz Figa.

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..f2f178a 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -102,23 +102,22 @@
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
 		interrupt-controller;
-		#interrups-cells = <2>;
+		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
-		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
-			     <4 0>, <5 0>;
+		interrupts = <0>, <1>, <2>, <3>, <4>, <5>;
 		clocks = <&clock 1>, <&clock 335>;
 		clock-names = "fin_pll", "mct";
 
 		mct_map: mct-map {
-			#interrupt-cells = <2>;
+			#interrupt-cells = <1>;
 			#address-cells = <0>;
 			#size-cells = <0>;
-			interrupt-map = <0x0 0 &combiner 23 3>,
-					<0x1 0 &combiner 23 4>,
-					<0x2 0 &combiner 25 2>,
-					<0x3 0 &combiner 25 3>,
-					<0x4 0 &gic 0 120 0>,
-					<0x5 0 &gic 0 121 0>;
+			interrupt-map = <0 &combiner 23 3>,
+					<1 &combiner 23 4>,
+					<2 &combiner 25 2>,
+					<3 &combiner 25 3>,
+					<4 &gic 0 120 0>,
+					<5 &gic 0 121 0>;
 		};
 	};
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 1/2] ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
@ 2013-08-28 12:42   ` Chander Kashyap
  0 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-arm-kernel

Two cells were used to specify interrupts in mct node, while second cell
always remains unused. Hence use only one cell.
Suggested by Tomasz Figa.

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ef57277..f2f178a 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -102,23 +102,22 @@
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
 		interrupt-controller;
-		#interrups-cells = <2>;
+		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
-		interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
-			     <4 0>, <5 0>;
+		interrupts = <0>, <1>, <2>, <3>, <4>, <5>;
 		clocks = <&clock 1>, <&clock 335>;
 		clock-names = "fin_pll", "mct";
 
 		mct_map: mct-map {
-			#interrupt-cells = <2>;
+			#interrupt-cells = <1>;
 			#address-cells = <0>;
 			#size-cells = <0>;
-			interrupt-map = <0x0 0 &combiner 23 3>,
-					<0x1 0 &combiner 23 4>,
-					<0x2 0 &combiner 25 2>,
-					<0x3 0 &combiner 25 3>,
-					<0x4 0 &gic 0 120 0>,
-					<0x5 0 &gic 0 121 0>;
+			interrupt-map = <0 &combiner 23 3>,
+					<1 &combiner 23 4>,
+					<2 &combiner 25 2>,
+					<3 &combiner 25 3>,
+					<4 &gic 0 120 0>,
+					<5 &gic 0 121 0>;
 		};
 	};
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] DTS: Exynos5: Remove invalid MCT properties
  2013-08-28 12:42 ` Chander Kashyap
@ 2013-08-28 12:42   ` Chander Kashyap
  -1 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel
  Cc: kgene.kim, thomas.ab, t.figa, Chander Kashyap

Remove interrupt-controller and #interrupt-cells properties of MCT device tree
node, as MCT is not an interrupt controllor.

Suggested by: Tomasz Figa

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi |    2 --
 arch/arm/boot/dts/exynos5420.dtsi |    2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f2f178a..dca90ec 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -101,8 +101,6 @@
 	mct@101C0000 {
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
-		interrupt-controller;
-		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
 		interrupts = <0>, <1>, <2>, <3>, <4>, <5>;
 		clocks = <&clock 1>, <&clock 335>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 8c54c4b..6ce2f94 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -68,8 +68,6 @@
 	mct@101C0000 {
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
-		interrupt-controller;
-		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
 		interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>;
 		clocks = <&clock 1>, <&clock 315>;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2] DTS: Exynos5: Remove invalid MCT properties
@ 2013-08-28 12:42   ` Chander Kashyap
  0 siblings, 0 replies; 8+ messages in thread
From: Chander Kashyap @ 2013-08-28 12:42 UTC (permalink / raw)
  To: linux-arm-kernel

Remove interrupt-controller and #interrupt-cells properties of MCT device tree
node, as MCT is not an interrupt controllor.

Suggested by: Tomasz Figa

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 arch/arm/boot/dts/exynos5250.dtsi |    2 --
 arch/arm/boot/dts/exynos5420.dtsi |    2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index f2f178a..dca90ec 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -101,8 +101,6 @@
 	mct at 101C0000 {
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
-		interrupt-controller;
-		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
 		interrupts = <0>, <1>, <2>, <3>, <4>, <5>;
 		clocks = <&clock 1>, <&clock 335>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 8c54c4b..6ce2f94 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -68,8 +68,6 @@
 	mct at 101C0000 {
 		compatible = "samsung,exynos4210-mct";
 		reg = <0x101C0000 0x800>;
-		interrupt-controller;
-		#interrups-cells = <1>;
 		interrupt-parent = <&mct_map>;
 		interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>;
 		clocks = <&clock 1>, <&clock 315>;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2] Exynos5 device tree fixes
  2013-08-28 12:42 ` Chander Kashyap
@ 2013-08-28 13:08   ` Tomasz Figa
  -1 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2013-08-28 13:08 UTC (permalink / raw)
  To: Chander Kashyap; +Cc: linux-samsung-soc, linux-arm-kernel, kgene.kim, thomas.ab

On Wednesday 28 of August 2013 18:12:46 Chander Kashyap wrote:
> This patch series fixes two problem with MCT node in Exynos5 platforms.
> 1. In Exynos5250 it fixes the number of interrupt-cells.
> 2. Removes invalid properties in MCT node for Exynos5420 and Exynos5250.
> 
> Chander Kashyap (2):
>   ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
>   DTS: Exynos5: Remove invalid MCT properties
> 
>  arch/arm/boot/dts/exynos5250.dtsi |   19 ++++++++-----------
>  arch/arm/boot/dts/exynos5420.dtsi |    2 --
>  2 files changed, 8 insertions(+), 13 deletions(-)

For the whole series:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

By the way, it should be noted that this patch is a follow up to my series, 
available at:

http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207

to let reviewing people know that things that this patch relies on, like 
relevant changes to the documentation, have been already posted.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 0/2] Exynos5 device tree fixes
@ 2013-08-28 13:08   ` Tomasz Figa
  0 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2013-08-28 13:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 28 of August 2013 18:12:46 Chander Kashyap wrote:
> This patch series fixes two problem with MCT node in Exynos5 platforms.
> 1. In Exynos5250 it fixes the number of interrupt-cells.
> 2. Removes invalid properties in MCT node for Exynos5420 and Exynos5250.
> 
> Chander Kashyap (2):
>   ARM: DT: Exynos5250: fix number of interrupt-cells in mct node
>   DTS: Exynos5: Remove invalid MCT properties
> 
>  arch/arm/boot/dts/exynos5250.dtsi |   19 ++++++++-----------
>  arch/arm/boot/dts/exynos5420.dtsi |    2 --
>  2 files changed, 8 insertions(+), 13 deletions(-)

For the whole series:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

By the way, it should be noted that this patch is a follow up to my series, 
available at:

http://thread.gmane.org/gmane.linux.kernel.samsung-soc/22207

to let reviewing people know that things that this patch relies on, like 
relevant changes to the documentation, have been already posted.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-08-28 13:08 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-28 12:42 [PATCH 0/2] Exynos5 device tree fixes Chander Kashyap
2013-08-28 12:42 ` Chander Kashyap
2013-08-28 12:42 ` [PATCH 1/2] ARM: DT: Exynos5250: fix number of interrupt-cells in mct node Chander Kashyap
2013-08-28 12:42   ` Chander Kashyap
2013-08-28 12:42 ` [PATCH 2/2] DTS: Exynos5: Remove invalid MCT properties Chander Kashyap
2013-08-28 12:42   ` Chander Kashyap
2013-08-28 13:08 ` [PATCH 0/2] Exynos5 device tree fixes Tomasz Figa
2013-08-28 13:08   ` Tomasz Figa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.