Re: [Outreachy kernel] [PATCH 0/6] Declare functions and structures as static

[Arnd Bergmann <arnd@arndb.de>]

On Thursday 01 October 2015 22:59:35 Shraddha Barke wrote:
> These patches declare the functions and structures which are not
> used anywhere else as static.
> 
> 
> Shraddha Barke (6):
>   Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_merge as static
>   Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_free as static
>   Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_expand as static
>   Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_choose as static
>   Staging: lustre: ptlrpc: Declare sptlrpc_req_replace_dead_ctx as
>     static
>   Staging: lustre: ptlrpc: Declare sptlrpc_parse_rule as static
> 
> 

Individually, each of these looks good and can be applied

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Now that you get the principle right, I think it would be better
to continue with similar patches that do multiple functions at
once and look at the bigger picture. In case of this series, it would
be worth noting that there are two more sptlrpc_rule_set_* functions,
and neither of them should be global. The sptlrpc_rule_set_init()
one is slightly different because it's static inline but can simply
be moved into the file that holds the other functions.

Try to find patterns like this and then handle all symbols that
fall into a similar category as a combined patch.

	Arnd