From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 4/6] Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_choose as static
Date: Fri, 2 Oct 2015 12:01:09 +0530 [thread overview]
Message-ID: <20151002063108.GG3544@sudip-pc> (raw)
In-Reply-To: <alpine.DEB.2.11.1510021120260.27480@shraddha-370R4E-370R4V-370R5E-3570RE-370R5V>
On Fri, Oct 02, 2015 at 11:26:58AM +0530, Shraddha Barke wrote:
>
>
> On Fri, 2 Oct 2015, Sudip Mukherjee wrote:
>
> >On Fri, Oct 02, 2015 at 11:08:48AM +0530, Shraddha Barke wrote:
> >>
> >>
> >>On Fri, 2 Oct 2015, Sudip Mukherjee wrote:
> >>
> >>>On Thu, Oct 01, 2015 at 10:59:39PM +0530, Shraddha Barke wrote:
> >>>>Declare sptlrpc_rule_set_choose as static since it is accessed from this
> >>>>particular file only. Also remove it's declaration from
> >>>>header file
> >>>>
> >>>>Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> >>>>---
> >>>This patch will not apply because of some other changes done by:
> >>>d97cc6442a44 ("staging/lustre/ptlrpc: secure wrapping code cleanup")
> >>
> >>I'm confused as to how it applied to my staging-testing :(
> >>Should I send a v2 dropping this one?
> >
> >Try to see if you have this commit in the tree. Try to rebase. It is not
> >applying because sptlrpc_rule_set_dump() is not there in the file
> >anymore.
>
> Okay, should I send a version 2 for this series?
Yes, please.
regards
sudip
next prev parent reply other threads:[~2015-10-02 6:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 17:29 [PATCH 0/6] Declare functions and structures as static Shraddha Barke
2015-10-01 17:29 ` [PATCH 1/6] Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_merge " Shraddha Barke
2015-10-01 17:29 ` [PATCH 2/6] Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_free " Shraddha Barke
2015-10-01 17:29 ` [PATCH 3/6] Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_expand " Shraddha Barke
2015-10-01 17:29 ` [PATCH 4/6] Staging: lustre: ptlrpc: Declare sptlrpc_rule_set_choose " Shraddha Barke
2015-10-02 4:57 ` [Outreachy kernel] " Sudip Mukherjee
2015-10-02 5:38 ` Shraddha Barke
2015-10-02 5:47 ` Sudip Mukherjee
2015-10-02 5:56 ` Shraddha Barke
2015-10-02 6:31 ` Sudip Mukherjee [this message]
2015-10-01 17:29 ` [PATCH 5/6] Staging: lustre: ptlrpc: Declare sptlrpc_req_replace_dead_ctx " Shraddha Barke
2015-10-01 17:29 ` [PATCH 6/6] Staging: lustre: ptlrpc: Declare sptlrpc_parse_rule " Shraddha Barke
2015-10-01 20:17 ` [Outreachy kernel] [PATCH 0/6] Declare functions and structures " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002063108.GG3544@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.