From: patchwork-bot+netdevbpf@kernel.org
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, nikolay@nvidia.com,
roopa@nvidia.com, kuba@kernel.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next] net: bridge: fix build when IPv6 is disabled
Date: Fri, 14 May 2021 17:40:10 +0000 [thread overview]
Message-ID: <162101401065.20897.4000953716606078069.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210514015348.15448-1-mcroce@linux.microsoft.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 14 May 2021 03:53:48 +0200 you wrote:
> From: Matteo Croce <mcroce@microsoft.com>
>
> The br_ip6_multicast_add_router() prototype is defined only when
> CONFIG_IPV6 is enabled, but the function is always referenced, so there
> is this build error with CONFIG_IPV6 not defined:
>
> net/bridge/br_multicast.c: In function ‘__br_multicast_enable_port’:
> net/bridge/br_multicast.c:1743:3: error: implicit declaration of function ‘br_ip6_multicast_add_router’; did you mean ‘br_ip4_multicast_add_router’? [-Werror=implicit-function-declaration]
> 1743 | br_ip6_multicast_add_router(br, port);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> | br_ip4_multicast_add_router
> net/bridge/br_multicast.c: At top level:
> net/bridge/br_multicast.c:2804:13: warning: conflicting types for ‘br_ip6_multicast_add_router’
> 2804 | static void br_ip6_multicast_add_router(struct net_bridge *br,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/bridge/br_multicast.c:2804:13: error: static declaration of ‘br_ip6_multicast_add_router’ follows non-static declaration
> net/bridge/br_multicast.c:1743:3: note: previous implicit declaration of ‘br_ip6_multicast_add_router’ was here
> 1743 | br_ip6_multicast_add_router(br, port);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [net-next] net: bridge: fix build when IPv6 is disabled
https://git.kernel.org/netdev/net-next/c/30515832e987
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linus.luessing@c0d3.blue, roopa@nvidia.com, nikolay@nvidia.com,
davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: bridge: fix build when IPv6 is disabled
Date: Fri, 14 May 2021 17:40:10 +0000 [thread overview]
Message-ID: <162101401065.20897.4000953716606078069.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210514015348.15448-1-mcroce@linux.microsoft.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 14 May 2021 03:53:48 +0200 you wrote:
> From: Matteo Croce <mcroce@microsoft.com>
>
> The br_ip6_multicast_add_router() prototype is defined only when
> CONFIG_IPV6 is enabled, but the function is always referenced, so there
> is this build error with CONFIG_IPV6 not defined:
>
> net/bridge/br_multicast.c: In function ‘__br_multicast_enable_port’:
> net/bridge/br_multicast.c:1743:3: error: implicit declaration of function ‘br_ip6_multicast_add_router’; did you mean ‘br_ip4_multicast_add_router’? [-Werror=implicit-function-declaration]
> 1743 | br_ip6_multicast_add_router(br, port);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> | br_ip4_multicast_add_router
> net/bridge/br_multicast.c: At top level:
> net/bridge/br_multicast.c:2804:13: warning: conflicting types for ‘br_ip6_multicast_add_router’
> 2804 | static void br_ip6_multicast_add_router(struct net_bridge *br,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/bridge/br_multicast.c:2804:13: error: static declaration of ‘br_ip6_multicast_add_router’ follows non-static declaration
> net/bridge/br_multicast.c:1743:3: note: previous implicit declaration of ‘br_ip6_multicast_add_router’ was here
> 1743 | br_ip6_multicast_add_router(br, port);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [net-next] net: bridge: fix build when IPv6 is disabled
https://git.kernel.org/netdev/net-next/c/30515832e987
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-05-14 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 1:53 [Bridge] [PATCH net-next] net: bridge: fix build when IPv6 is disabled Matteo Croce
2021-05-14 1:53 ` Matteo Croce
2021-05-14 7:26 ` [Bridge] " Nikolay Aleksandrov
2021-05-14 7:26 ` Nikolay Aleksandrov
2021-05-14 9:24 ` [Bridge] " Linus Lüssing
2021-05-14 9:24 ` Linus Lüssing
2021-05-14 17:40 ` patchwork-bot+netdevbpf [this message]
2021-05-14 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162101401065.20897.4000953716606078069.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.