Re: [RFC PATCH net-next] sh_eth: add support for r8a7790 SoC

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Magnus,

On Friday 10 May 2013 17:35:33 Magnus Damm wrote:
> On Fri, May 10, 2013 at 5:01 PM, Simon Horman wrote:
> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > 
> >  drivers/net/ethernet/renesas/Kconfig  |  2 +-
> >  drivers/net/ethernet/renesas/sh_eth.c | 10 ++++++++--
> >  drivers/net/ethernet/renesas/sh_eth.h |  1 +
> >  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> Thanks for your work on this driver.
> 
> > diff --git a/drivers/net/ethernet/renesas/Kconfig
> > b/drivers/net/ethernet/renesas/Kconfig index bed9841..d664c0f 100644
> > --- a/drivers/net/ethernet/renesas/Kconfig
> > +++ b/drivers/net/ethernet/renesas/Kconfig
> > @@ -9,7 +9,7 @@ config SH_ETH
> > 
> >                  CPU_SUBTYPE_SH7763 || CPU_SUBTYPE_SH7619 || \
> >                  CPU_SUBTYPE_SH7724 || CPU_SUBTYPE_SH7734 || \
> >                  CPU_SUBTYPE_SH7757 || ARCH_R8A7740 || \
> > 
> > -                ARCH_R8A7778 || ARCH_R8A7779)
> > +                ARCH_R8A7778 || ARCH_R8A7779 || ARCH_R8A7790)
> 
> As much as I want to see R8A7790 support right away, wouldn't it be
> nice _not_ to have this dependency crap in the Kconfig? We are already
> multi-SoC within mach-shmobile ARM and soon we will be multi-subarch.

I'm really looking forward to that. Is anyone working on getting rid of 
CONFIG_MEMORY_START and CONFIG_MEMORY_SIZE ?

> I actually thought that this was already taken care of. What is your
> opinion? Perhaps there are already queued up cleanup patches that
> handle this?

-- 
Regards,

Laurent Pinchart