All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuri Tikhonov <yur@emcraft.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: wd@denx.de, dzu@denx.de, linux-kernel@vger.kernel.org,
	miltonm@bga.com, linuxppc-dev@ozlabs.org, paulus@samba.org,
	viro@zeniv.linux.org.uk, Hugh Dickins <hugh@veritas.com>,
	Geert.Uytterhoeven@sonycom.com, yanok@emcraft.com
Subject: Re[2]: [PATCH][v2] fork_init: fix division by zero
Date: Fri, 19 Dec 2008 08:49:10 +0300	[thread overview]
Message-ID: <1626525439.20081219084910@emcraft.com> (raw)
In-Reply-To: <20081218144553.91226f50.akpm@linux-foundation.org>

=0D=0AHello Andrew,

On Friday, December 19, 2008 you wrote:
[snip]
>>  There is one more warning from the common code when I use 256KB pages:
>>=20
>>    CC      mm/shmem.o
>> mm/shmem.c: In function 'shmem_truncate_range':
>> mm/shmem.c:613: warning: division by zero
>> mm/shmem.c:619: warning: division by zero
>> mm/shmem.c:644: warning: division by zero
>> mm/shmem.c: In function 'shmem_unuse_inode':
>> mm/shmem.c:873: warning: division by zero
>>=20
>>  The problem here is that ENTRIES_PER_PAGEPAGE becomes 0x1.0000.0000
>> when PAGE_SIZE is 256K.
>>=20
>>  How about the following fix ?

[snip]

> Looks sane.

 Thanks for reviewing.

> But to apply this I'd prefer a changelog, a signoff and a grunt from Hugh.

 Sure, I'll post this in the separate thread then; keeping Hugh in CC.

 Regards, Yuri

 --
 Yuri Tikhonov, Senior Software Engineer
 Emcraft Systems, www.emcraft.com

WARNING: multiple messages have this Message-ID (diff)
From: Yuri Tikhonov <yur@emcraft.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: paulus@samba.org, wd@denx.de, dzu@denx.de,
	linux-kernel@vger.kernel.org, <miltonm@bga.com>,
	<linuxppc-dev@ozlabs.org>, <viro@zeniv.linux.org.uk>,
	<Geert.Uytterhoeven@sonycom.com>, <yanok@emcraft.com>,
	Hugh Dickins <hugh@veritas.com>
Subject: Re[2]: [PATCH][v2] fork_init: fix division by zero
Date: Fri, 19 Dec 2008 08:49:10 +0300	[thread overview]
Message-ID: <1626525439.20081219084910@emcraft.com> (raw)
In-Reply-To: <20081218144553.91226f50.akpm@linux-foundation.org>


Hello Andrew,

On Friday, December 19, 2008 you wrote:
[snip]
>>  There is one more warning from the common code when I use 256KB pages:
>> 
>>    CC      mm/shmem.o
>> mm/shmem.c: In function 'shmem_truncate_range':
>> mm/shmem.c:613: warning: division by zero
>> mm/shmem.c:619: warning: division by zero
>> mm/shmem.c:644: warning: division by zero
>> mm/shmem.c: In function 'shmem_unuse_inode':
>> mm/shmem.c:873: warning: division by zero
>> 
>>  The problem here is that ENTRIES_PER_PAGEPAGE becomes 0x1.0000.0000
>> when PAGE_SIZE is 256K.
>> 
>>  How about the following fix ?

[snip]

> Looks sane.

 Thanks for reviewing.

> But to apply this I'd prefer a changelog, a signoff and a grunt from Hugh.

 Sure, I'll post this in the separate thread then; keeping Hugh in CC.

 Regards, Yuri

 --
 Yuri Tikhonov, Senior Software Engineer
 Emcraft Systems, www.emcraft.com


  reply	other threads:[~2008-12-19  5:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-10 16:50 [PATCH][v2] fork_init: fix division by zero Yuri Tikhonov
2008-12-10 16:50 ` Yuri Tikhonov
2008-12-11 20:16 ` Andrew Morton
2008-12-11 20:16   ` Andrew Morton
2008-12-11 20:28   ` Al Viro
2008-12-11 20:28     ` Al Viro
2008-12-11 20:43     ` Andrew Morton
2008-12-11 20:43       ` Andrew Morton
2008-12-12  2:31       ` Nick Piggin
2008-12-12  2:31         ` Nick Piggin
2008-12-12  2:47         ` Andrew Morton
2008-12-12  2:47           ` Andrew Morton
2008-12-12  3:36           ` Nick Piggin
2008-12-12  3:36             ` Nick Piggin
2008-12-11 22:22   ` Re[2]: " Yuri Tikhonov
2008-12-11 22:22     ` Yuri Tikhonov
2008-12-11 22:26     ` Andrew Morton
2008-12-11 22:26       ` Andrew Morton
2008-12-12  0:48   ` Paul Mackerras
2008-12-12  0:48     ` Paul Mackerras
2008-12-12  1:07     ` Andrew Morton
2008-12-12  1:07       ` Andrew Morton
2008-12-18  7:47     ` Yuri Tikhonov
2008-12-18  7:47       ` Yuri Tikhonov
2008-12-18 22:45       ` Andrew Morton
2008-12-18 22:45         ` Andrew Morton
2008-12-19  5:49         ` Yuri Tikhonov [this message]
2008-12-19  5:49           ` Re[2]: " Yuri Tikhonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1626525439.20081219084910@emcraft.com \
    --to=yur@emcraft.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=akpm@linux-foundation.org \
    --cc=dzu@denx.de \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=paulus@samba.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wd@denx.de \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.