From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: jiri@resnulli.us, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, idosch@idosch.org,
nikolay@nvidia.com, roopa@nvidia.com, kuba@kernel.org,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device
Date: Tue, 03 Aug 2021 21:40:06 +0000 [thread overview]
Message-ID: <162802680646.18812.7948023061004183994.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210802113633.189831-1-vladimir.oltean@nxp.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 2 Aug 2021 14:36:33 +0300 you wrote:
> Nikolay points out that it is incorrect to assume that it is impossible
> to have an fdb entry with fdb->dst == NULL and the BR_FDB_LOCAL bit in
> fdb->flags not set. This is because there are reader-side places that
> test_bit(BR_FDB_LOCAL, &fdb->flags) without the br->hash_lock, and if
> the updating of the FDB entry happens on another CPU, there are no
> memory barriers at writer or reader side which would ensure that the
> reader sees the updates to both fdb->flags and fdb->dst in the same
> order, i.e. the reader will not see an inconsistent FDB entry.
>
> [...]
Here is the summary with links:
- [net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device
https://git.kernel.org/netdev/net-next/c/2e19bb35ce15
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
jiri@resnulli.us, idosch@idosch.org, roopa@nvidia.com,
nikolay@nvidia.com, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device
Date: Tue, 03 Aug 2021 21:40:06 +0000 [thread overview]
Message-ID: <162802680646.18812.7948023061004183994.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210802113633.189831-1-vladimir.oltean@nxp.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 2 Aug 2021 14:36:33 +0300 you wrote:
> Nikolay points out that it is incorrect to assume that it is impossible
> to have an fdb entry with fdb->dst == NULL and the BR_FDB_LOCAL bit in
> fdb->flags not set. This is because there are reader-side places that
> test_bit(BR_FDB_LOCAL, &fdb->flags) without the br->hash_lock, and if
> the updating of the FDB entry happens on another CPU, there are no
> memory barriers at writer or reader side which would ensure that the
> reader sees the updates to both fdb->flags and fdb->dst in the same
> order, i.e. the reader will not see an inconsistent FDB entry.
>
> [...]
Here is the summary with links:
- [net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device
https://git.kernel.org/netdev/net-next/c/2e19bb35ce15
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2021-08-03 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 11:36 [Bridge] [PATCH net-next] net: bridge: switchdev: fix incorrect use of FDB flags when picking the dst device Vladimir Oltean
2021-08-02 11:36 ` Vladimir Oltean
2021-08-02 11:40 ` [Bridge] " Nikolay Aleksandrov
2021-08-02 11:40 ` Nikolay Aleksandrov
2021-08-03 21:40 ` patchwork-bot+netdevbpf [this message]
2021-08-03 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162802680646.18812.7948023061004183994.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.