All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: ASM <asm@asm.pp.ru>
Cc: dev@dpdk.org
Subject: Re: Build with -Werror=declaration-after-statement
Date: Fri, 02 Sep 2016 15:13:35 +0200	[thread overview]
Message-ID: <1628119.kfExARmFLF@xps13> (raw)
In-Reply-To: <CAMmAVbUao=3+nsAye2wU6u_uyd0LSrxMV9wbqy4kQyWD3OwZfQ@mail.gmail.com>

2016-09-02 13:49, ASM:
> Hi folks!
> 
> Many groups have flag  -Werror=declaration-after-statement in the
> their coding conventions. Dpdk have many code as static inline
> function in the headers files and have trouble with it.
> 
> For example:
> * lib/librte_ether/rte_ether.h, function rte_vlan_strip
> * lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace
> * lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm
> 
> Any project who use  -Werror=declaration-after-statement can't to
> compile own projects without
> patching this headers.
> 
> How do you look at to fix this problem?

It is probably a good fix to have on top of Adrien's series:
	http://dpdk.org/ml/archives/dev/2016-July/043928.html

You are welcome to fix any header to be more widely used :)

      reply	other threads:[~2016-09-02 13:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 10:49 Build with -Werror=declaration-after-statement ASM
2016-09-02 13:13 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628119.kfExARmFLF@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=asm@asm.pp.ru \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.