From: Mason Zhang <mason.zhang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <wsd_upstream@mediatek.com>,
<mason.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param
Date: Thu, 5 Aug 2021 13:23:13 +0800 [thread overview]
Message-ID: <1628140993.20108.4.camel@mbjsdccf07> (raw)
In-Reply-To: <20210803141045.GN4668@sirena.org.uk>
On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> >
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> > drivers/spi/spi-tegra114.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen. This supports
> things like bisection.
>
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.
Dear Mark:
Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
And I have updated the patch v3, and removed the *** int the first
patch.
Thanks
Mason
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Mason Zhang <mason.zhang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <wsd_upstream@mediatek.com>,
<mason.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param
Date: Thu, 5 Aug 2021 13:23:13 +0800 [thread overview]
Message-ID: <1628140993.20108.4.camel@mbjsdccf07> (raw)
In-Reply-To: <20210803141045.GN4668@sirena.org.uk>
On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> >
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> > drivers/spi/spi-tegra114.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen. This supports
> things like bisection.
>
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.
Dear Mark:
Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
And I have updated the patch v3, and removed the *** int the first
patch.
Thanks
Mason
WARNING: multiple messages have this Message-ID (diff)
From: Mason Zhang <mason.zhang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <wsd_upstream@mediatek.com>,
<mason.zhang@mediatek.com>
Subject: Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param
Date: Thu, 5 Aug 2021 13:23:13 +0800 [thread overview]
Message-ID: <1628140993.20108.4.camel@mbjsdccf07> (raw)
In-Reply-To: <20210803141045.GN4668@sirena.org.uk>
On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> >
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> > drivers/spi/spi-tegra114.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen. This supports
> things like bisection.
>
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.
Dear Mark:
Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
And I have updated the patch v3, and removed the *** int the first
patch.
Thanks
Mason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-05 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 10:25 [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param Mason Zhang
2021-08-03 10:25 ` Mason Zhang
2021-08-03 10:25 ` Mason Zhang
2021-08-03 14:10 ` Mark Brown
2021-08-03 14:10 ` Mark Brown
2021-08-03 14:10 ` Mark Brown
2021-08-05 5:23 ` Mason Zhang [this message]
2021-08-05 5:23 ` Mason Zhang
2021-08-05 5:23 ` Mason Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628140993.20108.4.camel@mbjsdccf07 \
--to=mason.zhang@mediatek.com \
--cc=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.