From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC,PATCH] arch/arm: compute and export NR_syscalls
Date: Tue, 16 Aug 2011 23:21:21 +0200 [thread overview]
Message-ID: <1629809.vjtjo6obCs@wuerfel> (raw)
In-Reply-To: <1313529267-4428-1-git-send-email-wad@chromium.org>
On Tuesday 16 August 2011 16:14:26 Will Drewry wrote:
>
> asm-exports.c is added instead of reusing asm-offsets.c to avoid a
> variety of collisions (VM_EXEC, DMA_*, etc). It is possible to use the
> same calls.S mechanism but add NR_syscalls to asm-offsets.c. However,
> at inclusion time for generated/asm-offsets.h, conflicting defines will
> need to be #undef'd if !__ASSEMBLY__ since it appears that the purpose
> of asm-offsets.h is to safely bind C language definitions to assembly
> and not the reverse.
>
> - Is this approach palatable?
> - Should I resend only when paired with the other ftrace-needed patches?
This seems overly complex, compared to a one-line change adding the symbol
to asm/unistd.h. The only other architecture that uses an approach
like the one you have posted is x86-64, and it's simpler there
because it can easily be done in asm-offsets.c there without the need
to create another helper.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Will Drewry <wad@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Mikael Pettersson <mikpe@it.uu.se>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Mike Frysinger <vapier@gentoo.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC,PATCH] arch/arm: compute and export NR_syscalls
Date: Tue, 16 Aug 2011 23:21:21 +0200 [thread overview]
Message-ID: <1629809.vjtjo6obCs@wuerfel> (raw)
In-Reply-To: <1313529267-4428-1-git-send-email-wad@chromium.org>
On Tuesday 16 August 2011 16:14:26 Will Drewry wrote:
>
> asm-exports.c is added instead of reusing asm-offsets.c to avoid a
> variety of collisions (VM_EXEC, DMA_*, etc). It is possible to use the
> same calls.S mechanism but add NR_syscalls to asm-offsets.c. However,
> at inclusion time for generated/asm-offsets.h, conflicting defines will
> need to be #undef'd if !__ASSEMBLY__ since it appears that the purpose
> of asm-offsets.h is to safely bind C language definitions to assembly
> and not the reverse.
>
> - Is this approach palatable?
> - Should I resend only when paired with the other ftrace-needed patches?
This seems overly complex, compared to a one-line change adding the symbol
to asm/unistd.h. The only other architecture that uses an approach
like the one you have posted is x86-64, and it's simpler there
because it can easily be done in asm-offsets.c there without the need
to create another helper.
Arnd
next prev parent reply other threads:[~2011-08-16 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 21:14 [RFC,PATCH] arch/arm: compute and export NR_syscalls Will Drewry
2011-08-16 21:14 ` Will Drewry
2011-08-16 21:21 ` Arnd Bergmann [this message]
2011-08-16 21:21 ` Arnd Bergmann
2011-08-16 21:44 ` Will Drewry
2011-08-16 21:44 ` Will Drewry
2011-08-17 7:28 ` Mikael Pettersson
2011-08-17 7:28 ` Mikael Pettersson
2011-08-17 9:22 ` Arnd Bergmann
2011-08-17 9:22 ` Arnd Bergmann
2011-08-21 9:07 ` Russell King - ARM Linux
2011-08-21 9:07 ` Russell King - ARM Linux
2011-08-22 0:43 ` Will Drewry
2011-08-22 0:43 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629809.vjtjo6obCs@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.