All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivan Shapovalov <intelfx100@gmail.com>
To: reiserfs-devel@vger.kernel.org
Cc: edward.shishkin@gmail.com
Subject: Re: [RFC] [PATCH 5/7] reiser4: txnmgr: call reiser4_post_write_back_hook() for empty atoms.
Date: Sun, 17 Aug 2014 19:59:14 +0400	[thread overview]
Message-ID: <1631803.HLYeHrfQdF@intelfx-laptop> (raw)
In-Reply-To: <1408290206-7427-6-git-send-email-intelfx100@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

On Sunday 17 August 2014 at 19:43:24, Ivan Shapovalov wrote:	
> The atoms generated by reiser4_trim_fs(), despite being empty (zero
> capture_count), still have non-empty delete sets which have to be
> processed.
> 
> Signed-off-by: Ivan Shapovalov <intelfx100@gmail.com>
> ---
>  fs/reiser4/txnmgr.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/reiser4/txnmgr.c b/fs/reiser4/txnmgr.c
> index 2862940..3f44c9c 100644
> --- a/fs/reiser4/txnmgr.c
> +++ b/fs/reiser4/txnmgr.c
> @@ -1064,8 +1064,13 @@ static int commit_current_atom(long *nr_submitted, txn_atom ** atom)
>  		return RETERR(-E_REPEAT);
>  	}
>  
> -	if ((*atom)->capture_count == 0)
> +	if ((*atom)->capture_count == 0) {
> +		/* Process the atom's delete set.
> +		 * Even if the atom has no captured nodes, the delete set may
> +		 * still be non-empty (see e. g. reiser4_trim_fs()). */
> +		reiser4_post_writeback_hook();

Oops, a typo. Will resend the series...

-- 
Ivan Shapovalov / intelfx /

>  		goto done;
> +	}
>  
>  	/* Up to this point we have been flushing and after flush is called we
>  	   return -E_REPEAT.  Now we can commit.  We cannot return -E_REPEAT
> 

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

  reply	other threads:[~2014-08-17 15:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17 15:43 [RFC] [PATCH 0/7] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 1/7] reiser4: block_alloc: add BA_SOME_SPACE flag for grabbing a fixed amount of space Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 2/7] reiser4: block_alloc: add a "forward" parameter to reiser4_blocknr_hint to allocate blocks only in forward direction Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 3/7] reiser4: txnmgr: free allocated but unneeded atom in atom_begin_and_assign_to_txnh() Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 4/7] reiser4: txnmgr: add reiser4_create_atom() which creates an empty atom without capturing any nodes Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 5/7] reiser4: txnmgr: call reiser4_post_write_back_hook() for empty atoms Ivan Shapovalov
2014-08-17 15:59   ` Ivan Shapovalov [this message]
2014-08-17 16:28     ` Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 6/7] reiser4: batch discard support: add a dummy FITRIM ioctl handler for directories Ivan Shapovalov
2014-08-17 15:43 ` [RFC] [PATCH 7/7] reiser4: batch discard support: actually implement the FITRIM ioctl handler Ivan Shapovalov
     [not found] ` <CADW=+3kCURR6UB5Tm8OcJnSYV1cNcYtTmbNNrv_QCO3o1RzwDQ@mail.gmail.com>
2014-08-17 16:18   ` [RFC] [PATCH 0/7] reiser4: batch discard support (FITRIM ioctl): initial implementation Ivan Shapovalov
     [not found]     ` <CADW=+3=B_3pKNzph7EtfXNLbVxxn4dxsykm_RF+ayce9RsoVUQ@mail.gmail.com>
2014-08-17 16:38       ` Ivan Shapovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1631803.HLYeHrfQdF@intelfx-laptop \
    --to=intelfx100@gmail.com \
    --cc=edward.shishkin@gmail.com \
    --cc=reiserfs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.