* [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR
@ 2021-10-20 16:52 Vladimir Oltean
2021-10-21 9:37 ` Claudiu Manoil
2021-10-21 15:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Oltean @ 2021-10-20 16:52 UTC (permalink / raw)
To: netdev, Jakub Kicinski, David S. Miller; +Cc: Claudiu Manoil
There are two counters named "MAC tx frames", one of them is actually
incorrect. The correct name for that counter should be "MAC tx error
frames", which is symmetric to the existing "MAC rx error frames".
Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/freescale/enetc/enetc_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
index 9690e36e9e85..910b9f722504 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_ethtool.c
@@ -157,7 +157,7 @@ static const struct {
{ ENETC_PM0_TFRM, "MAC tx frames" },
{ ENETC_PM0_TFCS, "MAC tx fcs errors" },
{ ENETC_PM0_TVLAN, "MAC tx VLAN frames" },
- { ENETC_PM0_TERR, "MAC tx frames" },
+ { ENETC_PM0_TERR, "MAC tx frame errors" },
{ ENETC_PM0_TUCA, "MAC tx unicast frames" },
{ ENETC_PM0_TMCA, "MAC tx multicast frames" },
{ ENETC_PM0_TBCA, "MAC tx broadcast frames" },
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR
2021-10-20 16:52 [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR Vladimir Oltean
@ 2021-10-21 9:37 ` Claudiu Manoil
2021-10-21 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu Manoil @ 2021-10-21 9:37 UTC (permalink / raw)
To: Vladimir Oltean, netdev@vger.kernel.org, Jakub Kicinski,
David S. Miller
> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> Sent: Wednesday, October 20, 2021 7:52 PM
[...]
> Subject: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR
>
> There are two counters named "MAC tx frames", one of them is actually
> incorrect. The correct name for that counter should be "MAC tx error
> frames", which is symmetric to the existing "MAC rx error frames".
>
> Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
Reviewed-by: <Claudiu Manoil <claudiu.manoil@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR
2021-10-20 16:52 [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR Vladimir Oltean
2021-10-21 9:37 ` Claudiu Manoil
@ 2021-10-21 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-21 15:10 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: netdev, kuba, davem, claudiu.manoil
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 20 Oct 2021 19:52:06 +0300 you wrote:
> There are two counters named "MAC tx frames", one of them is actually
> incorrect. The correct name for that counter should be "MAC tx error
> frames", which is symmetric to the existing "MAC rx error frames".
>
> Fixes: 16eb4c85c964 ("enetc: Add ethtool statistics")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> [...]
Here is the summary with links:
- [net] net: enetc: fix ethtool counter name for PM0_TERR
https://git.kernel.org/netdev/net/c/fb8dc5fc8cbd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 16:52 [PATCH net] net: enetc: fix ethtool counter name for PM0_TERR Vladimir Oltean
2021-10-21 9:37 ` Claudiu Manoil
2021-10-21 15:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.