* [GIT PULL] soc/fsl drivers changes for fix(v5.15)
@ 2021-10-22 1:00 ` Li Yang
0 siblings, 0 replies; 7+ messages in thread
From: Li Yang @ 2021-10-22 1:00 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, linux-kernel, shawnguo
Hi soc maintainers,
Please merge the following new changes for soc/fsl drivers.
Regards,
Leo
The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:
Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git tags/soc-fsl-fix-v5.15
for you to fetch changes up to 7e5e744183bbb0ad02412b21b1e61380c998dd18:
soc: fsl: dpio: fix qbman alignment error in the virtualization context (2021-10-21 18:20:21 -0500)
----------------------------------------------------------------
NXP/FSL SoC driver fixes for v5.15
DPAA2 DPIO driver
- replace smp_processor_id with raw_smp_processor_id to fix preempt
debug BUG
- use the combined functions to protect critical zone to fix deadlock
- fix qbman alignment error in the virtualization context
DPAA2 console
- free buffer before returning from dpaa2_console_read
----------------------------------------------------------------
Diana Craciun (1):
soc: fsl: dpio: fix qbman alignment error in the virtualization context
Meng Li (2):
soc: fsl: dpio: replace smp_processor_id with raw_smp_processor_id
soc: fsl: dpio: use the combined functions to protect critical zone
Robert-Ionut Alexa (1):
soc: fsl: dpaa2-console: free buffer before returning from dpaa2_console_read
drivers/soc/fsl/dpaa2-console.c | 1 +
drivers/soc/fsl/dpio/dpio-service.c | 2 +-
drivers/soc/fsl/dpio/qbman-portal.c | 33 +++++++++++++++------------------
3 files changed, 17 insertions(+), 19 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread* [GIT PULL] soc/fsl drivers changes for fix(v5.15)
@ 2021-10-22 1:00 ` Li Yang
0 siblings, 0 replies; 7+ messages in thread
From: Li Yang @ 2021-10-22 1:00 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, linux-kernel, shawnguo
Hi soc maintainers,
Please merge the following new changes for soc/fsl drivers.
Regards,
Leo
The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:
Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git tags/soc-fsl-fix-v5.15
for you to fetch changes up to 7e5e744183bbb0ad02412b21b1e61380c998dd18:
soc: fsl: dpio: fix qbman alignment error in the virtualization context (2021-10-21 18:20:21 -0500)
----------------------------------------------------------------
NXP/FSL SoC driver fixes for v5.15
DPAA2 DPIO driver
- replace smp_processor_id with raw_smp_processor_id to fix preempt
debug BUG
- use the combined functions to protect critical zone to fix deadlock
- fix qbman alignment error in the virtualization context
DPAA2 console
- free buffer before returning from dpaa2_console_read
----------------------------------------------------------------
Diana Craciun (1):
soc: fsl: dpio: fix qbman alignment error in the virtualization context
Meng Li (2):
soc: fsl: dpio: replace smp_processor_id with raw_smp_processor_id
soc: fsl: dpio: use the combined functions to protect critical zone
Robert-Ionut Alexa (1):
soc: fsl: dpaa2-console: free buffer before returning from dpaa2_console_read
drivers/soc/fsl/dpaa2-console.c | 1 +
drivers/soc/fsl/dpio/dpio-service.c | 2 +-
drivers/soc/fsl/dpio/qbman-portal.c | 33 +++++++++++++++------------------
3 files changed, 17 insertions(+), 19 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* [GIT PULL] soc/fsl drivers changes for next(v5.16)
@ 2021-10-22 1:00 ` Li Yang
0 siblings, 0 replies; 7+ messages in thread
From: Li Yang @ 2021-10-22 1:00 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, linux-kernel, shawnguo
Hi soc maintainers,
Please merge the following new changes for soc/fsl drivers.
Regards,
Leo
The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:
Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git tags/soc-fsl-next-v5.16
for you to fetch changes up to 54c8b5b6f8a868b9c21a7b0efe92ed2fbcc67080:
soc: fsl: dpio: rename the enqueue descriptor variable (2021-10-21 19:38:56 -0500)
----------------------------------------------------------------
NXP/FSL SoC driver updates for v5.16
DPIO Driver
- Code cleanup and fix compile warning
RCMP and Guts Driver
- Make use of the helper function devm_platform_ioremap_resource()
----------------------------------------------------------------
Cai Huoqing (2):
soc: fsl: guts: Make use of the helper function devm_platform_ioremap_resource()
soc: fsl: rcpm: Make use of the helper function devm_platform_ioremap_resource()
Ioana Ciornei (1):
soc: fsl: dpio: use an explicit NULL instead of 0
Youri Querry (1):
soc: fsl: dpio: rename the enqueue descriptor variable
drivers/soc/fsl/dpio/dpio-service.c | 2 +-
drivers/soc/fsl/dpio/qbman-portal.c | 8 ++++----
drivers/soc/fsl/guts.c | 4 +---
drivers/soc/fsl/rcpm.c | 7 +------
4 files changed, 7 insertions(+), 14 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread* [GIT PULL] soc/fsl drivers changes for next(v5.16)
@ 2021-10-22 1:00 ` Li Yang
0 siblings, 0 replies; 7+ messages in thread
From: Li Yang @ 2021-10-22 1:00 UTC (permalink / raw)
To: arm, soc; +Cc: linux-arm-kernel, linux-kernel, shawnguo
Hi soc maintainers,
Please merge the following new changes for soc/fsl drivers.
Regards,
Leo
The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:
Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/leo/linux.git tags/soc-fsl-next-v5.16
for you to fetch changes up to 54c8b5b6f8a868b9c21a7b0efe92ed2fbcc67080:
soc: fsl: dpio: rename the enqueue descriptor variable (2021-10-21 19:38:56 -0500)
----------------------------------------------------------------
NXP/FSL SoC driver updates for v5.16
DPIO Driver
- Code cleanup and fix compile warning
RCMP and Guts Driver
- Make use of the helper function devm_platform_ioremap_resource()
----------------------------------------------------------------
Cai Huoqing (2):
soc: fsl: guts: Make use of the helper function devm_platform_ioremap_resource()
soc: fsl: rcpm: Make use of the helper function devm_platform_ioremap_resource()
Ioana Ciornei (1):
soc: fsl: dpio: use an explicit NULL instead of 0
Youri Querry (1):
soc: fsl: dpio: rename the enqueue descriptor variable
drivers/soc/fsl/dpio/dpio-service.c | 2 +-
drivers/soc/fsl/dpio/qbman-portal.c | 8 ++++----
drivers/soc/fsl/guts.c | 4 +---
drivers/soc/fsl/rcpm.c | 7 +------
4 files changed, 7 insertions(+), 14 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [GIT PULL] soc/fsl drivers changes for next(v5.16)
2021-10-22 1:00 ` Li Yang
(?)
@ 2021-10-22 20:10 ` patchwork-bot+linux-soc
-1 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+linux-soc @ 2021-10-22 20:10 UTC (permalink / raw)
To: Li Yang; +Cc: soc
Hello:
This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Thu, 21 Oct 2021 20:00:27 -0500 you wrote:
> Hi soc maintainers,
>
> Please merge the following new changes for soc/fsl drivers.
>
> Regards,
> Leo
>
> [...]
Here is the summary with links:
- [GIT,PULL] soc/fsl drivers changes for next(v5.16)
https://git.kernel.org/soc/soc/c/ac2561f921e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [GIT PULL] soc/fsl drivers changes for fix(v5.15)
@ 2021-10-22 19:54 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-10-22 19:54 UTC (permalink / raw)
To: Li Yang
Cc: arm-soc, SoC Team, Linux ARM, Linux Kernel Mailing List,
Shawn Guo, Ioana Ciornei, Diana Craciun
On Fri, Oct 22, 2021 at 3:00 AM Li Yang <leoyang.li@nxp.com> wrote:
> ----------------------------------------------------------------
> NXP/FSL SoC driver fixes for v5.15
> - fix qbman alignment error in the virtualization context
This patch looks very suspicious to me, I don't think it's generally safe to
use memcpy_toio() on a normal pointer, as the __iomem tokens may
be in a separate address range, even though this currently works
on arm64. Adding the (__iomem void *) cast without a comment that
explains why it's added seems similarly wrong, and finally the
changeset text does not seem to match what the code does:
According to the text, the pointer is to a virtual address mapped as
"device memory" (i.e. PROT_DEVICE_nGnRE or PROT_DEVICE_nGnRnE),
but the code suggests it's actually write-combining normal
(PROT_NORMAL_NC).
I don't see any discussion of this patch on the mailing list either, so
please resend the pull request without this patch, while we try to figure
out what the driver should actually be doing here.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [GIT PULL] soc/fsl drivers changes for fix(v5.15)
@ 2021-10-22 19:54 ` Arnd Bergmann
0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2021-10-22 19:54 UTC (permalink / raw)
To: Li Yang
Cc: arm-soc, SoC Team, Linux ARM, Linux Kernel Mailing List,
Shawn Guo, Ioana Ciornei, Diana Craciun
On Fri, Oct 22, 2021 at 3:00 AM Li Yang <leoyang.li@nxp.com> wrote:
> ----------------------------------------------------------------
> NXP/FSL SoC driver fixes for v5.15
> - fix qbman alignment error in the virtualization context
This patch looks very suspicious to me, I don't think it's generally safe to
use memcpy_toio() on a normal pointer, as the __iomem tokens may
be in a separate address range, even though this currently works
on arm64. Adding the (__iomem void *) cast without a comment that
explains why it's added seems similarly wrong, and finally the
changeset text does not seem to match what the code does:
According to the text, the pointer is to a virtual address mapped as
"device memory" (i.e. PROT_DEVICE_nGnRE or PROT_DEVICE_nGnRnE),
but the code suggests it's actually write-combining normal
(PROT_NORMAL_NC).
I don't see any discussion of this patch on the mailing list either, so
please resend the pull request without this patch, while we try to figure
out what the driver should actually be doing here.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-22 20:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-22 1:00 [GIT PULL] soc/fsl drivers changes for fix(v5.15) Li Yang
2021-10-22 1:00 ` Li Yang
2021-10-22 1:00 ` [GIT PULL] soc/fsl drivers changes for next(v5.16) Li Yang
2021-10-22 1:00 ` Li Yang
2021-10-22 20:10 ` patchwork-bot+linux-soc
2021-10-22 19:54 ` [GIT PULL] soc/fsl drivers changes for fix(v5.15) Arnd Bergmann
2021-10-22 19:54 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.